mirror of
git://git.sv.gnu.org/emacs.git
synced 2025-12-06 06:20:55 -08:00
cedet: Don't abuse initargs for slot names
* lisp/cedet/ede/base.el (ede-normalize-file/directory): * lisp/cedet/ede/emacs.el (initialize-instance): * lisp/cedet/ede/generic.el (initialize-instance): * lisp/cedet/ede/linux.el (initialize-instance, project-rescan): * lisp/cedet/srecode/map.el (srecode-map-update-map): * lisp/cedet/srecode/srt-mode.el (srecode-parse-this-macro): * lisp/cedet/ede/simple.el (ede-simple-load): Use slot names rather than initargs with oref/oset/slot-value/...
This commit is contained in:
parent
05680dc6c5
commit
48b41d595c
7 changed files with 15 additions and 15 deletions
|
|
@ -627,14 +627,14 @@ instead of the current project."
|
||||||
"Fills :directory or :file slots if they're missing in project THIS.
|
"Fills :directory or :file slots if they're missing in project THIS.
|
||||||
The other slot will be used to calculate values.
|
The other slot will be used to calculate values.
|
||||||
PROJECT-FILE-NAME is a name of project file (short name, like `pom.xml', etc."
|
PROJECT-FILE-NAME is a name of project file (short name, like `pom.xml', etc."
|
||||||
(when (and (or (not (slot-boundp this :file))
|
(when (and (not (and (slot-boundp this 'file)
|
||||||
(not (oref this file)))
|
(oref this file)))
|
||||||
(slot-boundp this :directory)
|
(slot-boundp this 'directory)
|
||||||
(oref this directory))
|
(oref this directory))
|
||||||
(oset this file (expand-file-name project-file-name (oref this directory))))
|
(oset this file (expand-file-name project-file-name (oref this directory))))
|
||||||
(when (and (or (not (slot-boundp this :directory))
|
(when (and (not (and (slot-boundp this 'directory)
|
||||||
(not (oref this directory)))
|
(oref this directory)))
|
||||||
(slot-boundp this :file)
|
(slot-boundp this 'file)
|
||||||
(oref this file))
|
(oref this file))
|
||||||
(oset this directory (file-name-directory (oref this file))))
|
(oset this directory (file-name-directory (oref this file))))
|
||||||
)
|
)
|
||||||
|
|
|
||||||
|
|
@ -118,7 +118,7 @@ All directories need at least one target.")
|
||||||
"Make sure the targets slot is bound."
|
"Make sure the targets slot is bound."
|
||||||
(cl-call-next-method)
|
(cl-call-next-method)
|
||||||
(unless (slot-boundp this 'targets)
|
(unless (slot-boundp this 'targets)
|
||||||
(oset this :targets nil)))
|
(oset this targets nil)))
|
||||||
|
|
||||||
;;; File Stuff
|
;;; File Stuff
|
||||||
;;
|
;;
|
||||||
|
|
|
||||||
|
|
@ -153,7 +153,7 @@ The class allocated value is replace by different sub classes.")
|
||||||
"Make sure the targets slot is bound."
|
"Make sure the targets slot is bound."
|
||||||
(cl-call-next-method)
|
(cl-call-next-method)
|
||||||
(unless (slot-boundp this 'targets)
|
(unless (slot-boundp this 'targets)
|
||||||
(oset this :targets nil))
|
(oset this targets nil))
|
||||||
)
|
)
|
||||||
|
|
||||||
(cl-defmethod ede-project-root ((this ede-generic-project))
|
(cl-defmethod ede-project-root ((this ede-generic-project))
|
||||||
|
|
|
||||||
|
|
@ -227,7 +227,7 @@ All directories need at least one target.")
|
||||||
"Make sure the targets slot is bound."
|
"Make sure the targets slot is bound."
|
||||||
(cl-call-next-method)
|
(cl-call-next-method)
|
||||||
(unless (slot-boundp this 'targets)
|
(unless (slot-boundp this 'targets)
|
||||||
(oset this :targets nil)))
|
(oset this targets nil)))
|
||||||
|
|
||||||
;;; File Stuff
|
;;; File Stuff
|
||||||
;;
|
;;
|
||||||
|
|
@ -377,9 +377,9 @@ Argument COMMAND is the command to use for compiling the target."
|
||||||
(inc (ede-linux--include-path dir bdir arch))
|
(inc (ede-linux--include-path dir bdir arch))
|
||||||
(ver (ede-linux-version dir)))
|
(ver (ede-linux-version dir)))
|
||||||
(oset this version ver)
|
(oset this version ver)
|
||||||
(oset this :build-directory bdir)
|
(oset this build-directory bdir)
|
||||||
(oset this :architecture arch)
|
(oset this architecture arch)
|
||||||
(oset this :include-path inc)
|
(oset this include-path inc)
|
||||||
))
|
))
|
||||||
|
|
||||||
(provide 'ede/linux)
|
(provide 'ede/linux)
|
||||||
|
|
|
||||||
|
|
@ -86,7 +86,7 @@ ROOTPROJ is nil, since we will only create a single EDE project here."
|
||||||
(obj nil))
|
(obj nil))
|
||||||
(when pf
|
(when pf
|
||||||
(setq obj (eieio-persistent-read pf))
|
(setq obj (eieio-persistent-read pf))
|
||||||
(oset obj :directory dir)
|
(oset obj directory dir)
|
||||||
)
|
)
|
||||||
obj))
|
obj))
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -338,7 +338,7 @@ if that file is NEW, otherwise assume the mode has not changed."
|
||||||
;; Only do the save if we are dirty, or if we are in an interactive
|
;; Only do the save if we are dirty, or if we are in an interactive
|
||||||
;; Emacs.
|
;; Emacs.
|
||||||
(when (and dirty (not noninteractive)
|
(when (and dirty (not noninteractive)
|
||||||
(slot-boundp srecode-current-map :file))
|
(slot-boundp srecode-current-map 'file))
|
||||||
(eieio-persistent-save srecode-current-map))
|
(eieio-persistent-save srecode-current-map))
|
||||||
))
|
))
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -503,7 +503,7 @@ section or ? for an ask variable."
|
||||||
(when inserter
|
(when inserter
|
||||||
(let ((base
|
(let ((base
|
||||||
(cons (oref inserter object-name)
|
(cons (oref inserter object-name)
|
||||||
(if (and (slot-boundp inserter :secondname)
|
(if (and (slot-boundp inserter 'secondname)
|
||||||
(oref inserter secondname))
|
(oref inserter secondname))
|
||||||
(split-string (oref inserter secondname)
|
(split-string (oref inserter secondname)
|
||||||
":")
|
":")
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue