From 45db0ef1bf7fffefa9b5fa6ed0128e44a2225fcb Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Fri, 31 Oct 2014 15:10:00 +0000 Subject: [PATCH] Better cross-reference. Copied from Perforce Change: 187426 ServerID: perforce.ravenbrook.com --- mps/code/ss.c | 2 +- mps/design/ss.txt | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/mps/code/ss.c b/mps/code/ss.c index 733cd573228..ae387b4c4c4 100644 --- a/mps/code/ss.c +++ b/mps/code/ss.c @@ -46,7 +46,7 @@ Res StackScan(ScanState ss, Addr *stackBot) AVERT(ScanState, ss); arena = ss->arena; - /* See */ + /* See */ AVER(arena->scAtArenaEnter); if (arena->scAtArenaEnter) { res = stackScanInner(arena, ss, stackBot, arena->scAtArenaEnter); diff --git a/mps/design/ss.txt b/mps/design/ss.txt index 069b1e90a69..bf94264dea4 100644 --- a/mps/design/ss.txt +++ b/mps/design/ss.txt @@ -74,6 +74,14 @@ mail.richard.2012-08-03.14-36_. _`.sol.entry-points`: To meet `.req.stack.entry`_, the mutator's registers and stack must be recorded when the mutator enters the MPS. +_`.sol.entry-points.fragile`: The analysis of which entry points might +need to save the context (see `.anal.entry-points`_ below) is fragile. +It might be incorrect now, or become incomplete if we refactor the +internals of tracing and polling. As a defence against errors of this +form, ``StackScan()`` asserts that the context was saved, but if the +client program continues from the assertion, it saves the context +anyway and continues. + _`.sol.registers`: Implementations spill the root registers onto the stack so that they can be scanned there. @@ -110,14 +118,6 @@ introduces a dependency on that library. .. _here: http://stackoverflow.com/questions/3592914/how-can-i-implement-cooperative-lightweight-threading-with-c-on-mac-os-x -_`.sol.entry-points.fragile`: The analysis of which entry points might -need to save the context (see `.anal.entry-points`_ below) is fragile. -It might be incorrect now, or become incomplete if we refactor the -internals of tracing and polling. As a defence against errors of this -form, ``StackScan()`` asserts that the context was saved, but if the -client program continues from the assertion, it saves the context -anyway and continues. - Analysis --------