mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-28 08:11:05 -08:00
Code Issues Projects Releases Wiki Activity

Slightly faster hash-table-keys and hash-table-values

Browse source 
* lisp/emacs-lisp/subr-x.el (hash-table-keys, hash-table-values):
Omit the reversal of the returned list.  It is not ordered anyway.
* test/lisp/emacs-lisp/subr-x-tests.el
(subr-x--hash-table-keys-and-values): New test.
This commit is contained in:
Mattias Engdegård 2022-06-17 19:13:33 +02:00
parent a203ad5ed0
commit 4311bd0bd7
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lisp/emacs-lisp/subr-x.el
View file

@ -87,11 +87,15 @@ threading."
(defsubst hash-table-keys (hash-table) (defsubst hash-table-keys (hash-table)
"Return a list of keys in HASH-TABLE." "Return a list of keys in HASH-TABLE."
(cl-loop for k being the hash-keys of hash-table collect k)) (let ((keys nil))
(maphash (lambda (k _) (push k keys)) hash-table)
keys))
(defsubst hash-table-values (hash-table) (defsubst hash-table-values (hash-table)
"Return a list of values in HASH-TABLE." "Return a list of values in HASH-TABLE."
(cl-loop for v being the hash-values of hash-table collect v)) (let ((values nil))
(maphash (lambda (_ v) (push v values)) hash-table)
values))
(defsubst string-empty-p (string) (defsubst string-empty-p (string)
"Check whether STRING is empty." "Check whether STRING is empty."

7
test/lisp/emacs-lisp/subr-x-tests.el
View file

@ -743,6 +743,13 @@
(with-current-buffer inner (with-current-buffer inner
(should-not (buffer-modified-p)))))))) (should-not (buffer-modified-p))))))))
(ert-deftest subr-x--hash-table-keys-and-values ()
(let ((h (make-hash-table)))
(puthash 'a 1 h)
(puthash 'c 3 h)
(puthash 'b 2 h)
(should (equal (sort (hash-table-keys h) #'string<) '(a b c)))
(should (equal (sort (hash-table-values h) #'<) '(1 2 3)))))
(provide 'subr-x-tests) (provide 'subr-x-tests)
;;; subr-x-tests.el ends here ;;; subr-x-tests.el ends here