mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-15 10:30:25 -08:00
Code Issues Projects Releases Wiki Activity

Improve drag and drop on MS-Windows (bug#3468)

Browse source 
Add support for 'dnd-scroll-margin' and 'dnd-indicate-insertion-point'
by calling 'dnd-handle-movement' when dragging the mouse.

* lisp/term/w32-win.el (w32-drag-n-drop): Call 'dnd-handle-movement'
when applicable.
* src/w32fns.c (w32_handle_drag_movement): New function, sends a
WM_EMACS_DRAGOVER message.
(w32_drop_target_DragEnter): Call 'w32_handle_drag_movement'.
(w32_drop_target_DragOver): Call 'w32_handle_drag_movement'.
* src/w32term.c: (w32_read_socket): Handle WM_EMACS_DRAGOVER,
sending a drag-n-drop event.
* src/w32term.h: Define new WM_EMACS_DRAGOVER message.
This commit is contained in:
Cecilio Pardo 2024-10-23 14:41:24 +02:00 • committed by Eli Zaretskii
parent df677f65fd
commit 3eb2a85d10
5 changed files with 68 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

51
lisp/term/w32-win.el
View file

@ -137,35 +137,40 @@ buffers, and switch to the buffer that visits the last dropped file.
If EVENT is for text, insert that text at point into the buffer
shown in the window that is the target of the drop; if that buffer is
read-only, add the dropped text to kill-ring.
If EVENT payload is nil, then this is a drag event.
If the optional argument NEW-FRAME is non-nil, perform the
drag-n-drop action in a newly-created frame using its selected-window
and that window's buffer."
(interactive "e")
(save-excursion
;; Make sure the drop target has positive co-ords
;; before setting the selected frame - otherwise it
;; won't work. <skx@tardis.ed.ac.uk>
(let* ((window (posn-window (event-start event)))
(coords (posn-x-y (event-start event)))
(arg (car (cdr (cdr event))))
(x (car coords))
(y (cdr coords)))
(if (and (> x 0) (> y 0))
(set-frame-selected-window nil window))
;; Make sure the drop target has positive co-ords
;; before setting the selected frame - otherwise it
;; won't work. <skx@tardis.ed.ac.uk>
(let* ((window (posn-window (event-start event)))
(coords (posn-x-y (event-start event)))
(arg (car (cdr (cdr event))))
(x (car coords))
(y (cdr coords)))
(when new-frame
(select-frame (make-frame)))
(raise-frame)
(setq window (selected-window))
(if (and (> x 0) (> y 0) (window-live-p window))
(set-frame-selected-window nil window))
;; Don't create new frame if we are just dragging
(and arg new-frame
(select-frame (make-frame)))
(raise-frame)
(setq window (selected-window))
;; arg (the payload of the event) is a string when the drop is
;; text, and a list of strings when the drop is one or more files.
(if (stringp arg)
(dnd-insert-text window 'copy arg)
(dnd-handle-multiple-urls
window
(mapcar #'w32-dropped-file-to-url arg)
'private)))))
;; arg (the payload of the event) is a string when the drop is
;; text, and a list of strings when the drop is one or more files.
;; It is nil if the event is a drag event.
(if arg
(save-excursion
(if (stringp arg)
(dnd-insert-text window 'copy arg)
(dnd-handle-multiple-urls
window
(mapcar #'w32-dropped-file-to-url arg)
'private)))
(dnd-handle-movement (event-start event)))))
(defun w32-drag-n-drop-other-frame (event)
"Edit the files listed in the drag-n-drop EVENT, in other frames.