mirror of
git://git.sv.gnu.org/emacs.git
synced 2025-12-25 06:50:46 -08:00
Update Android port
* java/org/gnu/emacs/EmacsInputConnection.java (EmacsInputConnection, beginBatchEdit, reset, endBatchEdit): Keep track of the number of batch edits and return an appropriate value. (takeSnapshot): Implement function. * java/org/gnu/emacs/EmacsNative.java (takeSnapshot): New function. * java/org/gnu/emacs/EmacsService.java (resetIC): Improve debugging output. * java/org/gnu/emacs/EmacsView.java (onCreateInputConnection): Call `reset' to clear the UI side batch edit count. * src/androidterm.c (struct android_get_surrounding_text_context): New fields `conversion_start' and `conversion_end'. (android_get_surrounding_text): Return the conversion region. (android_get_surrounding_text_internal, NATIVE_NAME): Factor out `getSurroundingText'. (takeSnapshot): New function.
This commit is contained in:
parent
ca120044ac
commit
363e293cc9
5 changed files with 203 additions and 26 deletions
|
|
@ -50,6 +50,11 @@ public final class EmacsInputConnection implements InputConnection
|
|||
/* The handle ID associated with that view's window. */
|
||||
private short windowHandle;
|
||||
|
||||
/* Number of batch edits currently underway. Used to avoid
|
||||
synchronizing with the Emacs thread after each
|
||||
`endBatchEdit'. */
|
||||
private int batchEditCount;
|
||||
|
||||
/* Whether or not to synchronize and call `updateIC' with the
|
||||
selection position after committing text.
|
||||
|
||||
|
|
@ -110,6 +115,10 @@ public final class EmacsInputConnection implements InputConnection
|
|||
Log.d (TAG, "beginBatchEdit");
|
||||
|
||||
EmacsNative.beginBatchEdit (windowHandle);
|
||||
|
||||
/* Keep a record of the number of outstanding batch edits here as
|
||||
well. */
|
||||
batchEditCount++;
|
||||
return true;
|
||||
}
|
||||
|
||||
|
|
@ -125,7 +134,14 @@ public final class EmacsInputConnection implements InputConnection
|
|||
Log.d (TAG, "endBatchEdit");
|
||||
|
||||
EmacsNative.endBatchEdit (windowHandle);
|
||||
return true;
|
||||
|
||||
/* Subtract one from the UI thread record of the number of batch
|
||||
edits currently under way. */
|
||||
|
||||
if (batchEditCount > 0)
|
||||
batchEditCount -= 1;
|
||||
|
||||
return batchEditCount > 0;
|
||||
}
|
||||
|
||||
public boolean
|
||||
|
|
@ -584,6 +600,42 @@ public final class EmacsInputConnection implements InputConnection
|
|||
return text;
|
||||
}
|
||||
|
||||
@Override
|
||||
public TextSnapshot
|
||||
takeSnapshot ()
|
||||
{
|
||||
TextSnapshot snapshot;
|
||||
|
||||
/* Return if the input connection is out of date. */
|
||||
if (view.icSerial < view.icGeneration)
|
||||
return null;
|
||||
|
||||
snapshot = EmacsNative.takeSnapshot (windowHandle);
|
||||
|
||||
if (EmacsService.DEBUG_IC)
|
||||
Log.d (TAG, ("takeSnapshot: "
|
||||
+ snapshot.getSurroundingText ().getText ()
|
||||
+ " @ " + snapshot.getCompositionEnd ()
|
||||
+ ", " + snapshot.getCompositionStart ()));
|
||||
|
||||
return snapshot;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void
|
||||
closeConnection ()
|
||||
{
|
||||
batchEditCount = 0;
|
||||
}
|
||||
|
||||
|
||||
|
||||
public void
|
||||
reset ()
|
||||
{
|
||||
batchEditCount = 0;
|
||||
}
|
||||
|
||||
|
||||
/* Override functions which are not implemented. */
|
||||
|
||||
|
|
@ -594,13 +646,6 @@ public final class EmacsInputConnection implements InputConnection
|
|||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void
|
||||
closeConnection ()
|
||||
{
|
||||
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean
|
||||
commitContent (InputContentInfo inputContentInfo, int flags,
|
||||
|
|
@ -616,13 +661,6 @@ public final class EmacsInputConnection implements InputConnection
|
|||
return false;
|
||||
}
|
||||
|
||||
@Override
|
||||
public TextSnapshot
|
||||
takeSnapshot ()
|
||||
{
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean
|
||||
clearMetaKeyStates (int states)
|
||||
|
|
|
|||
|
|
@ -26,6 +26,7 @@ import android.graphics.Bitmap;
|
|||
import android.view.inputmethod.ExtractedText;
|
||||
import android.view.inputmethod.ExtractedTextRequest;
|
||||
import android.view.inputmethod.SurroundingText;
|
||||
import android.view.inputmethod.TextSnapshot;
|
||||
|
||||
public final class EmacsNative
|
||||
{
|
||||
|
|
@ -230,6 +231,7 @@ public final class EmacsNative
|
|||
public static native SurroundingText getSurroundingText (short window,
|
||||
int left, int right,
|
||||
int flags);
|
||||
public static native TextSnapshot takeSnapshot (short window);
|
||||
|
||||
|
||||
/* Return the current value of the selection, or -1 upon
|
||||
|
|
|
|||
|
|
@ -767,8 +767,31 @@ public final class EmacsService extends Service
|
|||
public void
|
||||
resetIC (EmacsWindow window, int icMode)
|
||||
{
|
||||
int oldMode;
|
||||
|
||||
if (DEBUG_IC)
|
||||
Log.d (TAG, "resetIC: " + window);
|
||||
Log.d (TAG, "resetIC: " + window + ", " + icMode);
|
||||
|
||||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU
|
||||
&& (oldMode = window.view.getICMode ()) == icMode
|
||||
/* Don't do this if there is currently no input
|
||||
connection. */
|
||||
&& oldMode != IC_MODE_NULL)
|
||||
{
|
||||
if (DEBUG_IC)
|
||||
Log.d (TAG, "resetIC: calling invalidateInput");
|
||||
|
||||
/* Android 33 and later allow the IM reset to be optimized out
|
||||
and replaced by a call to `invalidateInput', which is much
|
||||
faster, as it does not involve resetting the input
|
||||
connection. */
|
||||
|
||||
icBeginSynchronous ();
|
||||
window.view.imManager.invalidateInput (window.view);
|
||||
icEndSynchronous ();
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
window.view.setICMode (icMode);
|
||||
|
||||
|
|
|
|||
|
|
@ -681,6 +681,9 @@ public final class EmacsView extends ViewGroup
|
|||
|
||||
if (inputConnection == null)
|
||||
inputConnection = new EmacsInputConnection (this);
|
||||
else
|
||||
/* Clear several pieces of state in the input connection. */
|
||||
inputConnection.reset ();
|
||||
|
||||
/* Return the input connection. */
|
||||
return inputConnection;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue