mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-15 10:30:25 -08:00
Code Issues Projects Releases Wiki Activity

Disable process tracing before launching /system/bin/su

Browse source 
* lisp/net/tramp-androidsu.el
(tramp-androidsu-maybe-open-connection): Disable process tracing
around start-process, that the setuid su binary may be started
regardless of its status.
This commit is contained in:
Po Lu 2024-02-27 10:05:56 +08:00
parent b3eb49a466
commit 32b4f9d21b
1 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
lisp/net/tramp-androidsu.el
View file

@ -55,6 +55,8 @@
(add-to-list 'tramp-default-host-alist
`(,tramp-androidsu-method nil "localhost")))
(defvar android-use-exec-loader) ; androidfns.c.
(defun tramp-androidsu-maybe-open-connection (vec)
"Open a connection VEC if not already open.
Mostly identical to `tramp-adb-maybe-open-connection', but also disables
@ -84,14 +86,17 @@ multibyte mode and waits for the shell prompt to appear."
(tramp-file-name-method vec)))
(let* ((coding-system-for-read 'utf-8-unix)
(process-connection-type tramp-process-connection-type)
(p (apply
#'start-process
(tramp-get-connection-name vec)
(tramp-get-connection-buffer vec)
(append
`(,tramp-encoding-shell)
(and tramp-encoding-command-interactive
`(,tramp-encoding-command-interactive)))))
;; The executable loader cannot execute setuid
;; binaries, such as su.
(android-use-exec-loader nil)
(p (start-process (tramp-get-connection-name vec)
(tramp-get-connection-buffer vec)
;; Disregard
;; tramp-encoding-shell, as
;; there's no guarantee that it's
;; possible to execute with
;; `android-use-exec-loader' off.
"/system/bin/sh" "-i"))
(user (tramp-file-name-user vec))
command)
;; Set sentinel. Initialize variables.