mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-02-03 14:10:47 -08:00
Code Issues Projects Releases Wiki Activity

(edebug-tests-trivial-comma): Avoid interaction (bug#69406)

Browse source 
* test/lisp/emacs-lisp/edebug-tests.el (edebug-tests-trivial-backquote):
Don't use obsolete `edebug-eval-defun`.
(edebug-tests-trivial-comma): Use `inhibit-read-only`; don't use
obsolete `edebug-eval-defun`; and fix bug#69406 by binding
`eval-expression-debug-on-error`.
This commit is contained in:
Stefan Monnier 2024-02-26 12:33:35 -05:00
parent 76fa7f1f2f
commit 25cfccfb8b
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/lisp/emacs-lisp/edebug-tests.el
View file

@ -860,8 +860,7 @@ test and possibly others should be updated."
(let ((inhibit-read-only t))
(delete-region (point-min) (point-max))
(insert "`1"))
(with-suppressed-warnings ((obsolete edebug-eval-defun))
(edebug-eval-defun nil))
(eval-defun nil)
;; `eval-defun' outputs its message to the echo area in a rather
;; funny way, so the "1" and the " (#o1, #x1, ?\C-a)" end up placed
;; there in separate pieces (via `print' rather than via `message').
@ -871,18 +870,21 @@ test and possibly others should be updated."
(setq edebug-initial-mode 'go)
;; In Bug#23651 Edebug would hang reading `1.
(with-suppressed-warnings ((obsolete edebug-eval-defun))
(edebug-eval-defun t))))
(eval-defun t)
(should (string-match-p (regexp-quote " (#o1, #x1, ?\\C-a)")
edebug-tests-messages))))
(ert-deftest edebug-tests-trivial-comma ()
"Edebug can read a trivial comma expression (Bug#23651)."
(edebug-tests-with-normal-env
(read-only-mode -1)
(delete-region (point-min) (point-max))
(insert ",1")
(read-only-mode)
(with-suppressed-warnings ((obsolete edebug-eval-defun))
(should-error (edebug-eval-defun t)))))
(let ((inhibit-read-only t))
(delete-region (point-min) (point-max))
(insert ",1"))
;; FIXME: This currently signals a "Source has changed" error, which is
;; itself a bug (the source hasn't changed). All we're testing here
;; is that the Edebug gets past the step of reading the sexp.
(should-error (let ((eval-expression-debug-on-error nil))
(eval-defun t)))))
(ert-deftest edebug-tests-circular-read-syntax ()
"Edebug can instrument code using circular read object syntax (Bug#23660)."