mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

Fix for 'windmove-do-window-select' if other-window is 'no-select

Browse source 
If the variable 'windmove-create-window' is set to a function
that returns 'no-select', 'windmove-do-window-select' is intended
to ignore the final window selection.  However, because
'other-window' is passed to 'window-minibuffer-p' before checking
if 'other-window' is 'no-select', 'window-minibuffer-p' will
instead throw a type error, and the '(eq other-window 'no-select)'
case will never be reached.  This patch moves this case up a line
to avoid this.
* lisp/windmove.el (windmove-do-window-select): Check for
'no-select' value earlier.  (Bug#78997)

Copyright-paperwork-exempt: yes
This commit is contained in:
git@toki.la 2025-07-11 12:34:35 -07:00 • committed by Eli Zaretskii
parent 291cd2d341
commit 256dfdf11f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lisp/windmove.el
View file

@ -422,10 +422,10 @@ repeated commands."
(cond ((null other-window)
(user-error "No window %s from selected window" dir))
((eq other-window 'no-select))
((and (window-minibuffer-p other-window)
(not (minibuffer-window-active-p other-window)))
(user-error "Minibuffer is inactive"))
((eq other-window 'no-select))
(t
(select-window other-window)))))