From 21585896dd6830779d95492f3d1539f52a6b400a Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Thu, 21 Apr 2016 15:33:08 +0100 Subject: [PATCH] Just report the performance ratio, don't fail if it's too large (to avoid continuous integration failures). Copied from Perforce Change: 191486 ServerID: perforce.ravenbrook.com --- mps/code/comm.gmk | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mps/code/comm.gmk b/mps/code/comm.gmk index 269163e8d99..b61c48a1e0e 100644 --- a/mps/code/comm.gmk +++ b/mps/code/comm.gmk @@ -325,25 +325,19 @@ $(addprefix $(PFM)/$(VARIETY)/,$(TEST_SUITES)): $(TEST_TARGETS) TESTRATIO_SEED = 1564912146 -# These targets are set quite high to reduce false positives due to -# the usual vagaries of performance measurement. -TARGET_RATIO_AMC = 120 -TARGET_RATIO_MVFF = 150 - define ratio TIME_HOT=$$(/usr/bin/time -p $(PFM)/hot/$(1) -x $(TESTRATIO_SEED) $(2) 2>&1 | tail -2 | awk '{T += $$2} END {print T}'); \ TIME_RASH=$$(/usr/bin/time -p $(PFM)/rash/$(1) -x $(TESTRATIO_SEED) $(2) 2>&1 | tail -2 | awk '{T += $$2} END {print T}'); \ RATIO=$$(awk "BEGIN{print int(100 * $$TIME_HOT / $$TIME_RASH)}"); \ -printf "Performance ratio (hot/rash) for $(2): %d%%\n" $$RATIO; \ -test $$RATIO -lt $(3) +printf "Performance ratio (hot/rash) for $(2): %d%%\n" $$RATIO endef .PHONY: testratio testratio: $(MAKE) -f $(PFM).gmk VARIETY=hot djbench gcbench $(MAKE) -f $(PFM).gmk VARIETY=rash djbench gcbench - $(call ratio,gcbench,amc,$(TARGET_RATIO_AMC)) - $(call ratio,djbench,mvff,$(TARGET_RATIO_MVFF)) + $(call ratio,gcbench,amc) + $(call ratio,djbench,mvff) # == MMQA test suite ==