1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-10 08:10:21 -08:00

* lisp/emacs-lisp/eieio-core.el: Add `subclass' specializer for cl-generic.

(eieio--generic-subclass-tagcode, eieio--generic-subclass-tag-types):
New functions.
(cl-generic-tagcode-function, cl-generic-tag-types-function): Use them.

* test/automated/eieio-test-methodinvoke.el (eieio-test-cl-generic-1):
Test `subclass' specializer.
This commit is contained in:
Stefan Monnier 2015-01-18 14:08:13 -05:00
parent 2a61bd0096
commit 1f545d3364
5 changed files with 48 additions and 5 deletions

View file

@ -1227,6 +1227,8 @@ method invocation orders of the involved classes."
(require 'cl-generic)
;;;; General support to dispatch based on the type of the argument.
(add-function :before-until cl-generic-tagcode-function
#'eieio--generic-tagcode)
(defun eieio--generic-tagcode (type name)
@ -1246,6 +1248,29 @@ method invocation orders of the involved classes."
(mapcar #'eieio--class-symbol
(eieio--class-precedence-list (symbol-value tag)))))
;;;; Dispatch for arguments which are classes.
;; Since EIEIO does not support metaclasses, users can't easily use the
;; "dispatch on argument type" for class arguments. That's why EIEIO's
;; `defmethod' added the :static qualifier. For cl-generic, such a qualifier
;; would not make much sense (e.g. to which argument should it apply?).
;; Instead, we add a new "subclass" specializer.
(add-function :before-until cl-generic-tagcode-function
#'eieio--generic-subclass-tagcode)
(defun eieio--generic-subclass-tagcode (type name)
(when (eq 'subclass (car-safe type))
`(60 . (and (symbolp ,name) (eieio--class-v ,name)))))
(add-function :before-until cl-generic-tag-types-function
#'eieio--generic-subclass-tag-types)
(defun eieio--generic-subclass-tag-types (tag)
(when (eieio--class-p tag)
(mapcar (lambda (class)
`(subclass
,(if (symbolp class) class (eieio--class-symbol class))))
(eieio--class-precedence-list tag))))
;;; Backward compatibility functions
;; To support .elc files compiled for older versions of EIEIO.