mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-15 10:30:25 -08:00
Code Issues Projects Releases Wiki Activity

Bookmark locations can refer to VC directory buffers (bug#39722)

Browse source 
* etc/NEWS: Document feature.
* lisp/vc/vc-dir.el (vc-dir-mode): Set local bookmark-make-record-function.
(bookmark-make-record-default, bookmark-prop-get, bookmark-default-handler)
(bookmark-get-bookmark-record): Declarations.
(vc-dir-bookmark-make-record): Make record used to bookmark a `vc-dir' buffer.
(vc-dir-bookmark-jump): Provides bookmark-jump behavior for a `vc-dir' buffer.
This commit is contained in:
Matthias Meulien 2020-05-21 01:37:30 +03:00 • committed by Juri Linkov
parent 5989432d15
commit 0bfee4b18b
2 changed files with 39 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
etc/NEWS
View file

@ -139,6 +139,9 @@ directories with the help of new command 'dired-vc-next-action'.
*** New commands 'vc-dir-mark-registered-files' (bound to '* r') and
'vc-dir-mark-unregistered-files'.
*** Support for bookmark.el.
Bookmark locations can refer to VC directory buffers.
** Gnus
---

36
lisp/vc/vc-dir.el
View file

@ -1106,6 +1106,7 @@ the *vc-dir* buffer.
(set (make-local-variable 'vc-dir-backend) use-vc-backend)
(set (make-local-variable 'desktop-save-buffer)
'vc-dir-desktop-buffer-misc-data)
(setq-local bookmark-make-record-function #'vc-dir-bookmark-make-record)
(setq buffer-read-only t)
(when (boundp 'tool-bar-map)
(set (make-local-variable 'tool-bar-map) vc-dir-tool-bar-map))
@ -1465,6 +1466,41 @@ These are the commands available for use in the file status buffer:
(add-to-list 'desktop-buffer-mode-handlers
'(vc-dir-mode . vc-dir-restore-desktop-buffer))
;;; Support for bookmark.el (adapted from what info.el does).
(declare-function bookmark-make-record-default
"bookmark" (&optional no-file no-context posn))
(declare-function bookmark-prop-get "bookmark" (bookmark prop))
(declare-function bookmark-default-handler "bookmark" (bmk))
(declare-function bookmark-get-bookmark-record "bookmark" (bmk))
(defun vc-dir-bookmark-make-record ()
"Make record used to bookmark a `vc-dir' buffer.
This implements the `bookmark-make-record-function' type for
`vc-dir' buffers."
(let* ((bookmark-name
(concat "(" (symbol-name vc-dir-backend) ") "
(file-name-nondirectory
(directory-file-name default-directory))))
(defaults (list bookmark-name default-directory)))
`(,bookmark-name
,@(bookmark-make-record-default 'no-file)
(filename . ,default-directory)
(handler . vc-dir-bookmark-jump)
(defaults . ,defaults))))
;;;###autoload
(defun vc-dir-bookmark-jump (bmk)
"Provides the bookmark-jump behavior for a `vc-dir' buffer.
This implements the `handler' function interface for the record
type returned by `vc-dir-bookmark-make-record'."
(let* ((file (bookmark-prop-get bmk 'filename))
(buf (save-window-excursion
(vc-dir file) (current-buffer))))
(bookmark-default-handler
`("" (buffer . ,buf) . ,(bookmark-get-bookmark-record bmk)))))
(provide 'vc-dir)