mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

Fix creation of Secret Service items in auth-source

Browse source 
* lisp/auth-source.el (auth-source-secrets-create): Use ´apply'.
(auth-source-secrets-saver): Handle `auth-source-save-behavior'
equal t.

* lisp/net/secrets.el (secrets-get-items): Do not call
`secrets-open-session' here ...
(top): ... but here.

* test/lisp/auth-source-tests.el
(auth-source-test-secrets-create-secret): Bind
`auth-source-save-behavior' to t.  Cleanup.

* test/lisp/net/secrets-tests.el (secrets-test00-availability):
After loading secets.el, a session is already opened.
(secrets-test02-collections, secrets-test03-items)
(secrets-test04-search): Open a new session.
This commit is contained in:
Michael Albinus 2018-05-16 11:22:51 +02:00
parent 4c3cd27df9
commit 01120ec3d2
4 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lisp/auth-source.el
View file

@ -1733,7 +1733,7 @@ authentication tokens:
(secret (plist-get artificial :secret))
(secret (if (functionp secret) (funcall secret) secret)))
(lambda ()
(apply 'auth-source-secrets-saver collection item secret args))))
(auth-source-secrets-saver collection item secret args))))
(list artificial)))
@ -1742,8 +1742,9 @@ authentication tokens:
Respects `auth-source-save-behavior'."
(let ((prompt (format "Save auth info to secrets collection %s? " collection))
(done (not (eq auth-source-save-behavior 'ask)))
(doit (eq auth-source-save-behavior t))
(bufname "*auth-source Help*")
doit k)
k)
(while (not done)
(setq k (auth-source-read-char-choice prompt '(?y ?n ?N ??)))
(cl-case k