mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

Fix treesit-parse-string crash (bug#71012)

Browse source 
Parsing a large file with treesit-parse-string and then printing the
returned node crashes Emacs, because with-temp-buffer kills the temp
buffer when treesit-parse-string returns, and print.c tries to access
the node's position in the killed buffer.

* lisp/treesit.el (treesit-parse-string): Don't use with-temp-buffer.
This commit is contained in:
Yuan Fu 2024-06-01 10:33:18 -07:00
parent 20af58d3a1
commit 00360258ca
No known key found for this signature in database
GPG key ID: 56E19BC57664A442
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lisp/treesit.el
View file

@ -122,10 +122,13 @@ of max unsigned 32-bit value for byte offsets into buffer text."
(defun treesit-parse-string (string language)
"Parse STRING using a parser for LANGUAGE.
Return the root node of the syntax tree."
(with-temp-buffer
(insert string)
(treesit-parser-root-node
(treesit-parser-create language))))
;; We can't use `with-temp-buffer' because it kills the buffer when
;; returning from the form.
(let ((buf (generate-new-buffer " *treesit-parse-string*")))
(with-current-buffer buf
(insert string)
(treesit-parser-root-node
(treesit-parser-create language)))))
(defvar-local treesit-language-at-point-function nil
"A function that returns the language at point.