mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-03-10 15:10:25 -07:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'fix-log-small-ratio' into 'develop'

Browse source 
log: add a separate path for ratios

See merge request embeddable-common-lisp/ecl!276
This commit is contained in:
Marius Gerbershagen 2022-11-18 15:59:57 +00:00
commit fea8a9dde4
3 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/c/numbers/log.d
View file

@ -17,6 +17,7 @@
#include <ecl/ecl.h>
#include <ecl/internal.h>
#include <complex.h>
#include <float.h>
#include <ecl/impl/math_dispatch.h>
#pragma STDC FENV_ACCESS ON
@ -88,6 +89,22 @@ ecl_log1_simple(cl_object x)
return ecl_make_single_float(logf(ecl_to_float(x)));
}
static cl_object
ecl_log1_ratio(cl_object x)
{
cl_object num = x->ratio.num;
cl_object den = x->ratio.den;
cl_index lnum = ecl_integer_length(num);
cl_index lden = ecl_integer_length(den);
if ((lnum > lden) ? (lnum - lden >= FLT_MAX_EXP) : (lden - lnum >= -FLT_MIN_EXP)) {
cl_object numlog = ecl_log1(num);
cl_object denlog = ecl_log1(den);
return ecl_minus(numlog, denlog);
} else {
return ecl_log1_simple(x);
}
}
static cl_object
ecl_log1_single_float(cl_object x)
{
@ -182,7 +199,7 @@ ecl_log1_clfloat(cl_object x)
#endif
MATH_DEF_DISPATCH1(log1, @[log], @[number],
ecl_log1_simple, ecl_log1_bignum, ecl_log1_simple,
ecl_log1_simple, ecl_log1_bignum, ecl_log1_ratio,
ecl_log1_single_float, ecl_log1_double_float, ecl_log1_long_float,
ecl_log1_complex,
ecl_log1_csfloat, ecl_log1_cdfloat, ecl_log1_clfloat);

1
src/h/impl/math_dispatch.h
View file

@ -54,6 +54,7 @@ typedef cl_object (*math_one_arg_fn)(cl_object);
} \
return name##dispatch[t](arg); \
}
#define MATH_DEF_DISPATCH1(name,id,type,fix,big,ratio, \
single_float,double_float,long_float, \
complex,csfloat,cdfloat,clfloat) \

5
src/tests/normal-tests/mixed.lsp
View file

@ -429,3 +429,8 @@
(let ((vector (si:make-vector t 10 t nil nil nil)))
(si:adjust-vector vector 20)
(is (= 20 (array-total-size vector)))))
;;; Created: 2022-11-10
;;; Contains: a test for a logarithm of a very small ratio
(test mix.0023.log-small-ratio
(finishes (log (/ 1 6319748715279270675921934218987893281199411530039296))))