mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-03-15 09:20:23 -07:00
Code Issues Projects Releases Packages Wiki Activity

A LET/LET* with special variables is no longer considered to have side effects by default

Browse source
This commit is contained in:
Juan Jose Garcia Ripoll 2010-05-13 11:31:01 +02:00
parent ffecddc3b9
commit eed2ba9c05
1 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/cmp/cmplet.lsp
View file

@ -48,8 +48,6 @@
(mapc #'check-vref vars)
(let ((sp-change (some #'global-var-p vars)))
(make-c1form* let/let*
:sp-change sp-change
:side-effects sp-change
:type (c1form-type body)
:volatile (not (eql setjmps *setjmps*))
:local-vars vars
@ -112,7 +110,7 @@
do (fix-read-only-variable-type var form rest-forms)
unless (and read-only-p
(or (c1let-unused-variable-p var form)
(c1let-optimize-out-variable var form rest-vars rest-forms)))
(c1let-can-move-variable-value-p var form rest-vars rest-forms)))
collect var into used-vars and
collect form into used-forms
finally (return (values used-vars used-forms))))
@ -136,7 +134,17 @@
(delete-c1forms form)
t))
(defun c1let-optimize-out-variable (var form rest-vars rest-forms)
(defun c1let-constant-value (var form rest-vars rest-forms)
;; (let ((v1 e1) (v2 e2) (v3 e3)) (expr e4 v2 e5))
;; - v2 is a read only variable
;; - the value of e2 is not modified in e3 nor in following expressions
(when (and (notany #'(lambda (v) (var-referenced-in-form v form)) rest-vars)
(c1form-constant-p form rest-forms))
(cmpdebug "Replacing variable ~A by its value ~A" (var-name var) form)
(nsubst-var var form)
t))
(defun c1let-can-move-variable-value-p (var form rest-vars rest-forms)
;; (let ((v1 e1) (v2 e2) (v3 e3)) (expr e4 v2 e5))
;; can become
;; (let ((v1 e1) (v3 e3)) (expr e4 e2 e5))
@ -153,8 +161,7 @@
(replaceable var rest-forms))
(cmpdebug "Replacing variable ~A by its value ~A" (var-name var) form)
(nsubst-var var form)
(return-from c1let-optimize-out-variable t))
nil)
t))
(defun update-var-type (var type x)
(cond ((consp x)