mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-01-24 21:41:29 -08:00
Code Issues Projects Releases Packages Wiki Activity

clos: invalidate initarg caches when new methods are defined

Browse source 
Closes #425. Fix contributed by Bike from #clasp.
This commit is contained in:
Daniel Kochmanski 2018-04-06 16:36:36 +02:00
parent 3fd005d8df
commit d641c39bd9
2 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/clos/fixup.lsp
View file

@ -328,11 +328,21 @@ their lambda lists ~A and ~A are not congruent."
(mapc #'recursively-update-classes
(class-direct-subclasses a-class)))
(defmethod update-dependent ((object generic-function)
(dep initargs-updater)
&rest initargs)
(declare (ignore dep initargs object))
(recursively-update-classes +the-class+))
(defmethod update-dependent ((object generic-function) (dep initargs-updater)
&rest initargs
&key
((add-method added-method) nil am-p)
((remove-method removed-method) nil rm-p)
&allow-other-keys)
(declare (ignore object dep initargs))
(let ((method (cond (am-p added-method)
(rm-p removed-method))))
;; update-dependent is also called when the gf itself is reinitialized,
;; so make sure we actually have a method that's added or removed
(when method
(let ((spec (first (method-specializers method)))) ; the class being initialized or allocated
(when (classp spec) ; sanity check against eql specialization
(recursively-update-classes spec))))))
(let ((x (make-instance 'initargs-updater)))
(add-dependent #'shared-initialize x)