Code review on merge request !65

This commit is contained in:
Fabrizio Fabbri 2017-05-19 19:18:16 +02:00
parent 88efaa1b6d
commit 95279fb15f
No known key found for this signature in database
GPG key ID: 8276EDF3D10E6C35
5 changed files with 9 additions and 11 deletions

View file

@ -764,12 +764,11 @@ put_declaration(void)
put_lineno();
fprintf(out, "\t}\n");
}
if (simple_varargs)
fprintf(out,"\tva_end(%s);\n",
rest_var);
else
fprintf(out,"\n\tecl_va_end(%s);\n",
rest_var);
if (simple_varargs) {
fprintf(out,"\tva_end(%s);\n", rest_var);
} else {
fprintf(out,"\tecl_va_end(%s);\n", rest_var);
}
if (key_flag) {
put_lineno();
fprintf(out, "\tcl_parse_key(ARGS, %d, KEYS, KEY_VARS, NULL, %d);\n",

View file

@ -5328,8 +5328,7 @@ flisten(cl_object stream, FILE *fp)
{
/* regular file */
ecl_off_t old_pos = ecl_ftello(fp), end_pos;
unlikely_if (old_pos == -1
||
unlikely_if (old_pos == -1 ||
ecl_fseeko(fp, 0, SEEK_END) != 0)
file_libc_error(@[file-error], stream,
"Unable to check file position", 0);

View file

@ -77,7 +77,7 @@ ecl_ceiling2(cl_object x, cl_object y)
const cl_env_ptr the_env = ecl_process_env();
cl_object v0, v1;
cl_type ty;
v0 = v1 = Cnil;
v0 = v1 = ECL_NIL;
ty = ecl_t_of(y);
if (ecl_unlikely(!ECL_REAL_TYPE_P(ty))) {
FEwrong_type_nth_arg(@[ceiling],2, y, @[real]);

View file

@ -533,7 +533,7 @@ si_spawn_subprocess(cl_object command, cl_object argv, cl_object environ,
if (Null(pid)) {
if (parent_write) close(parent_write);
if (parent_read) close(parent_read);
if (parent_error >= 0) close(parent_error);
if (parent_error > 0) close(parent_error);
parent_write = 0;
parent_read = 0;
parent_error = 0;

View file

@ -262,7 +262,7 @@ void ~A(cl_object cblock)
* circular chain. This disables the garbage collection of
* the library until _ALL_ functions in all modules are unlinked.
*/
cl_object current = Cnil, next = Cblock;
cl_object current = OBJNULL, next = Cblock;
~:{
current = ecl_make_codeblock();
current->cblock.next = next;