mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-02-05 15:10:40 -08:00
Code Issues Projects Releases Packages Wiki Activity

repl: always call clear-input when SERIOUS-CONDITION is encountered

Browse source 
Consider the following input from string: #j :r1

First the reader signals a condition that there is no dispatch character macro
for #j, and then we select the first restart. That's clearly undesireable.
This commit is contained in:
Daniel Kochmański 2024-05-29 08:23:50 +02:00
parent 4a49130ad5
commit 7e25107779
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/lsp/top.lsp
View file

@ -572,15 +572,16 @@ Use special code 0 to cancel this operation.")
(set-break-env)
(set-current-ihs)
(flet ((rep ()
;; We let warnings pass by this way "warn" does the
;; work. It is conventional not to trap anything
;; that is not a SERIOUS-CONDITION. Otherwise we
;; would be interferring the behavior of code that relies
;; on conditions for communication (for instance our compiler)
;; and which expect nothing to happen by default.
;; We let warnings pass by this way "warn" does the work. It is
;; conventional not to trap anything that is not a
;; SERIOUS-CONDITION. Otherwise we would be interferring the
;; behavior of code that relies on conditions for communication
;; (for instance our compiler) and which expect nothing to happen
;; by default.
(handler-bind
((serious-condition
(lambda (condition)
(clear-input *query-io*)
(cond
;; Toplevel should enter the debugger on any condition.
((< break-level 1))
@ -591,7 +592,6 @@ Use special code 0 to cancel this operation.")
(tpl-format "~&Debugger received error of type: ~A~%~A~%"
(type-of condition) condition)
(tpl-format "Error flushed.~%")
(clear-input *query-io*)
(return-from rep t))))))
(with-grabbed-console
(unless quiet