mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-01-24 05:21:20 -08:00
Code Issues Projects Releases Packages Wiki Activity

terminate-process: add information about potential race

Browse source
This commit is contained in:
Daniel Kochmański 2017-02-20 16:20:29 +01:00
parent 6733369ea0
commit 663b1bdcf2
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/lsp/process.lsp
View file

@ -76,6 +76,13 @@
(values (external-process-%status process)
(external-process-%code process)))
;;; This function isn't overly safe. Assuming `external-process-wait'
;;; is called after getting PID bu before function sends signal,
;;; zombie may be already removed and we are shooting the
;;; air. Reasonable expectation here would be putting the burden on
;;; the user, that he can't call both functions in racy manner. We are
;;; protected from sigchld-handler here thanks to the global lock
;;; active processes.
(defun terminate-process (process &optional force)
(with-active-processes-lock
(let ((pid (external-process-pid process)))