mirrors/ecl
1
Fork 0
mirror of https://gitlab.com/embeddable-common-lisp/ecl.git synced 2026-01-17 06:42:18 -08:00
Code Issues Projects Releases Packages Wiki Activity

In some circumstances, gethash acting on a weak hash would return corrupt values

Browse source
This commit is contained in:
Juan Jose Garcia Ripoll 2012-09-21 23:02:44 +02:00
parent ce653d889d
commit 554fc892d4
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/c/hash.d
View file

@ -527,7 +527,6 @@ copy_entry(struct ecl_hashtable_entry *e, cl_object h)
h->hash.entries--;
output.key = OBJNULL;
output.value = ECL_NIL;
h->hash.entries--;
return *e = output;
}
}
@ -540,17 +539,15 @@ _ecl_weak_hash_loop(cl_hashkey h, cl_object key, cl_object hashtable,
cl_index i = h % hsize, j = hsize, k;
for (k = 0; k < hsize; i = (i + 1) % hsize, k++) {
struct ecl_hashtable_entry *p = hashtable->hash.data + i;
struct ecl_hashtable_entry e = copy_entry(p, hashtable);
struct ecl_hashtable_entry e = *aux = copy_entry(p, hashtable);
if (e.key == OBJNULL) {
if (e.value == OBJNULL) {
if (j == hsize) {
*aux = e;
return p;
} else {
return hashtable->hash.data + j;
}
} else {
*aux = e;
if (j == hsize) {
j = i;
} else if (j == i) {