doomemacs/modules/tools
Henrik Lissner 51d3b1b424
💥 revise advice naming convention (1/2)
This is first of three big naming convention updates that have been a
long time coming. With 2.1 on the horizon, all the breaking updates will
batched together in preparation for the long haul.

In this commit, we do away with the asterix to communicate that a
function is an advice function, and we replace it with the '-a' suffix.
e.g.

  doom*shut-up -> doom-shut-up-a
  doom*recenter -> doom-recenter-a
  +evil*static-reindent -> +evil--static-reindent-a

The rationale behind this change is:

1. Elisp's own formatting/indenting tools would occasionally struggle
   with | and * (particularly pp and cl-prettyprint). They have no
   problem with / and :, fortunately.
2. External syntax highlighters (like pygmentize, discord markdown or
   github markdown) struggle with it, sometimes refusing to highlight
   code beyond these symbols.
3. * and | are less expressive than - and -- in communicating the
   intended visibility, versatility and stability of a function.
4. It complicated the regexps we must use to search for them.
5. They were arbitrary and over-complicated to begin with, decided
   on haphazardly way back when Doom was simply "my private config".

Anyhow, like how predicate functions have the -p suffix, we'll adopt the
-a suffix for advice functions, -h for hook functions and -fn for
variable functions.

Other noteable changes:
- Replaces advice-{add,remove}! macro with new def-advice!
  macro. The old pair weren't as useful. The new def-advice! saves on a
  lot of space.
- Removed "stage" assertions to make sure you were using the right
  macros in the right place. Turned out to not be necessary, we'll
  employ better checks later.
2019-07-22 02:27:45 +02:00
..
ansible ansible: fix upstream changing coding conventions 2019-07-16 17:28:25 -07:00
debugger Fix +debugger/start for dap-mode 2019-07-09 21:33:02 +02:00
direnv 💥 revise advice naming convention (1/2) 2019-07-22 02:27:45 +02:00
docker Make plugins a simple list 2019-05-05 19:17:02 -03:00
editorconfig 💥 revise advice naming convention (1/2) 2019-07-22 02:27:45 +02:00
ein Merge pull request #1201 from kot-behemoth/patch-1 2019-05-30 13:23:17 -04:00
eval Minor refactors across the board 2019-06-26 14:31:06 +02:00
flycheck Remove +flycheck-on-escape; add +flycheck-lazy-idle-delay 2019-06-14 18:38:19 +02:00
flyspell Minor refactors across the board 2019-06-26 14:31:06 +02:00
gist 💥 Remove :feature category 2019-04-24 18:16:04 -04:00
lookup 💥 revise advice naming convention (1/2) 2019-07-22 02:27:45 +02:00
lsp tools/lsp: fix company-lsp not being enabled 2019-07-05 23:42:06 +02:00
macos fix +macos/open-in-default-project under ranger-mode 2018-10-04 11:13:51 -07:00
magit 💥 revise advice naming convention (1/2) 2019-07-22 02:27:45 +02:00
make Refactor Project API to reflect changes upstream 2018-09-28 21:13:27 -04:00
pass tools/pass: use latest version of auth-source-pass 2019-06-11 08:07:25 +02:00
pdf Replace kill-this-buffer with kill-current-buffer 2019-05-30 18:54:58 -07:00
prodigy Minor refactors across the board 2019-06-26 14:31:06 +02:00
rgb Fix autoloaded hydras 2019-04-07 16:06:52 -04:00
terraform Normalize :leader/:localleader keybinds 2018-12-23 23:54:27 -05:00
tmux/autoload 💥 Remove :feature category 2019-04-24 18:16:04 -04:00
upload tools/upload: set ssh-deploy vars sooner 2018-12-05 22:11:54 -05:00
wakatime Rewrite switch-{buffer,window} hooks 2019-03-08 02:37:33 -05:00