Make the resulting auto-save files easier to recognize when perused by
hand (in case of a fatal data loss and recovery situation), by prefixing
the hashed autosave file with the target file name.
Also updates the explanatory comment above it to better explain the
purpose of these defaults.
Also uses file-name-concat in case auto-save-list-file-prefix doesn't
end in a slash.
This doesn't actually change anything yet, unless you're using Doom's
profiles, but this data should be associated with and stored in the
current profile, rather than in the global store.
This functionality was upstreamed to Emacs in 28, given the appropriate
`auto-save-file-name-transforms` rule whose UNIQUIFY argument names a
`secure-hash` algorithm (e.g. sha1), so we no longer need our cludge.
This also fixes an issue where TRAMP was saving its auto-save files to
the current working directory, rather than `tramp-auto-save-directory`.
Fix: doomemacs/community#53
There are some cases where the upgrade process will abort (due to
failure or user input), and it then runs `doom sync` anyway. Don't do
that.
Fix: #8595
In 71eae25, TRAMP settings were moved to a new :emacs tramp module,
reverting `tramp-backup-directory-alist` and `tramp-auto-save-directory`
to their Emacs defaults for anyone not using this module (which saves
those temp files in the current working directory, which is an
undesirable default), so we set them in core again.
Fix: doomemacs/community#53
Amend: 71eae252ac
From this point on, Straight will *not* download packages from tarballs
by default. There are too many edge cases for this that catch up
beginners who have BSD tar installed and get undecipherable tar errors,
and Straight offers no fallback or easy way to change what tar
executable it uses.
Packages that have already been installed won't be affected until the
next time they are updated/reinstalled.
Users can still opt back into tarballs by adding this to
$DOOMDIR/packages.el:
(setq straight-vc-use-snapshot-installation t)
Amend: 8cdddd87d9Fix: #8530
BREAKING CHANGE: Moves ws-butler, dtrt-indent, and whitespace defaults
out of Doom's core and into a new module. ws-butler is gated behind
+trim and dtrt-indent behind +guess. Users who depend on/like these
packages will need to enable the new module and their respective
flags (which is the default going forward).
This change is motivated by an ongoing effort to slim down Doom's
core (by (re)moving non-essentials from it).
This also addresses an issue where dtrt-indent would vastly increase
load times for some major-modes (e.g. elixir-mode & elm-mode, see #7537)
by restricting it to non-project files and non-read-only buffers AND
excludign those two major modes from indent guessing.
Fix: #8516Fix: #7537
Allows the association of arbitrary envvars or variables with the build
artifacts of a package. If they change, the package is rebuilt on the
next 'doom sync'. This is a temporary measure, which is why this is not
touted as a new feature. It will be replaced in v3.
Yes, yes. I did a stupid here. I depend on the order of a hash table,
and sure enough, that came back to bite me when that changed internally
in Emacs 29. In practice, this meant packages were getting
installed/rebuilt in reverse order, which, besides some odd output
during 'doom sync' for users on 29+, didn't pose any overt issues, but
may have caused strange, inexplicable byte-code warnings/errors.
But, rather than do the smart thing and *not* do this, I do the next
best thing: procrastinate! Because the solution is non-trivial (I don't
control the hash table in question) and this is precisely the sort of
technical debt I've fixed in v3, and I'd really, *really* rather beat my
head on that wall, rather than this one.
Prior to this, we had some rudimentary retry logic for failed git clones
resulting in an empty repo, but it didn't respond to other legit
errors (like connection errors or legit remote failures). This one does,
retrying in more contexts.
Close: #8523
Co-authored-by: NightMachinery <NightMachinery@users.noreply.github.com>
The Emacs appimage generates a new mountpoint on each invokation, but
Doom's profiles assume that the Emacs directories don't move. To make
Doom's profiles a little more profile, it will no longer set `load-path`
and simply add the new paths to the existing one. Same for
Info-directory-list.
Consequently, this also seems to speed up startup times for ~8% in my
tests. Neat.
When a file is visited via `emacsclient`, server.el does the following
in this order:
- create a buffer `b` visiting the file
- run `(set-buffer b)`
- trigger `server-visit-hook`
- run `(switch-buffer b)`
- trigger `server-switch-hook`
Thus, the right hook for `doom-run-switch-buffer-hooks-h` is
`server-switch-hook` because the "switch buffer" hooks may assume that
the buffer has already been switched to.
This fixes an org error that occurs when running
emacsclient --create-file --no-wait foo.txt
while there's a frame containing an org-roam file. Without this commit,
the server will create a new frame and set the current buffer to
foo.txt. But the new frame will still display the (duplicated) window
for the org-roam file. Then `server-visit-hook` will be triggered and
eventually run `+org-roam-manage-backlinks-buffer-h`, which will try to
enable the org-roam backlinks buffer. But this will error because the
current buffer is not an org(-roam) buffer.
Amend: 4a6de2419c
Prevent rare edge cases where FORM is an atom, causing `cadr` to throw a
type error. Might explain some cases of `doom sync` doing nothing after
'> Generating N init files...'.
Amend: c014950f6d
While generating the autoloads for the current profile (at `doom sync`),
remove any `add-to-list` forms modifying `interpreter-mode-alist` or
`auto-mode-alist` in autoloaded `(when (treesit-available-p) ...)`
blocks. We want to fully rely on `major-mode-remap-defaults`.
