Commit graph

448 commits

Author SHA1 Message Date
Romain FERRU
8fd5a6775e added > 2 vertices test 2024-11-08 20:29:20 +01:00
Romain FERRU
2a00c1e454 ran black at 88 char per line 2024-11-08 20:18:12 +01:00
Romain FERRU
e28ffb04c2 refactored loft at direct api level 2024-11-07 20:38:31 +01:00
gumyr
f3fa230c52 Enhancing Triangle Issue#765 2024-11-06 20:53:50 -05:00
gumyr
0b4b2b2b54 Improved algebra +,-,& operators Issue #752 2024-11-06 13:50:20 -05:00
gumyr
9fb163cb64 Adding Compound.first_level_shapes to extract objects 2024-11-05 11:53:51 -05:00
gumyr
c7a8529c24 Added Face.is_planar property Issue #756 2024-11-04 14:37:22 -05:00
gumyr
5ed149925e Updating split_by_perimeter & minor docs fixes 2024-10-28 12:01:13 -04:00
gumyr
8a91db674a Adding split_by_perimeter Issue #751 2024-10-27 11:15:36 -04:00
gumyr
19b15f3d13 Merge branch 'dev' of https://github.com/gumyr/build123d into dev 2024-10-20 12:01:26 -04:00
gumyr
7be2eb1d97 Added Face as an option to split PR#427 2024-10-20 12:01:16 -04:00
jdegenstein
93ad244271
Merge pull request #732 from erooke/test-version
test: check that exporter.library is >= 2.3.1 not == 2.3.1
2024-10-15 12:49:51 -05:00
jdegenstein
e2434d7777
Merge pull request #704 from jdegenstein/numpy2
Upgrade build123d to numpy >=2, <3
2024-10-10 15:53:15 -05:00
Ethan Rooke
b31c9e9634
test: check that exporter.library is >= 2.3.1 not == 2.3.1 2024-10-08 22:42:37 -05:00
gumyr
b81fecd8dc Added tuple as valid input to Color Issue #727 2024-10-07 10:13:32 -04:00
gumyr
cf1f869d7d Added tuple as valid input to Color Issue #727 2024-10-07 10:12:56 -04:00
gumyr
f1a9c58900 Fixed split with nested Compounds Issue #698 2024-10-04 11:40:25 -04:00
gumyr
04cf1efd89 Fixed param_at_point Issues #570 & #708 2024-10-02 15:44:10 -04:00
Roger Maitland
720bee9fa0
Merge pull request #707 from alexer/fix-eq
Fix __eq__ and __ne__ for classes implementing them
2024-09-22 10:10:13 -04:00
Aleksi Torhamo
acbebfb017 Fix __eq__ and __ne__ for classes implementing them
Main issue, which concerns Vector, Location, and ShapeList:

Comparison with an object of a different type should not cause an
exception - they are simply not equal. Raising an exception in __eq__
can (and will*) break unrelated code that expects __eq__ to be well-behaved.

(* I noticed this bug when cq-editor choked on it while trying to find
   a name for an object in a dictionary of local variables)

There's a second more minor issue, which concerns the rest of the classes:

When the other type in __eq__ is not supported, one should technically
return NotImplemented instead of False, to allow the other type to take
part in the comparison, in case they know about our type.

(__ne__ should also not generally be implemented as just the negation of
__eq__ because of this, but that's also a moot point because the __ne__
can just be removed - Python will automatically do the right thing based
on __eq__ here)

Technically, the __eq__ for Vector and Plane is also broken in another way:
It's not transitive.

>>> a, b, c = Vector(0), Vector(9e-6), Vector(18e-6)
>>> a == b == c
True
>>> a == c
False

They should really eg. have a separate is_close() for approximate comparison,
but this isn't fixed here, since I have no idea how many places it'd break,
for one.
2024-09-22 08:07:00 +03:00
gumyr
043629ec87 Enhanced offset to allow holes to grow outside of the Face Issue #702 2024-09-20 11:29:19 -04:00
Roger Maitland
debdf845bf
Merge pull request #695 from danieledapo/dev
Fix thicken normal calculation when no override is provided
2024-09-19 14:33:21 -04:00
jdegenstein
025d0727a3
test_exporters3d.py -> fix deprecation warning on regex 2024-09-19 13:23:59 -05:00
gumyr
99b378f27a Added Compound.unwrap & Compound.len as part of fix of Issue#694 2024-09-19 14:13:50 -04:00
Daniele D'Orazio
82f3dd8011 fix normal_override overwrite in thicken 2024-09-19 09:23:01 +02:00
gumyr
88a40574a8 Added Shell.sweep Issue #622 2024-09-07 11:31:10 -04:00
Daniele D'Orazio
dfb1cee937 more position_at tests 2024-08-30 17:43:29 +02:00
Daniele D'Orazio
8527fe8664 fix location_at, position_at and tangent_at with PositionMode.LENGTH for Wire 2024-08-30 17:16:35 +02:00
jdegenstein
7f8223b50d
test_direct_api.py -> reenable test that fail(ed) on MacOS arm64 2024-08-29 13:29:06 -05:00
gumyr
347de4277d Disabling test that fails only on Arm Macs 2024-08-29 11:57:33 -04:00
gumyr
722165dc25 Fixed Wire.trim Issue #676 2024-08-29 11:47:21 -04:00
gumyr
3d0cdcf4e1 Adding support for Windows 2024-08-21 15:41:03 -04:00
gumyr
fd4b16b529 Fixed step import of assembly Issue #671 2024-08-21 15:16:24 -04:00
Michael Bugert
c7b6bb7364 import_step: do not assign labels to Compound.for_construction 2024-07-24 22:33:37 +02:00
gumyr
410007d304 Fixed Face.is_coplanar for flipped Faces - Issue #661 2024-07-20 10:36:55 -04:00
gumyr
55c22311e6 Improved Vector.__str__/__repr__ 2024-07-14 11:57:08 -04:00
gumyr
e29c9fb255 Added Face.location_at & _ocp_section 2024-07-02 07:49:51 -04:00
gumyr
ce20991745 Replaced Axis.as_infinite_edge with Edge __init__ method Issue #648 2024-06-24 13:47:52 -04:00
jdegenstein
b40bcf9a24
Merge pull request #647 from jdegenstein/plane.isometric
Propose adding `Plane.isometric` to built-in planes
2024-06-24 10:39:00 -05:00
jdegenstein
74f5f68bdc
test_build_line.py -> add test for vertex/start position 2024-06-24 10:19:42 -05:00
jdegenstein
d0f4fbfa62
test_direct_api.py -> add test for Plane.isometric 2024-06-24 09:10:06 -05:00
jdegenstein
bab54c7984
test_direct_api.py -> rename vec_dir to is_direction 2024-06-23 13:39:16 -05:00
jdegenstein
f2d4ddaeea
Merge branch 'dev' into jernArcFix1 2024-06-23 13:11:12 -05:00
gumyr
ce72ee2435 Added geometry intersections Issue #327 #328 2024-06-23 13:48:30 -04:00
jdegenstein
99863e8307
Update test_build_line.py -> Fix tests 2024-06-21 15:21:25 -05:00
jdegenstein
23f6fb9618
test_build_line.py -> less trivial JernArc tests 2024-06-21 15:18:45 -05:00
jdegenstein
644edc99a3
test_direct_api.py -> add vector transform tests 2024-06-21 14:11:47 -05:00
jdegenstein
29ad5386aa
Merge pull request #643 from jdegenstein/hexloc_majradius
Add major_radius bool to HexLocations and rename apothem parameter to radius
2024-06-19 20:48:03 -05:00
gumyr
35a33f8d3e Added Plane.find_intersection(Plane) Issue #327 2024-06-19 18:43:14 -04:00
jdegenstein
43a1d93115
test_build_common.py -> fix deprecated assertAlmostEquals with assertAlmostEqual 2024-06-19 15:43:03 -05:00