mirrors/build123d
1
Fork 0
mirror of https://github.com/gumyr/build123d.git synced 2025-12-06 02:30:55 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improving Face creation - fix inner Wires
Some checks failed
benchmarks / benchmarks (macos-14, 3.12) (push) Has been cancelled
Details
benchmarks / benchmarks (macos-15-intel, 3.12) (push) Has been cancelled
Details
benchmarks / benchmarks (ubuntu-latest, 3.12) (push) Has been cancelled
Details
benchmarks / benchmarks (windows-latest, 3.12) (push) Has been cancelled
Details
Upload coverage reports to Codecov / run (push) Has been cancelled
Details
pylint / lint (3.10) (push) Has been cancelled
Details
Run type checker / typecheck (3.10) (push) Has been cancelled
Details
Run type checker / typecheck (3.13) (push) Has been cancelled
Details
Wheel building and publishing / Build wheel on ubuntu-latest (push) Has been cancelled
Details
tests / tests (macos-14, 3.10) (push) Has been cancelled
Details
tests / tests (macos-14, 3.13) (push) Has been cancelled
Details
tests / tests (macos-15-intel, 3.10) (push) Has been cancelled
Details
tests / tests (macos-15-intel, 3.13) (push) Has been cancelled
Details
tests / tests (ubuntu-latest, 3.10) (push) Has been cancelled
Details
tests / tests (ubuntu-latest, 3.13) (push) Has been cancelled
Details
tests / tests (windows-latest, 3.10) (push) Has been cancelled
Details
tests / tests (windows-latest, 3.13) (push) Has been cancelled
Details
Wheel building and publishing / upload_pypi (push) Has been cancelled
Details

Browse source
This commit is contained in:
gumyr 2025-10-24 18:34:11 -04:00
parent 70310ddd4a
commit 696e99c889
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/build123d/topology/utils.py
View file

@ -263,7 +263,10 @@ def _make_topods_face_from_wires(
for inner_wire in inner_wires: for inner_wire in inner_wires:
if not BRep_Tool.IsClosed_s(inner_wire): if not BRep_Tool.IsClosed_s(inner_wire):
raise ValueError("Cannot build face(s): inner wire is not closed") raise ValueError("Cannot build face(s): inner wire is not closed")
face_builder.Add(inner_wire) sf_s = ShapeFix_Shape(inner_wire)
sf_s.Perform()
fixed_inner_wire = TopoDS.Wire_s(sf_s.Shape())
face_builder.Add(fixed_inner_wire)
face_builder.Build() face_builder.Build()