From dd8416a141a2285c3f0bdccdef0fa33be9acd015 Mon Sep 17 00:00:00 2001
From: jdegenstein <jdegenstein@users.noreply.github.com>
Date: Tue, 14 Jan 2025 11:32:28 -0600
Subject: [PATCH 1/2] move mesher benchmark to `test_benchmarks.py`

---
 tests/test_benchmarks.py | 18 ++++++++++++++++++
 tests/test_mesher.py     | 13 -------------
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/tests/test_benchmarks.py b/tests/test_benchmarks.py
index 7f9484f..34bac6b 100644
--- a/tests/test_benchmarks.py
+++ b/tests/test_benchmarks.py
@@ -1,11 +1,13 @@
 import pytest
 import importlib
 from math import sqrt
+import time
 from build123d import *
 
 
 pytest_benchmark = pytest.importorskip("pytest_benchmark")
 
+
 def test_ppp_0101(benchmark):
     def model():
         """
@@ -616,9 +618,11 @@ def test_ttt_23_02_02(benchmark):
 
     benchmark(model)
 
+
 # def test_ttt_23_T_24(benchmark):
 # excluding because it requires sympy
 
+
 def test_ttt_24_SPO_06(benchmark):
     def model():
         densa = 7800 / 1e6  # carbon steel density g/mm^3
@@ -675,3 +679,17 @@ def test_ttt_24_SPO_06(benchmark):
         assert p.part.scale(IN).volume * densa / LB == pytest.approx(3.92, 0.03)
 
     benchmark(model)
+
+
+@pytest.mark.parametrize("test_input", [100, 1000, 10000, 100000])
+def test_mesher_benchmark(benchmark, test_input):
+    # in the 100_000 case test should take on the order of 0.2 seconds
+    # but usually less than 1 second
+    def test_create_3mf_mesh(i):
+        vertices = [(float(i), 0.0, 0.0) for i in range(i)]
+        triangles = [[i, i + 1, i + 2] for i in range(0, i - 3, 3)]
+        mesher = Mesher()._create_3mf_mesh(vertices, triangles)
+        assert len(mesher[0]) == i
+        assert len(mesher[1]) == int(i / 3)
+
+    benchmark(test_create_3mf_mesh, test_input)
diff --git a/tests/test_mesher.py b/tests/test_mesher.py
index 16d2d23..9547d08 100644
--- a/tests/test_mesher.py
+++ b/tests/test_mesher.py
@@ -17,19 +17,6 @@ from build123d.topology import Compound, Solid
 from build123d.geometry import Axis, Color, Location, Vector, VectorLike
 from build123d.mesher import Mesher
 
-class InternalApiBenchmark(unittest.TestCase):
-    def test_create_3mf_mesh(self):
-        start = time.perf_counter()
-        for i in [100, 1000, 10000, 100000]:
-            vertices = [(float(i), 0.0, 0.0) for i in range(i)]
-            triangles = [[i, i+1, i+2] for i in range(0, i-3, 3)] 
-            start = time.perf_counter()
-            Mesher()._create_3mf_mesh(vertices, triangles)
-            runtime = time.perf_counter() - start
-            print(f"| {i} | {runtime:.3f} |")
-        final_runtime = time.perf_counter() - start
-        max_runtime = 1.0
-        self.assertLessEqual(final_runtime, max_runtime, f"All meshes took {final_runtime:.3f}s > {max_runtime}s")
 
 class DirectApiTestCase(unittest.TestCase):
     def assertTupleAlmostEquals(

From 09e99b19d35bfa9c6676b0b816a0db4c21908010 Mon Sep 17 00:00:00 2001
From: jdegenstein <jdegenstein@users.noreply.github.com>
Date: Tue, 14 Jan 2025 11:38:01 -0600
Subject: [PATCH 2/2] remove unused imports time, importlib

---
 tests/test_benchmarks.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/test_benchmarks.py b/tests/test_benchmarks.py
index 34bac6b..7755ab2 100644
--- a/tests/test_benchmarks.py
+++ b/tests/test_benchmarks.py
@@ -1,7 +1,5 @@
 import pytest
-import importlib
 from math import sqrt
-import time
 from build123d import *