mirrors/build123d
1
Fork 0
mirror of https://github.com/gumyr/build123d.git synced 2025-12-06 02:30:55 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enhanced offset to allow holes to grow outside of the Face Issue #702

Browse source
This commit is contained in:
gumyr 2024-09-20 11:29:19 -04:00
parent debdf845bf
commit 043629ec87
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/build123d/operations_generic.py
View file

@ -616,7 +616,14 @@ def offset(
inner_wires.append(offset_wire) inner_wires.append(offset_wire)
except: except:
pass pass
new_face = Face(outer_wire, inner_wires) # inner wires may go beyond the outer wire so subtract faces
new_face = Face(outer_wire)
if inner_wires:
inner_faces = [Face(w) for w in inner_wires]
new_face = new_face.cut(*inner_faces)
if isinstance(new_face, Compound):
new_face = new_face.unwrap(fully=True)
if (new_face.normal_at() - face.normal_at()).length > 0.001: if (new_face.normal_at() - face.normal_at()).length > 0.001:
new_face = -new_face new_face = -new_face
new_faces.append(new_face) new_faces.append(new_face)

7
tests/test_build_generic.py
View file

@ -521,6 +521,13 @@ class OffsetTests(unittest.TestCase):
offset(amount=1, kind=Kind.INTERSECTION) offset(amount=1, kind=Kind.INTERSECTION)
self.assertAlmostEqual(test.sketch.area, 9, 5) self.assertAlmostEqual(test.sketch.area, 9, 5)
def test_face_offset_with_holes(self):
sk = Rectangle(100, 100) - GridLocations(80, 80, 2, 2) * Circle(5)
sk2 = offset(sk, -5)
self.assertTrue(sk2.face().is_valid())
self.assertLess(sk2.area, sk.area)
self.assertEqual(len(sk2), 1)
def test_box_offset(self): def test_box_offset(self):
with BuildPart() as test: with BuildPart() as test:
Box(10, 10, 10) Box(10, 10, 10)