mirror of
https://github.com/Jermolene/TiddlyWiki5.git
synced 2026-05-08 05:15:49 -07:00
005e175378
PR #9251 replaced the manual setAttribute("class", ...) implementation of $tw.utils.addClass/removeClass/toggleClass with direct Element.classList calls. Unlike setAttribute, classList.add/remove/toggle throws InvalidCharacterError on any token containing whitespace, so callers that pass a whole class string (e.g. modal.js passing tiddler.fields.class) now crash. Manual repro on tw5-com: open SampleWizard, set the `class` field to "aaa bbb", Done, open popup -> OK -> open nested popup -> RSOD. Fix: split the className argument on whitespace in deprecated.js and feed individual tokens to classList. A small splitClasses() helper keeps the three functions symmetrical. Adds adversarial regression tests in test-utils.js covering: - ASCII whitespace variants (space, tab, CR, LF, mixed runs, padding) - Unicode whitespace (U+00A0 non-breaking space) - de-duplication across single and multiple calls - remove/toggle no-op on missing tokens - toggle with status undefined / true / false - silent no-op for whitespace-only / empty / non-string / null input - silent no-op when the element has no classList |
||
|---|---|---|
| .. | ||
| images | ||
| language | ||
| modules | ||
| palettes | ||
| stylesheets | ||
| templates | ||
| ui | ||
| wiki | ||
| acknowledgements.tid | ||
| copyright.tid | ||
| icon.tid | ||
| plugin.info | ||
| readme.tid | ||
| sjcl-license.tid | ||
title: $:/core/readme
This plugin contains TiddlyWiki's core components, comprising:
* JavaScript code modules
* Icons
* Templates needed to create TiddlyWiki's user interface
* British English (''en-GB'') translations of the localisable strings used by the core