mirrors/TiddlyWiki5
1
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5.git synced 2026-03-13 18:22:14 -07:00
Code Issues Projects Releases Packages Wiki Activity

Unconditionally decrement transaction depth (#8008)

Browse source 
…otherwise we may end up in a situation where we're always stuck in an
"already in a transaction" state and often neglect to actually enter a
real transaction!
This commit is contained in:
Rob Hoelz 2024-02-26 05:02:55 -06:00 • committed by GitHub
parent d7d0733177
commit de4fe132a7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

28
plugins/tiddlywiki/multiwikiserver/modules/sql-tiddler-database.js
View file

@ -507,20 +507,22 @@ TODO: better-sqlite3 provides its own transaction method which we should be usin
SqlTiddlerDatabase.prototype.transaction = function(fn) {
const alreadyInTransaction = this.transactionDepth > 0;
this.transactionDepth++;
if(alreadyInTransaction) {
return fn();
} else {
this.runStatement(`BEGIN TRANSACTION`);
try {
var result = fn();
this.runStatement(`COMMIT TRANSACTION`);
} catch(e) {
this.runStatement(`ROLLBACK TRANSACTION`);
throw(e);
} finally {
this.transactionDepth--;
try {
if(alreadyInTransaction) {
return fn();
} else {
this.runStatement(`BEGIN TRANSACTION`);
try {
var result = fn();
this.runStatement(`COMMIT TRANSACTION`);
} catch(e) {
this.runStatement(`ROLLBACK TRANSACTION`);
throw(e);
}
return result;
}
return result;
} finally {
this.transactionDepth--;
}
};