mirrors/TiddlyWiki5
1
Fork 0
mirror of https://github.com/Jermolene/TiddlyWiki5.git synced 2026-03-15 19:21:28 -07:00
Code Issues Projects Releases Packages Wiki Activity

Refactor checkbox tests: move function to top

Browse source 
The big findNodeOfType function belongs at the top of the describe
block, so that the checkbox tests are more compact and easy to read.
This commit is contained in:
Robin Munn 2022-03-25 10:05:04 +07:00
parent fc21a9951d
commit 5d369083a5
1 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

33
editions/test/tiddlers/tests/test-widget.js
View file

@ -47,6 +47,23 @@ describe("Widget module", function() {
// console.log(require("util").inspect(wrapper,{depth: 8}));
}
// Find a particular type of node from inside the widget tree
// Less brittle than wrapper.children[0].children[0] if the parse
// tree ever changes in the future
function findNodeOfType(targetType, currentNode) {
if(currentNode.parseTreeNode && currentNode.parseTreeNode.type === targetType) {
return currentNode;
} else if(currentNode.children && currentNode.children.length) {
var child, result, i;
for (i = 0; i < currentNode.children.length; i++) {
child = currentNode.children[i];
result = findNodeOfType(targetType, child);
if(result) return result;
}
}
return undefined;
}
it("should deal with text nodes and HTML elements", function() {
var wiki = new $tw.Wiki();
// Test parse tree
@ -305,22 +322,6 @@ describe("Widget module", function() {
// Check initial state
// Extract the input node from inside the widget tree for later tests
function findNodeOfType(targetType, currentNode) {
if(currentNode.parseTreeNode && currentNode.parseTreeNode.type === targetType) {
return currentNode;
} else if(currentNode.children && currentNode.children.length) {
var child;
var result;
var i;
for (i = 0; i < currentNode.children.length; i++) {
child = currentNode.children[i];
result = findNodeOfType(targetType, child);
if(result) return result;
}
}
return undefined;
}
const widget = findNodeOfType('checkbox', widgetNode);
// Verify that the widget is or is not checked as expected
expect(Object.getPrototypeOf(widget).getValue.call(widget)).toBe(data.startsOutChecked);