mirror of
https://github.com/tiddly-gittly/TidGi-Desktop.git
synced 2026-03-17 04:11:33 -07:00
64cc965a4a
* Add wiki tiddler attachment support to agent chat Implements the ability to attach wiki tiddlers to agent chat messages. Updates the UI to allow selection of tiddlers from active wiki workspaces, fetches and renders tiddler content as plain text, and appends it to the user message sent to the AI. Includes e2e tests, updates to store actions, service interfaces, and prompt concatenation logic to support this feature. * fix: callback not useCallback cause autocomplete panel flash * Add wiki tiddler attachments to message bubbles Message bubbles now display attached wiki tiddlers as clickable chips, allowing users to navigate directly to the referenced tiddler in the appropriate workspace. Metadata handling and persistence for wiki tiddlers has been updated to include workspaceId, and tests have been added to verify the new UI behavior. The chat view also now closes the TiddlyWiki sidebar for better focus when navigating from a selection. * Support split view navigation for wiki tiddler attachments Adds isSplitView prop to ChatTabContent and related components to distinguish between split view and normal tab modes. Wiki tiddler attachment navigation now uses a different strategy in split view, opening tiddlers directly in the browser view. Updates types and tests to reflect the new behavior, and improves robustness of response handling in several places. * docs: move to .github/instructions/testing.instructions.md * test: view loading slow on mac * refactor(e2e): move wiki load steps to Background in talkWithAI.feature; remove all sidebar close delays and polling, only set state when TiddlyWiki is ready; clean up code and logs for sidebar auto-close in split view * docs: make test inst shorter * lint * refactor(view): slim ViewService, move menu to separate file, orchestrate view logic in WorkspaceViewService, update all callers, fix lint floating promise, all unit and e2e tests pass * fix: add data-testid to attachment listbox for E2E test - Add slotProps to MUI Autocomplete to ensure attachment-listbox is rendered with correct test-id - Fix E2E test timeout when waiting for attachment listbox element * lint * put 'Talk with AI' menu on top and attachment i18n Introduce a reusable createTalkWithAIMenuItems helper to build "Talk with AI" menu entries (default agent + other agents submenu) and integrate it into workspace menu generation. Add new i18n keys for Agent.Attachment and WikiEmbed across locales and update UI to use translation keys (remove hardcoded fallback strings). Improve chat input/attachment behavior: expose a test-id for the attachment listbox, use i18n for labels/placeholders, and tweak input component wiring. Fix Cucumber step handling by normalizing expected newline sequences and safely handling empty message content. Also adjust memo deps in SortableWorkspaceSelectorButton to include id. * feat: enhance AI interaction in workspace context menu with local trigger support * feat: add tool approval and timeout settings - Introduced ToolApprovalConfig and related types for managing tool execution approvals. - Implemented WebFetch and ZxScript tools for fetching web content and executing scripts, respectively. - Added token estimation utilities for context window management. - Enhanced ModelInfo interface with context window size and max output tokens. - Created API Retry Utility for handling transient failures with exponential backoff. - Updated AIAgent preferences section to include Tool Approval & Timeout Settings dialog. - Developed ToolApprovalSettingsDialog for configuring tool-specific approval rules and retry settings. - Modified vitest configuration to support aliasing for easier imports and stubbing. * Refactor agent instance tools and services for improved modularity and maintainability - Extracted type definitions and tool registry from defineTool.ts into separate files (defineToolTypes.ts, toolRegistry.ts) to reduce file size and enhance importability. - Implemented a retry mechanism in ExternalAPIService for stream creation to handle transient failures. - Updated ToolApprovalSettingsDialog to persist settings using localStorage instead of a preference service. - Created agentMessagePersistence.ts and agentRepository.ts to manage agent message and instance CRUD operations, reducing the size of AgentInstanceService. - Added a progress tracker document (AgentTODO.md) for the ongoing enhancement plan of the TidGi Agent. * feat: add AgentSwitcher component for agent definition switching - Implemented AgentSwitcher component with dropdown functionality for selecting agent definitions. - Integrated loading of agent definitions on dropdown open. - Added visual feedback for current selection and disabled state. feat: create ToolResultRenderer for generic tool result messages - Developed ToolResultRenderer to handle rendering of <functions_result> messages. - Included collapsible parameters and result display with error handling. - Added truncation for long results in collapsed view. test: add comprehensive tests for MessageRenderer components - Implemented tests for AskQuestionRenderer, ToolResultRenderer, ToolApprovalRenderer, and BaseMessageRenderer. - Ensured proper rendering and functionality for various message types and states. - Included pattern routing tests for MessageRenderer. feat: introduce TurnActionBar for action management in agent turns - Created TurnActionBar component for managing actions like rollback, retry, delete, and copy. - Integrated visual feedback for file changes and rollback status. - Added functionality for copying agent responses and full conversation to clipboard. feat: implement askQuestionPending for managing user responses - Developed infrastructure for handling pending ask-question requests. - Implemented promise-based blocking until user responds to agent questions. - Added timeout handling for ask-question requests. * feat: Implement background task management for agent instances - Added functionality to restore heartbeat timers and alarms for active agents upon service initialization. - Introduced methods to retrieve active background tasks and cancel them via the UI. - Enhanced alarm clock tool to persist alarm data in the database, ensuring alarms survive app restarts. - Updated agent instance schema to include scheduled alarm data. - Modified prompt concatenation logic to support context window size for message history. - Removed system prompt parameter from model parameters schema and related components. - Improved UI to display and manage background tasks, including heartbeat and alarm details. * feat: Implement Scheduled Tasks Management and Background Task Settings - Add feature for managing scheduled tasks for agents, including viewing, adding, and editing tasks. - Create tests for agent repository and background task settings APIs. - Introduce ScheduledTaskManager for unified scheduling of tasks with interval, at, and cron schedules. - Implement edit-agent-definition tool for modifying agent configurations, including heartbeat and prompt settings. - Ensure tasks persist across app restarts and respect active hours filtering. * Update wiki * fix(security): harden htmlToText against XSS via encoded tags - Use tolerant script/style regex that handles </script > with spaces - Stop decoding </> entities to prevent reintroducing HTML tags - Decode & last to avoid double-unescaping (&lt; < <) - Fixes all 4 CodeQL findings (bad filtering, incomplete sanitization, double escaping, incomplete multi-character sanitization) * fix: lint and format errors (eslint naming, dprint formatting, stub classes) * fix: exclude tidgi.config.json from template copy and fix log marker pattern - Skip tidgi.config.json when copying wiki template to prevent overriding workspace name - Change waitForLogMarker default pattern from 'wiki-' to '*' to match actual log filenames - Filter tidgi.config.json in e2e step too (fs.copy in wiki creation step) * perf(e2e): merge 5 scheduledTask scenarios into 2 to reduce app restarts * perf(e2e): merge crossWindowSync and streamingStatus scenarios to reduce CI time * ci: increase test timeout to 20min for larger e2e scenario count * perf(e2e): merge agent scenarios and enable parallel on CI - Merge agent.feature wiki-search + wiki-operation into one scenario - Merge agent.feature create-agent-from-newtab + create-agent-from-fallback into one - Enable cucumber parallel: 2 on CI (7GB RAM, dynamic ports for mock servers) - Total scenarios: 66 -> 61 * fix: cleanup MCP client processes when deleting or closing agent * ci: disable parallel (CPU contention), increase timeout to 30min for 61 scenarios * perf(e2e): merge 3 preference background-task scenarios into 1, increase timeout to 45min - Preference alarm/heartbeat CRUD merged into single scenario (saves 2 app restarts) - Total scenarios: 59 (was 66) - CI timeout 45min for the expanded e2e suite * fix: restructure e2e scenarios, fix subscription leak and debounce cleanup - Restructure agent/talkWithAI/streamingStatus feature files for reliability - Fix talkWithAI scenarios missing mock server startup and app launch - Remove duplicate subscription in handleSwitchAgent (useEffect already handles it) - Clean up debounced update functions when agent is deleted/closed - Use agentId:messageId key for debounced functions to enable per-agent cleanup * fix(e2e): remove :last-child selectors broken by TurnActionBar, fix tab/dialog selectors, increase CI timeout to 25min * fix: use const for non-reassigned variable (lint) * fix(e2e): fix close-all-tabs opacity issue, scheduledTask undefined steps, MUI multiline textarea targeting * fix(e2e): use tab-list-dropdown to close all tabs, fix selector for actual TabListDropdown component * fix(e2e): add timing waits for BrowserView repositioning and git log UI refresh * fix(e2e): make 'should not see' step wait for element to disappear instead of instant check * fix(e2e): increase executeInBrowserView default timeout from 500ms to 2000ms
138 lines
12 KiB
Gherkin
138 lines
12 KiB
Gherkin
Feature: Create New Agent Workflow
|
||
As a user
|
||
I want to create a new agent definition using a multi-step wizard
|
||
So that I can customize agents for specific tasks and use them immediately
|
||
|
||
Background:
|
||
Given I add test ai settings
|
||
|
||
@newAgent @mockOpenAI
|
||
Scenario: Create new agent definition and edit prompt and check server request
|
||
# Setup mock OpenAI server first
|
||
Given I have started the mock OpenAI server
|
||
| response | stream |
|
||
| 作为代码助手，我可以帮您解决编程问题。请问需要什么帮助？ | false |
|
||
# Launch application after mock server is ready
|
||
Then I launch the TidGi application
|
||
And I wait for the page to load completely
|
||
And I should see a "page body" element with selector "body"
|
||
# Ensure we are in the correct workspace before each scenario
|
||
When I click on an "agent workspace button" element with selector "[data-testid='workspace-agent']"
|
||
And I should see a "new tab button" element with selector "[data-tab-id='new-tab-button']"
|
||
# Step 1: Open new tab and navigate to CreateNewAgent
|
||
When I click on "new tab button and create new agent button" elements with selectors:
|
||
| element description | selector |
|
||
| new tab button | [data-tab-id='new-tab-button'] |
|
||
| create new agent button | [data-testid='create-new-agent-button'] |
|
||
# Step 2: Verify first step content (Setup Agent: Name + Template)
|
||
Then I should see "step title and search input and agent name input field" elements with selectors:
|
||
| element description | selector |
|
||
| step title | *:has-text('设置智能体') |
|
||
| search input | .aa-Input |
|
||
| agent name input field | [data-testid='agent-name-input-field'] |
|
||
# Step 3: Select template to advance to step 2
|
||
When I click on a "search input" element with selector ".aa-Input"
|
||
# Wait for autocomplete panel to load with templates (async operation in CI)
|
||
And I should see an "autocomplete panel" element with selector ".aa-Panel"
|
||
# Using description text to select specific agent, more precise than just name
|
||
When I click on a "Example Agent template" element with selector '.aa-Item[role="option"]:has-text("General-purpose TiddlyWiki AI assistant")'
|
||
# Fill in agent name while still in step 1
|
||
When I clear text in "agent name input" element with selector "[data-testid='agent-name-input-field']"
|
||
When I type "我的代码助手" in "agent name input" element with selector "[data-testid='agent-name-input-field']"
|
||
# Advance to step 2 (Edit Prompt)
|
||
When I click on a "next button" element with selector "[data-testid='next-button']"
|
||
# Step 4: Verify second step content (Edit Prompt) - using text selector as a diagnostic
|
||
And I should see a "edit prompt title" element with selector "h6:has-text('编辑提示词')"
|
||
# Step 4.1: Wait for PromptConfigForm to load
|
||
# Verify the PromptConfigForm is present with our new test id
|
||
And I should see a "prompt config form" element with selector "[data-testid='prompt-config-form']"
|
||
# Step 4.2: Navigate to the correct tab and expand array items to edit prompt
|
||
# Look for tabs in the PromptConfigForm
|
||
And I should see a "config tabs" element with selector "[data-testid='prompt-config-form'] .MuiTabs-root"
|
||
# Click on the first tab, expand array item, and click on the system prompt text field
|
||
When I click on "first config tab and expand array item button and system prompt text field" elements with selectors:
|
||
| element description | selector |
|
||
| first config tab | [data-testid='prompt-config-form'] .MuiTab-root:first-of-type |
|
||
| expand array item button | [data-testid='prompt-config-form'] [role='tabpanel']:not([hidden]) button[title*='展开'], [data-testid='prompt-config-form'] [role='tabpanel']:not([hidden]) button svg[data-testid='ExpandMoreIcon'] |
|
||
| system prompt text field | [data-testid='prompt-config-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly]) |
|
||
When I clear text in "system prompt text field" element with selector "[data-testid='prompt-config-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly])"
|
||
When I type "你是一个专业的代码助手，请用中文回答编程问题。" in "system prompt text field" element with selector "[data-testid='prompt-config-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly])"
|
||
# Step 5: Advance to step 3 (Immediate Use)
|
||
When I click on a "next button" element with selector "[data-testid='next-button']"
|
||
# Step 6: Verify third step content (Immediate Use with chat interface)
|
||
And I should see a "immediate use title" element with selector "*:has-text('测试并使用')"
|
||
# Step 7: Test in the preview chat interface (part of step 3)
|
||
When I click on a "message input textarea" element with selector "[data-testid='agent-message-input']"
|
||
When I type "帮我写个 Hello World" in "chat input" element with selector "[data-testid='agent-message-input']"
|
||
And I press "Enter" key
|
||
# Verify the agent responds in the preview interface
|
||
Then I should see "user message and assistant message" elements with selectors:
|
||
| element description | selector |
|
||
| user message | *:has-text('帮我写个 Hello World') |
|
||
| assistant message | *:has-text('作为代码助手') |
|
||
And the last AI request should contain system prompt "你是一个专业的代码助手，请用中文回答编程问题。"
|
||
# Step 8: Save and start using (after testing in step 3)
|
||
When I click on a "save and use button" element with selector "button:has-text('保存并使用智能体')"
|
||
# Verify agent was created and separate chat tab opened
|
||
Then I should see a "message input box" element with selector "[data-testid='agent-message-input']"
|
||
|
||
@editAgentDefinition @mockOpenAI
|
||
Scenario: Edit existing agent definition workflow
|
||
# Setup mock OpenAI server first
|
||
Given I have started the mock OpenAI server
|
||
| response | stream |
|
||
| 作为已编辑的代码助手，我可以帮您解决编程问题。请问需要什么帮助？ | false |
|
||
# Launch application after mock server is ready
|
||
Then I launch the TidGi application
|
||
And I wait for the page to load completely
|
||
And I should see a "page body" element with selector "body"
|
||
# Ensure we are in the correct workspace before each scenario
|
||
When I click on an "agent workspace button" element with selector "[data-testid='workspace-agent']"
|
||
And I should see a "new tab button" element with selector "[data-tab-id='new-tab-button']"
|
||
# Step 1: Open new tab to access create default agent card
|
||
When I click on a "new tab button" element with selector "[data-tab-id='new-tab-button']"
|
||
# Step 2: Right-click on create default agent card to open context menu
|
||
When I right-click on a "create default agent card" element with selector "[data-testid='create-default-agent-button']"
|
||
# Step 3: Click on edit definition option in context menu
|
||
When I click on a "edit definition menu item" element with selector "[data-testid='edit-definition-menu-item']"
|
||
# Step 4: Verify direct edit interface (no steps - all content visible)
|
||
And I should see "edit agent title and basic info section and edit prompt section and immediate use section" elements with selectors:
|
||
| element description | selector |
|
||
| edit agent title | *:has-text('编辑智能体定义') |
|
||
| basic info section | *:has-text('编辑基本信息') |
|
||
| edit prompt section | *:has-text('编辑提示词') |
|
||
| immediate use section | *:has-text('测试并使用') |
|
||
# Step 5: Edit agent name in the basic info section
|
||
And I should see a "agent name input" element with selector "[data-testid='edit-agent-name-input']"
|
||
When I clear text in "agent name input" element with selector "[data-testid='edit-agent-name-input-field']"
|
||
When I type "编辑后的示例智能体" in "agent name input" element with selector "[data-testid='edit-agent-name-input-field']"
|
||
# Step 6: Edit the prompt configuration - Wait for PromptConfigForm to load
|
||
# Verify the PromptConfigForm is present
|
||
And I should see a "prompt config form" element with selector "[data-testid='edit-agent-prompt-form']"
|
||
# Step 6.1: Navigate to the correct tab and expand array items to edit prompt
|
||
# Look for tabs in the PromptConfigForm
|
||
And I should see a "config tabs" element with selector "[data-testid='edit-agent-prompt-form'] .MuiTabs-root"
|
||
# Click on the first tab, expand array item, and click on the system prompt text field
|
||
When I click on "first config tab and expand array item button and system prompt text field" elements with selectors:
|
||
| element description | selector |
|
||
| first config tab | [data-testid='edit-agent-prompt-form'] .MuiTab-root:first-of-type |
|
||
| expand array item button | [data-testid='edit-agent-prompt-form'] [role='tabpanel']:not([hidden]) button[title*='展开'], [data-testid='edit-agent-prompt-form'] [role='tabpanel']:not([hidden]) button svg[data-testid='ExpandMoreIcon'] |
|
||
| system prompt text field | [data-testid='edit-agent-prompt-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly]) |
|
||
When I clear text in "system prompt text field" element with selector "[data-testid='edit-agent-prompt-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly])"
|
||
When I type "你是一个经过编辑的专业代码助手，请用中文详细回答编程问题。" in "system prompt text field" element with selector "[data-testid='edit-agent-prompt-form'] [role='tabpanel']:not([hidden]) textarea[id*='_text']:not([readonly])"
|
||
# Step 7: Test in the immediate use section (embedded chat)
|
||
# The immediate use section should show an embedded chat interface
|
||
# Find a message input in the immediate use section and test the agent
|
||
When I click on a "message input textarea" element with selector "[data-testid='agent-message-input']"
|
||
When I type "你好，请介绍一下自己" in "chat input" element with selector "[data-testid='agent-message-input']"
|
||
And I press "Enter" key
|
||
# Verify the agent responds in the embedded chat
|
||
Then I should see "user message and assistant message" elements with selectors:
|
||
| element description | selector |
|
||
| user message | *:has-text('你好，请介绍一下自己') |
|
||
| assistant message | *:has-text('已编辑的代码助手') |
|
||
# Verify that the server received the request with the modified system prompt
|
||
And the last AI request should contain system prompt "你是一个经过编辑的专业代码助手，请用中文详细回答编程问题。"
|
||
# Step 8: Save the edited agent definition
|
||
And I should see a "save button" element with selector "[data-testid='edit-agent-save-button']"
|
||
When I click on a "save button" element with selector "[data-testid='edit-agent-save-button']"
|