mirror of
https://github.com/tiddly-gittly/TidGi-Desktop.git
synced 2026-04-07 06:10:48 -07:00
a931058f17
* chore: upgrade Electron 39->41, forge 7.10->7.11, fix native ABI and preload naming
- electron: 39.2.3 -> 41.1.1
- @electron-forge/*: 7.10.2 -> 7.11.1
- better-sqlite3: 12.4.5 -> 12.8.0 (rebuild against Electron 41 ABI 145)
- electron-unhandled: 5.0.0 -> 4.0.1 (v5 uses top-level await, breaks CJS main build)
- vite.preload.config.ts: emit preload.js (not index.js) to avoid collision with main
- viteEntry.ts: getPreloadPath() -> preload.js, renderer path unchanged
- package.json main: .vite/build/main.js (matches forge lib output)
- package.json: strip UTF-8 BOM that broke Volta manifest parsing
* fix: resolve AbortSignal realm mismatch in Electron 41 for streaming tests
In Electron 41, ELECTRON_RUN_AS_NODE mode uses Chromium-based fetch which
requires Blink's AbortSignal. Node.js AbortSignal fails the instanceof check.
Fixes:
- vitest.config.ts: set features/** to node environment via environmentMatchGlobs
so HTTP-only tests use Node.js fetch (not Chromium fetch)
- setup-vitest.ts: guard all document/window access behind typeof document check
so setup is safe in both jsdom and node environments
- callProviderAPI.ts: no change needed (signal issue is env-specific)
* ci: increase test timeout to 60min, fix find -o with xargs rm
- timeout-minutes: 25 -> 60 (packaging ~22min + unit tests ~1min + e2e needed)
- fix 'find ... -o ... | xargs rm' -> 'find ... \( -o \) ... -exec rm -rf {} +'
(the unparenthesized -o with xargs caused 'rm: invalid option -- o' in CI)
* fix: copy tiddlywiki/core-server to packaged output
TiddlyWiki 5.4.0-prerelease introduced core-server/ directory which contains
commander.js (module-type: global). Without it, \.Commander is undefined
when load-modules.js startup runs \.Commander.initCommands(), crashing the
wiki worker with 'Cannot read properties of undefined (reading initCommands)'.
core-server is loaded by boot.js via loadPluginFolder(\.boot.coreServerPath),
which silently returns null when the directory is missing, so the error was
non-obvious and only manifested when actually starting a wiki workspace.
* perf: only screenshot on failure, revert timeout to 25min
AfterStep was capturing a screenshot after every step (~1191 of 1446 steps).
Each screenshot requires IPC round-trip: getFirstWebContentsView capturePage
serialize PNG transfer buffer fs.writeFile. On CI this costs ~200-400ms
per step, totaling ~6 minutes of pure screenshot overhead.
Now screenshots are only taken for FAILED steps, saving ~6 minutes on CI.
This brings the total test time well within the 25-minute budget.
* fix: flaky tests + merge scenarios to save 8 Electron launches
- crossWindowSync: wait for tiddler to be saved to disk via watch-fs before opening second window
- tidgiMiniWindowWorkspace: add retry backoff to 'should not see elements' step
- tidgiMiniWindow: add explicit window switch after addTiddler
- Merge 5 filesystemPlugin scenarios into 1 (save 4 launches)
- Merge 2 defaultWiki scenarios into 1 (save 1 launch)
- Merge 2 preference scenarios into 1 (save 1 launch)
- Merge smoke + logging into 1 (save 1 launch)
- Merge 2 tiddler scenarios into 1 (save 1 launch)
- Total: 65 57 scenarios (8 fewer Electron launches)
* fix: address CI failures - use IPC for mini window toggle, split talkWithAI clicks
- tidgiMiniWindow: use direct IPC toggle instead of keyboard shortcut after addTiddler
to avoid race condition between TW syncer and keyboard event dispatch
- talkWithAI: split multi-click step into individual clicks so each gets its own
25s timeout budget on CI
* fix: await showWindow() in openTidgiMiniWindow to prevent race condition
The two showWindow() calls were using void (fire-and-forget), meaning
toggleTidgiMiniWindow returned before the window was actually shown.
On CI/Xvfb, the test checked isVisible() before show() completed.
* perf: merge scenarios + split CI steps for faster E2E
- Merge 3 defaultWiki scenarios into 1 (save 2 app launches)
- Merge 2 scheduledTask scenarios into 1 (save 1 app launch)
- Split CI test step into unit/prepare/e2e for visibility
- Add pnpm store cache to CI
- Fix viteEntry.ts: remove UTF-8 BOM, update stale JSDoc comment
- Set E2E timeout to 22min (was 25min in single step)
* fix: address Copilot review - main window lookup and comment clarity
- tidgiMiniWindow.ts: use index.html URL pattern to find main window
(consistent with other step defs, avoids matching preferences window)
- ui.ts: clarify networkidle timeout comment
* fix: use IPC toggle for tidgiMiniWindow sync scenario to avoid flaky keyboard shortcut on CI
---------
Co-authored-by: CI Auto <cidevel@tiddlygit.local>
60 lines
3.5 KiB
Gherkin
60 lines
3.5 KiB
Gherkin
@tidgi-mini-window
|
|
Feature: TidGi Mini Window
|
|
As a user
|
|
I want to enable and use the TidGi mini window
|
|
So that I can quickly access TidGi from the system tray
|
|
|
|
Scenario: Enable tidgi mini window and test keyboard shortcut
|
|
Given I cleanup test wiki so it could create a new one on start
|
|
And I launch the TidGi application
|
|
And I wait for the page to load completely
|
|
And I click on an "open preferences button" element with selector "#open-preferences-button"
|
|
And I switch to "preferences" window
|
|
When I click on a "tidgi mini window section" element with selector "[data-testid='preference-section-tidgiMiniWindow']"
|
|
And I confirm the "tidgiMiniWindow" window does not exist
|
|
When I click on an "attach to tidgi mini window switch" element with selector "[data-testid='attach-to-tidgi-mini-window-switch']"
|
|
And I confirm the "tidgiMiniWindow" window exists
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
Then I should see "always on top toggle and workspace sync toggle" elements with selectors:
|
|
| element description | selector |
|
|
| always on top toggle | [data-testid='tidgi-mini-window-always-on-top-switch'] |
|
|
| workspace sync toggle | [data-testid='tidgi-mini-window-sync-workspace-switch'] |
|
|
Then I click on a "shortcut register button" element with selector "[data-testid='shortcut-register-button']"
|
|
And I press the key combination "CommandOrControl+Shift+M"
|
|
And I click on a "shortcut confirm button" element with selector "[data-testid='shortcut-confirm-button']"
|
|
And I close "preferences" window
|
|
Then I switch to "main" window
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window exists
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I confirm the "tidgiMiniWindow" window browser view is positioned within visible window bounds
|
|
And I switch to "tidgiMiniWindow" window
|
|
Then the browser view should be loaded and visible
|
|
And I should see "我的 TiddlyWiki" in the browser view content
|
|
Then I switch to "main" window
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window exists
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
|
|
Scenario: Hidden tidgi mini window catches up with main window changes when shown again
|
|
Given I configure tidgi mini window with shortcut
|
|
And I cleanup test wiki so it could create a new one on start
|
|
And I launch the TidGi application
|
|
And I wait for the page to load completely
|
|
Then I switch to "main" window
|
|
# Use IPC toggle for reliability — this scenario tests sync behavior, not the keyboard shortcut
|
|
When I toggle tidgi mini window via IPC
|
|
And I confirm the "tidgiMiniWindow" window exists
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
Then I switch to "tidgiMiniWindow" window
|
|
And the browser view should be loaded and visible
|
|
Then I switch to "main" window
|
|
When I toggle tidgi mini window via IPC
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
When I execute TiddlyWiki code in browser view: "$tw.wiki.addTiddler(new $tw.Tiddler({title: 'Index', text: 'TidgiMiniWindowHiddenSync123'}))"
|
|
When I toggle tidgi mini window via IPC
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
Then I switch to "tidgiMiniWindow" window
|
|
And the browser view should be loaded and visible
|
|
And I should see "TidgiMiniWindowHiddenSync123" in the browser view content
|
|
|