mirror of
https://github.com/tiddly-gittly/TidGi-Desktop.git
synced 2026-01-21 12:02:57 -08:00
6384fd8bd1
* fix: not removed
* Optimize tidgi.config.json writes for workspace updates
Update logic to write tidgi.config.json only for the modified workspace instead of all wiki workspaces on each update. This reduces redundant file operations and improves performance during workspace updates.
* Refactor workspace saving and UI update logic
Introduced a private saveWorkspacesToSettings method to centralize logic for saving workspaces and removing syncable fields from wiki workspaces. The set and setWorkspaces methods now support skipping UI updates for batch operations, improving performance. Fixed minor issues in legacy migration and error messages.
* Add 'Ask AI' context menu and wiki embed split view
Introduces an 'Ask AI' option to the wiki context menu, enabling users to send selected text to an agent chat in a split view with the wiki embedded. Implements new tab type WIKI_EMBED, updates tab and channel types, adds localization, manages BrowserView bounds for embedding, and ensures persistence and IPC wiring for the new workflow.
* Update wiki
* electron chrome mcp mode sometimes wont show browser view
Clarified troubleshooting steps in docs/MCP.md regarding browser view issues and updated the instructions. Reordered the 'start:dev:mcp' script in package.json for better organization.
* Add agent selection to 'Talk with AI' context menu
Replaces the 'Ask AI' context menu with 'Talk with AI' and adds a submenu for selecting different agent definitions. Updates translations for all supported languages, modifies the askAIWithSelection channel to support agentDefId, and refactors tab creation logic to support split view with agent selection. Improves robustness in view management by handling case-insensitive workspace IDs and custom bounds logic.
* Add e2e test and refactor 'Talk with AI' split view logic
Introduces a new Cucumber feature for 'Talk with AI' from wiki selection, adds a step definition to trigger the workflow via IPC, and refactors split view tab creation to reuse existing tabs when possible. Updates the agent browser service to support finding or creating the appropriate split view tab, and adjusts menu and view services for improved robustness and code clarity. Also adds test IDs to relevant components for more reliable UI testing.
* Update defaultWiki.feature
* Add config error handling and i18n for agent errors
Introduces a new feature test for configuration error handling, adds step definition to remove AI settings for testing, and updates error message rendering to support new error types. Internationalized error messages and button labels for configuration issues are added in both English and Chinese locales. The error message renderer now uses a data-testid for easier testing and recognizes additional error types as fixable in settings.
* Refactor feature files to use two-column selector tables
Updated all feature files to use a standardized two-column format for selector tables, with explicit 'element description' and 'selector' columns. Step definitions in ui.ts were refactored to support this format, improving readability and maintainability of test steps and error handling.
* Delete tiddlywiki
* test: allow parallel
* test: implement scenario isolation for E2E tests
- Isolate each test scenario in test-artifacts/{scenarioSlug}/ directory
- Use dynamic ports for mock OpenAI server to avoid port conflicts
- Log VIEW_LOADED event via did-finish-load in main process (more reliable)
- Search all .log files when waiting for log markers
- Increase timeout for log marker steps to 15 seconds
- Fix ts-node cache issues by clearing cache before tests
- Move application launch to individual scenarios (required for mock server setup)
All 45 E2E test scenarios now pass consistently.
* refactor: optimize agent.feature by moving common steps to Background
- Add MockOpenAIServer.addRules() method to append responses dynamically
- Add 'I have started the mock OpenAI server without rules' step for Background
- Add 'I add mock OpenAI responses:' step to inject responses per scenario
- Move application launch and navigation to Background (shared by all scenarios)
- Keep scenario-specific mock responses in individual scenarios
This improves test maintainability by reducing duplication while keeping
scenario-specific configuration flexible.
* lint
* Refactor scenario path helpers into shared module
Moved scenario-specific path helper functions from individual step definition files to a centralized 'features/supports/paths.ts' module. Updated imports in step definitions to use the shared helpers, improving code reuse and maintainability. Also enhanced test for ContextService to skip optional runtime keys.
* Refactor slug generation to use shared slugify helper
Introduced a new src/helpers/slugify.ts utility for consistent slug generation across the codebase. Updated appPaths.ts to use the shared slugify function, improving maintainability and ensuring identical behavior for test scenario slugs. Added documentation and clarified slugification rules in relevant files. Minor comments and clarifications were added to E2E and mock server code.
* Enforce strict timeout rules in E2E test steps
Added and clarified critical warnings for AI agents regarding timeout modifications in application, cleanup, and wiki step definitions. All timeouts are now strictly limited to 5s local and 10s CI, with explicit comments and environment-based values. Updated documentation and code comments to reinforce that timeouts indicate real bugs and should not be increased.
* Update features/stepDefinitions/application.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor E2E helpers, improve test reliability and cleanup
Centralizes data table parsing for UI step definitions, refactors mock OpenAI server setup, and improves workspace settings path handling for tests. Adjusts timeouts for window and app closing to better reflect real-world performance. Fixes type usage in workspace ID lookups and adds error handling for resize observer and cleanup in WikiEmbedTabContent. Enhances agent browser tab logic and view service cleanup to prevent memory leaks and catch workspace ID casing issues.
* Update agent.ts
* fix: resolve all E2E test timeout issues
* fix: improve CI test reliability with better timing and cleanup
- Use exponential-backoff library for agent creation retry logic
- Extend agent cancel delay to 1000ms for CI environments
- Fix git log refresh marker timing with queueMicrotask
- Improve cleanup timeout handling with force close strategy
All E2E tests passing locally including previously failing CI tests.
* Improve Git log E2E signal and add debug logging
Renames the test artifact in the CI workflow for clarity. Moves the E2E test timing log in useGitLogData to after entries are rendered, using a more reliable signal. Adds a debug log to notifyGitStateChange for better traceability.
* test-artifacts-ci
* Optimize test artifact handling and Git log logging
Update CI workflow to clean up large cache folders in test artifacts and only upload logs, settings, and screenshots to reduce artifact size. Refactor useGitLogData to log immediately after state updates for improved E2E test reliability, removing unnecessary setTimeout.
* Update useGitLogData.ts
* Improve Git log E2E test logging and .gitignore
Added 'test-artifacts-ci.zip' to .gitignore. Moved the '[test-id-git-log-refreshed]' log to immediately after data load for more reliable E2E test detection, and removed redundant logging from the render effect in useGitLogData.ts.
* Update useGitLogData.ts
* Update useGitLogData.ts
* Fix git log refresh marker not appearing in CI
- Move git-log-refreshed marker before RAF to ensure it's recorded
- RAF callbacks may not execute reliably in headless CI environments
- Add debug logging to track loadGitLog execution
- Add try-catch around log call to catch any errors
- Keep git-log-data-rendered in useEffect for UI tracking
* Update useGitLogData.ts
* Update useGitLogData.ts
* Add comprehensive logging to diagnose git-log-refreshed issue
- Log before RAF and inside RAF to pinpoint exact failure location
- Add try-catch to capture any errors
- Two log markers: before-raf and in-raf
- This will definitively show where the logging fails in CI
* Fix race condition: prevent concurrent loadGitLog calls
Root cause: commit triggers 2 refreshes (gitStateChange$ + handleCommitSuccess)
- First loadGitLog (refreshTrigger=1) succeeds
- Second loadGitLog (refreshTrigger=2) starts but never completes
- Add loadGitLogInProgress guard to prevent concurrent execution
- Log when loadGitLog is skipped due to in-progress call
This ensures git-log-refreshed is always logged after commit.
* Remove redundant triggerRefresh calls causing race condition
- handleCommitSuccess/Revert/Undo no longer call triggerRefresh
- gitStateChange\$ observable already triggers refresh for these operations
- Redundant calls caused 2 concurrent loadGitLog, causing CI test failures
- Local tests passed because both completed; CI failed because 2nd never completed
This ensures only 1 loadGitLog runs per git operation.
* Remove unused triggerRefresh parameter from useCommitSelection
- triggerRefresh no longer used in handlers
- Remove from interface and call site
- Clean up lint errors
* Remove triggerRefresh completely - no longer needed
- Observable subscription handles all git state changes
- Remove function definition and exports
- Fix all lint errors
Root cause resolved: commit triggered double refresh causing race condition.
Now only single refresh via observable.
* Remove fixed time waits from gitLog.feature and fix race condition
- Remove all fixed time wait steps from gitLog.feature (14 instances)
- Remove redundant triggerRefresh calls in handleCommitSuccess/Revert/Undo
- Add loadGitLogInProgress guard to prevent concurrent loadGitLog
- Root cause: commit triggered 2 refreshes causing race condition
- Only gitStateChange\$ observable now triggers refresh
- All 4 gitLog tests pass locally
* Fix clear timing: clear log BEFORE commit, not after
Root cause: test cleared git-log-refreshed AFTER commit completed
- But commit already triggered refresh and logged git-log-refreshed
- Clear deleted it, then test waited for new log that would never come
- Solution: clear BEFORE clicking commit button
- This way commit's git-log-refreshed is the first one after clear
Test now passes locally.
* Update cleanup.ts
* Initial commit when init a new git.
* Refactor feature steps for multi-element and log marker tables
Updated multiple feature files and step definitions to support table-driven steps for clicking and asserting multiple elements, and for waiting for multiple log markers in sequence. This reduces redundant waits, improves test reliability, and streamlines Gherkin syntax for multi-element actions and assertions. Also removed unnecessary manual wait steps where content or element checks now handle waiting automatically.
* Minor code cleanup and formatting improvements
Reordered imports in browserView.ts, fixed whitespace in cleanup.ts and useGitLogData.ts, and improved line formatting in GitLog/index.tsx for better readability and consistency.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: tidgi <tiddlygit@gmail.com>
140 lines
9.9 KiB
Gherkin
140 lines
9.9 KiB
Gherkin
@tidgi-mini-window
|
|
Feature: TidGi Mini Window Workspace Switching
|
|
As a user with tidgi mini window already enabled
|
|
I want to test tidgi mini window behavior with different workspace configurations
|
|
So that I can verify workspace switching and fixed workspace features
|
|
|
|
Background:
|
|
Given I configure tidgi mini window with shortcut
|
|
Given I cleanup test wiki so it could create a new one on start
|
|
Then I launch the TidGi application
|
|
And I wait for the page to load completely
|
|
Then I switch to "main" window
|
|
# Wait for application initialization to complete
|
|
Then I wait for log markers:
|
|
| description | marker |
|
|
| git init complete | [test-id-git-init-complete] |
|
|
| wiki worker started | [test-id-WIKI_WORKER_STARTED] |
|
|
| all workspace views initialized | [test-id-ALL_WORKSPACE_VIEW_INITIALIZED] |
|
|
|
|
Scenario: TidGi mini window syncs with main window switching to agent workspace
|
|
# Switch main window to agent workspace
|
|
When I click on an "agent workspace button" element with selector "[data-testid='workspace-agent']"
|
|
# Verify tidgi mini window exists in background (created but not visible)
|
|
Then I wait for "tidgi mini window created" log marker "[test-id-TIDGI_MINI_WINDOW_CREATED]"
|
|
Then I confirm the "tidgiMiniWindow" window exists
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I confirm the "tidgiMiniWindow" window browser view is not positioned within visible window bounds
|
|
Then I switch to "tidgiMiniWindow" window
|
|
# In sync mode, browser view shows the current active workspace (agent), sidebar is hidden
|
|
And I should see a "new tab button" element with selector "[data-tab-id='new-tab-button']"
|
|
|
|
Scenario: TidGi mini window with fixed agent workspace shows no view and fixed wiki workspace shows browser view
|
|
# Configure fixed agent workspace through UI
|
|
And I click on an "open preferences button" element with selector "#open-preferences-button"
|
|
And I switch to "preferences" window
|
|
When I click on "tidgi mini window section and disable sync workspace switch and enable sidebar toggle" elements with selectors:
|
|
| element description | selector |
|
|
| tidgi mini window section | [data-testid='preference-section-tidgiMiniWindow'] |
|
|
| disable sync workspace switch | [data-testid='tidgi-mini-window-sync-workspace-switch'] |
|
|
| enable sidebar toggle switch | [data-testid='sidebar-on-tidgi-mini-window-switch'] |
|
|
# Select agent workspace (which is a page type workspace)
|
|
And I select "agent" from MUI Select with test id "tidgi-mini-window-fixed-workspace-select"
|
|
# Open tidgi mini window - should show agent workspace and no browser view
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I confirm the "tidgiMiniWindow" window browser view is not positioned within visible window bounds
|
|
Then I switch to "tidgiMiniWindow" window
|
|
# Verify sidebar is visible and agent workspace is active
|
|
And I should see "main sidebar and agent workspace active button" elements with selectors:
|
|
| element description | selector |
|
|
| main sidebar | [data-testid='main-sidebar'] |
|
|
| agent workspace active button | [data-testid='workspace-agent'][data-active='true'] |
|
|
# Close tidgi mini window and switch to wiki workspace
|
|
Then I switch to "preferences" window
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
# Get the first wiki workspace ID and select it
|
|
And I select "wiki" from MUI Select with test id "tidgi-mini-window-fixed-workspace-select"
|
|
# Clear previous occurrences of the log marker before waiting for a new one
|
|
And I clear log lines containing "[test-id-TIDGI_MINI_WINDOW_SHOWN]"
|
|
# Open tidgi mini window again - should show wiki workspace with browser view
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
# Wait for the view to be loaded and window to be shown
|
|
Then I wait for "tidgi mini window shown" log marker "[test-id-TIDGI_MINI_WINDOW_SHOWN]"
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I confirm the "tidgiMiniWindow" window browser view is positioned within visible window bounds
|
|
Then I switch to "tidgiMiniWindow" window
|
|
# Verify sidebar is visible
|
|
And I should see a "main sidebar" element with selector "[data-testid='main-sidebar']"
|
|
# Verify browser view content is visible and wiki workspace is active
|
|
And I should see "我的 TiddlyWiki" in the browser view content
|
|
And I should see a "wiki workspace active button" element with selector "[data-active='true']"
|
|
|
|
Scenario: Enabling sync workspace automatically hides sidebar
|
|
# Configure tidgi mini window with fixed workspace first
|
|
When I click on "agent workspace button and open preferences button" elements with selectors:
|
|
| element description | selector |
|
|
| agent workspace button | [data-testid='workspace-agent'] |
|
|
| open preferences button | #open-preferences-button |
|
|
And I switch to "preferences" window
|
|
When I click on "tidgi mini window section and disable sync workspace switch and enable sidebar toggle" elements with selectors:
|
|
| element description | selector |
|
|
| tidgi mini window section | [data-testid='preference-section-tidgiMiniWindow'] |
|
|
| disable sync workspace switch | [data-testid='tidgi-mini-window-sync-workspace-switch'] |
|
|
| enable sidebar toggle switch | [data-testid='sidebar-on-tidgi-mini-window-switch'] |
|
|
And I should see a "sidebar toggle switch" element with selector "[data-testid='sidebar-on-tidgi-mini-window-switch']"
|
|
# Open tidgi mini window and verify sidebar is visible
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
# Window confirmation will automatically wait for window to appear
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I switch to "tidgiMiniWindow" window
|
|
And I should see a "main sidebar" element with selector "[data-testid='main-sidebar']"
|
|
# Close mini window and go back to preferences
|
|
Then I switch to "preferences" window
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window not visible
|
|
# Now enable sync workspace - should automatically hide sidebar
|
|
When I click on a "Enable tidgi mini window sync workspace switch" element with selector "[data-testid='tidgi-mini-window-sync-workspace-switch']"
|
|
# Verify sidebar option is now hidden
|
|
And I should not see "sidebar toggle switch and fixed workspace select" elements with selectors:
|
|
| element description | selector |
|
|
| sidebar toggle switch | [data-testid='sidebar-on-tidgi-mini-window-switch'] |
|
|
| fixed workspace select | [data-testid='tidgi-mini-window-fixed-workspace-select'] |
|
|
# Open tidgi mini window in sync mode - should sync to agent workspace
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
And I switch to "tidgiMiniWindow" window
|
|
# In sync mode, sidebar should not be visible (automatically hidden)
|
|
And I should not see a "main sidebar" element with selector "[data-testid='main-sidebar']"
|
|
|
|
Scenario: Clicking workspace button in mini window updates fixed workspace ID
|
|
# First click on guide workspace in main window to set a different active workspace
|
|
Then I switch to "main" window
|
|
When I click on "guide workspace button and open preferences button" elements with selectors:
|
|
| element description | selector |
|
|
| guide workspace button | [data-testid='workspace-guide'] |
|
|
| open preferences button | #open-preferences-button |
|
|
And I switch to "preferences" window
|
|
When I click on "tidgi mini window section and disable sync workspace switch and enable sidebar toggle" elements with selectors:
|
|
| element description | selector |
|
|
| tidgi mini window section | [data-testid='preference-section-tidgiMiniWindow'] |
|
|
| disable sync workspace switch | [data-testid='tidgi-mini-window-sync-workspace-switch'] |
|
|
| enable sidebar toggle switch | [data-testid='sidebar-on-tidgi-mini-window-switch'] |
|
|
# Select agent workspace as fixed workspace
|
|
And I select "agent" from MUI Select with test id "tidgi-mini-window-fixed-workspace-select"
|
|
# Open tidgi mini window
|
|
When I press the key combination "CommandOrControl+Shift+M"
|
|
And I confirm the "tidgiMiniWindow" window visible
|
|
Then I switch to "tidgiMiniWindow" window
|
|
# Verify agent workspace is active initially
|
|
And I should see a "agent workspace button with active state" element with selector "[data-testid='workspace-agent'][data-active='true']"
|
|
# Click on guide workspace button to update fixed workspace ID
|
|
When I click on a "guide workspace button" element with selector "[data-testid='workspace-guide']"
|
|
# Verify guide workspace is now active and agent workspace is no longer active
|
|
And I should see "guide workspace button with active state and agent workspace button without active state" elements with selectors:
|
|
| element description | selector |
|
|
| guide workspace button with active state | [data-testid='workspace-guide'][data-active='true'] |
|
|
| agent workspace button without active state | [data-testid='workspace-agent'][data-active='false'] |
|