3 commits

Author	SHA1	Message	Date
lin onetwo	6384fd8bd1	Fix/misc bug (#677) ... * fix: not removed * Optimize tidgi.config.json writes for workspace updates Update logic to write tidgi.config.json only for the modified workspace instead of all wiki workspaces on each update. This reduces redundant file operations and improves performance during workspace updates. * Refactor workspace saving and UI update logic Introduced a private saveWorkspacesToSettings method to centralize logic for saving workspaces and removing syncable fields from wiki workspaces. The set and setWorkspaces methods now support skipping UI updates for batch operations, improving performance. Fixed minor issues in legacy migration and error messages. * Add 'Ask AI' context menu and wiki embed split view Introduces an 'Ask AI' option to the wiki context menu, enabling users to send selected text to an agent chat in a split view with the wiki embedded. Implements new tab type WIKI_EMBED, updates tab and channel types, adds localization, manages BrowserView bounds for embedding, and ensures persistence and IPC wiring for the new workflow. * Update wiki * electron chrome mcp mode sometimes wont show browser view Clarified troubleshooting steps in docs/MCP.md regarding browser view issues and updated the instructions. Reordered the 'start:dev:mcp' script in package.json for better organization. * Add agent selection to 'Talk with AI' context menu Replaces the 'Ask AI' context menu with 'Talk with AI' and adds a submenu for selecting different agent definitions. Updates translations for all supported languages, modifies the askAIWithSelection channel to support agentDefId, and refactors tab creation logic to support split view with agent selection. Improves robustness in view management by handling case-insensitive workspace IDs and custom bounds logic. * Add e2e test and refactor 'Talk with AI' split view logic Introduces a new Cucumber feature for 'Talk with AI' from wiki selection, adds a step definition to trigger the workflow via IPC, and refactors split view tab creation to reuse existing tabs when possible. Updates the agent browser service to support finding or creating the appropriate split view tab, and adjusts menu and view services for improved robustness and code clarity. Also adds test IDs to relevant components for more reliable UI testing. * Update defaultWiki.feature * Add config error handling and i18n for agent errors Introduces a new feature test for configuration error handling, adds step definition to remove AI settings for testing, and updates error message rendering to support new error types. Internationalized error messages and button labels for configuration issues are added in both English and Chinese locales. The error message renderer now uses a data-testid for easier testing and recognizes additional error types as fixable in settings. * Refactor feature files to use two-column selector tables Updated all feature files to use a standardized two-column format for selector tables, with explicit 'element description' and 'selector' columns. Step definitions in ui.ts were refactored to support this format, improving readability and maintainability of test steps and error handling. * Delete tiddlywiki * test: allow parallel * test: implement scenario isolation for E2E tests - Isolate each test scenario in test-artifacts/{scenarioSlug}/ directory - Use dynamic ports for mock OpenAI server to avoid port conflicts - Log VIEW_LOADED event via did-finish-load in main process (more reliable) - Search all .log files when waiting for log markers - Increase timeout for log marker steps to 15 seconds - Fix ts-node cache issues by clearing cache before tests - Move application launch to individual scenarios (required for mock server setup) All 45 E2E test scenarios now pass consistently. * refactor: optimize agent.feature by moving common steps to Background - Add MockOpenAIServer.addRules() method to append responses dynamically - Add 'I have started the mock OpenAI server without rules' step for Background - Add 'I add mock OpenAI responses:' step to inject responses per scenario - Move application launch and navigation to Background (shared by all scenarios) - Keep scenario-specific mock responses in individual scenarios This improves test maintainability by reducing duplication while keeping scenario-specific configuration flexible. * lint * Refactor scenario path helpers into shared module Moved scenario-specific path helper functions from individual step definition files to a centralized 'features/supports/paths.ts' module. Updated imports in step definitions to use the shared helpers, improving code reuse and maintainability. Also enhanced test for ContextService to skip optional runtime keys. * Refactor slug generation to use shared slugify helper Introduced a new src/helpers/slugify.ts utility for consistent slug generation across the codebase. Updated appPaths.ts to use the shared slugify function, improving maintainability and ensuring identical behavior for test scenario slugs. Added documentation and clarified slugification rules in relevant files. Minor comments and clarifications were added to E2E and mock server code. * Enforce strict timeout rules in E2E test steps Added and clarified critical warnings for AI agents regarding timeout modifications in application, cleanup, and wiki step definitions. All timeouts are now strictly limited to 5s local and 10s CI, with explicit comments and environment-based values. Updated documentation and code comments to reinforce that timeouts indicate real bugs and should not be increased. * Update features/stepDefinitions/application.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor E2E helpers, improve test reliability and cleanup Centralizes data table parsing for UI step definitions, refactors mock OpenAI server setup, and improves workspace settings path handling for tests. Adjusts timeouts for window and app closing to better reflect real-world performance. Fixes type usage in workspace ID lookups and adds error handling for resize observer and cleanup in WikiEmbedTabContent. Enhances agent browser tab logic and view service cleanup to prevent memory leaks and catch workspace ID casing issues. * Update agent.ts * fix: resolve all E2E test timeout issues * fix: improve CI test reliability with better timing and cleanup - Use exponential-backoff library for agent creation retry logic - Extend agent cancel delay to 1000ms for CI environments - Fix git log refresh marker timing with queueMicrotask - Improve cleanup timeout handling with force close strategy All E2E tests passing locally including previously failing CI tests. * Improve Git log E2E signal and add debug logging Renames the test artifact in the CI workflow for clarity. Moves the E2E test timing log in useGitLogData to after entries are rendered, using a more reliable signal. Adds a debug log to notifyGitStateChange for better traceability. * test-artifacts-ci * Optimize test artifact handling and Git log logging Update CI workflow to clean up large cache folders in test artifacts and only upload logs, settings, and screenshots to reduce artifact size. Refactor useGitLogData to log immediately after state updates for improved E2E test reliability, removing unnecessary setTimeout. * Update useGitLogData.ts * Improve Git log E2E test logging and .gitignore Added 'test-artifacts-ci.zip' to .gitignore. Moved the '[test-id-git-log-refreshed]' log to immediately after data load for more reliable E2E test detection, and removed redundant logging from the render effect in useGitLogData.ts. * Update useGitLogData.ts * Update useGitLogData.ts * Fix git log refresh marker not appearing in CI - Move git-log-refreshed marker before RAF to ensure it's recorded - RAF callbacks may not execute reliably in headless CI environments - Add debug logging to track loadGitLog execution - Add try-catch around log call to catch any errors - Keep git-log-data-rendered in useEffect for UI tracking * Update useGitLogData.ts * Update useGitLogData.ts * Add comprehensive logging to diagnose git-log-refreshed issue - Log before RAF and inside RAF to pinpoint exact failure location - Add try-catch to capture any errors - Two log markers: before-raf and in-raf - This will definitively show where the logging fails in CI * Fix race condition: prevent concurrent loadGitLog calls Root cause: commit triggers 2 refreshes (gitStateChange$ + handleCommitSuccess) - First loadGitLog (refreshTrigger=1) succeeds - Second loadGitLog (refreshTrigger=2) starts but never completes - Add loadGitLogInProgress guard to prevent concurrent execution - Log when loadGitLog is skipped due to in-progress call This ensures git-log-refreshed is always logged after commit. * Remove redundant triggerRefresh calls causing race condition - handleCommitSuccess/Revert/Undo no longer call triggerRefresh - gitStateChange\$ observable already triggers refresh for these operations - Redundant calls caused 2 concurrent loadGitLog, causing CI test failures - Local tests passed because both completed; CI failed because 2nd never completed This ensures only 1 loadGitLog runs per git operation. * Remove unused triggerRefresh parameter from useCommitSelection - triggerRefresh no longer used in handlers - Remove from interface and call site - Clean up lint errors * Remove triggerRefresh completely - no longer needed - Observable subscription handles all git state changes - Remove function definition and exports - Fix all lint errors Root cause resolved: commit triggered double refresh causing race condition. Now only single refresh via observable. * Remove fixed time waits from gitLog.feature and fix race condition - Remove all fixed time wait steps from gitLog.feature (14 instances) - Remove redundant triggerRefresh calls in handleCommitSuccess/Revert/Undo - Add loadGitLogInProgress guard to prevent concurrent loadGitLog - Root cause: commit triggered 2 refreshes causing race condition - Only gitStateChange\$ observable now triggers refresh - All 4 gitLog tests pass locally * Fix clear timing: clear log BEFORE commit, not after Root cause: test cleared git-log-refreshed AFTER commit completed - But commit already triggered refresh and logged git-log-refreshed - Clear deleted it, then test waited for new log that would never come - Solution: clear BEFORE clicking commit button - This way commit's git-log-refreshed is the first one after clear Test now passes locally. * Update cleanup.ts * Initial commit when init a new git. * Refactor feature steps for multi-element and log marker tables Updated multiple feature files and step definitions to support table-driven steps for clicking and asserting multiple elements, and for waiting for multiple log markers in sequence. This reduces redundant waits, improves test reliability, and streamlines Gherkin syntax for multi-element actions and assertions. Also removed unnecessary manual wait steps where content or element checks now handle waiting automatically. * Minor code cleanup and formatting improvements Reordered imports in browserView.ts, fixed whitespace in cleanup.ts and useGitLogData.ts, and improved line formatting in GitLog/index.tsx for better readability and consistency. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: tidgi <tiddlygit@gmail.com>	2026-01-20 11:11:28 +08:00
lin onetwo	7edb132d32	Fix/watch fs and ai commit (#674) ... * fix: missing return * feat: showApiKey * feat: undo commit * feat: amend commit * fix: file name quoted in git log * fix: wikiWorkspaceDefaultValues * fix: no ai commit message sometimes * Persist only non-default preferences to storage Added a utility to store only preferences that differ from defaults, reducing storage size and improving config readability. Updated the setPreferences method to use this utility before saving preferences. * fix: External Attachment Handling in fs plugin instead of ext-attachment-plugin to handle direct tag update case which won't trigger th-saving-tiddler hook * feat: api for plugin to create base64 file * Show all untracked files and recreate Git history window Updated git status commands to use '-uall' for displaying all untracked files, not just directories. Modified windowService.open calls for Git history to include the { recreate: true } option, ensuring the window is refreshed when opened from various menus. * fix: handling of external attachments with _canonical_uri Ensure tiddlers with _canonical_uri are always saved as .tid files, not as binary files, by forcing the .tid extension in FileSystemAdaptor. Update tests to verify this behavior. Also, skip loading files from the external attachments folder in loadWikiTiddlersWithSubWikis to prevent them from being loaded as separate tiddlers. * Refactor external attachment utilities to module exports Refactored externalAttachmentUtilities to use ES module exports instead of attaching functions to $tw.utils. Updated imports and mocks accordingly, removed related type definitions from ExtendedUtilities, and cleaned up obsolete meta file. * disable enableFileSystemWatch to prevent bug for innocent users * fix: test that requires enableFileSystemWatch use new step set to true * Fix extension filter usage and sync workspace state after save Refactored variable naming for extension filters in FileSystemAdaptor to improve clarity and fixed their usage in generateTiddlerFileInfo calls. Removed an unused import in routingUtilities.type.ts. Added a useEffect in useForm to sync workspace state with originalWorkspace after save, ensuring the save button disappears as expected. * fix: review * lint * feat: unify AI commit entry points and add availability check - Unified all AI commit message generation to use syncService.syncWikiIfNeeded() for consistent business logic handling - Added externalAPI.isAIAvailable() method to check if AI provider and model are properly configured - Updated gitService.isAIGenerateBackupTitleEnabled() to use the new availability check - Removed redundant logging code since generateFromAI() automatically logs to database when externalAPIDebug is enabled - Simplified menu item creation logic in menuItems.ts - Ensured AI menu options only appear when both API credentials and free model are configured - Updated documentation to reflect the unified architecture * Improve AI commit message diff filtering and API checks Renamed the AI commit message entry points doc for clarity. Enhanced the AI availability check to better handle provider API key requirements, including support for providers that do not require keys. Improved plugin diff filtering to retain small config file diffs while omitting large plugin file contents, optimizing AI token usage. * Update wiki * Refactor and enhance Tidgi mini window initialization and sync Refactors Tidgi mini window startup to use a new initializeTidgiMiniWindow method, improving workspace selection logic and view management. Adds concurrency locks to prevent race conditions during open/close operations. Enhances workspace sync/fixed mode handling, view cleanup, and error logging. Updates interfaces and utilities to support new behaviors and improves robustness of tray icon creation and view realignment. * Refactor file system sync to use $tw.syncer.syncFromServer() Introduces FileSystemWatcher to monitor file changes and collect updates for the syncer, replacing direct wiki updates in WatchFileSystemAdaptor. Updates documentation to describe the new syncer-driven architecture, echo prevention, and event handling. WatchFileSystemAdaptor now delegates file change detection and lazy loading to FileSystemWatcher, improving batch change handling and eliminating echo loops. * Improve logging and cleanup in file system watcher and git ops Added detailed logging to WatchFileSystemAdaptor and FileSystemWatcher for better traceability during initialization and test stabilization. Introduced a constant for the temporary git index prefix in gitOperations. Removed the unused comparison.ts utility for tiddler comparison. Enhanced comments and logging for AI commit message generation context. * Improve GitLog i18n test and config refresh logic Updated gitLog.feature to use only Chinese selectors for actions, revert, and discard buttons, improving i18n test reliability. In FileSystemWatcher, re-fetch workspace config before checking enableFileSystemWatch to ensure latest settings are respected. In useGitLogData, prevent file-change events from overriding commit/undo events to maintain correct auto-selection behavior. * Improve Git log selection and test stability Refines auto-selection logic in the Git log window to better handle uncommitted changes, commits, reverts, and undos. Updates the feature test to explicitly verify selection and UI state after each operation, improving reliability. Removes unnecessary config re-fetch in FileSystemWatcher and enhances logging for more accurate DOM update detection. * Implement workspace config sync via tidgi.config.json Adds support for syncing workspace configuration to tidgi.config.json in the wiki folder, enabling settings persistence and migration across devices. Introduces new documentation, feature tests, and supporting utilities for config file reading, writing, migration, and validation. Updates step definitions and test helpers to support config sync scenarios, and refactors database config utilities for modularity. * Improve workspace config handling and sync logic Enhances workspace lookup in step definitions to check both settings.json and tidgi.config.json, ensuring properties are found even if moved. Updates tidgiConfig write logic to remove the config file if all values are default. Refactors workspace save logic to always write syncable config to tidgi.config.json for all wiki workspaces before removing those fields from settings.json, preventing config loss. * Update .gitignore * Update wiki.ts * Add delay before waiting for git log render after revert - Add 1 second wait after clearing git-log-data-rendered markers following revert - This gives UI time to start refreshing before we check for the new marker - Fixes CI timing issue where revert operation needs more time to trigger UI refresh * Update test log markers for git log refresh events Replaces '[test-id-git-log-data-rendered]' with '[test-id-git-log-refreshed]' in gitLog.feature to better reflect UI refresh events after commit and revert actions. Adds a debug log marker '[test-id-git-revert-complete]' in revertCommit for improved test synchronization. * Fix git revert refresh timing - remove intermediate step and rely on git-log-refreshed * Add detailed logging to handleRevert for CI debugging * Fix git log refresh by adding manual triggerRefresh fallback - Add triggerRefresh function to useGitLogData hook for manual refresh - Call triggerRefresh in handleCommitSuccess, handleRevertSuccess, and handleUndoSuccess - This fixes cross-process IPC observable subscription issues where gitStateChange$ notifications from main process may not reach renderer process reliably - Add detailed logging to handleRevert for CI debugging * Update index.tsx	2026-01-10 23:57:59 +08:00
lin onetwo	b4ebaa66df	Fix/menu sync (#659) ... * fix: sync not config remote * fix: git worker no log * Update src/services/git/registerMenu.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update menuItems.ts --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-11-25 00:10:19 +08:00