Commit graph

2 commits

Author SHA1 Message Date
lin onetwo
64cc965a4a
Feat/discuss note with agent (#685)
* Add wiki tiddler attachment support to agent chat

Implements the ability to attach wiki tiddlers to agent chat messages. Updates the UI to allow selection of tiddlers from active wiki workspaces, fetches and renders tiddler content as plain text, and appends it to the user message sent to the AI. Includes e2e tests, updates to store actions, service interfaces, and prompt concatenation logic to support this feature.

* fix: callback not useCallback cause autocomplete panel flash

* Add wiki tiddler attachments to message bubbles

Message bubbles now display attached wiki tiddlers as clickable chips, allowing users to navigate directly to the referenced tiddler in the appropriate workspace. Metadata handling and persistence for wiki tiddlers has been updated to include workspaceId, and tests have been added to verify the new UI behavior. The chat view also now closes the TiddlyWiki sidebar for better focus when navigating from a selection.

* Support split view navigation for wiki tiddler attachments

Adds isSplitView prop to ChatTabContent and related components to distinguish between split view and normal tab modes. Wiki tiddler attachment navigation now uses a different strategy in split view, opening tiddlers directly in the browser view. Updates types and tests to reflect the new behavior, and improves robustness of response handling in several places.

* docs: move to .github/instructions/testing.instructions.md

* test: view loading slow on mac

* refactor(e2e): move wiki load steps to Background in talkWithAI.feature; remove all sidebar close delays and polling, only set state when TiddlyWiki is ready; clean up code and logs for sidebar auto-close in split view

* docs: make test inst shorter

* lint

* refactor(view): slim ViewService, move menu to separate file, orchestrate view logic in WorkspaceViewService, update all callers, fix lint floating promise, all unit and e2e tests pass

* fix: add data-testid to attachment listbox for E2E test

- Add slotProps to MUI Autocomplete to ensure attachment-listbox is rendered with correct test-id
- Fix E2E test timeout when waiting for attachment listbox element

* lint

* put 'Talk with AI' menu on top and attachment i18n

Introduce a reusable createTalkWithAIMenuItems helper to build "Talk with AI" menu entries (default agent + other agents submenu) and integrate it into workspace menu generation. Add new i18n keys for Agent.Attachment and WikiEmbed across locales and update UI to use translation keys (remove hardcoded fallback strings). Improve chat input/attachment behavior: expose a test-id for the attachment listbox, use i18n for labels/placeholders, and tweak input component wiring. Fix Cucumber step handling by normalizing expected newline sequences and safely handling empty message content. Also adjust memo deps in SortableWorkspaceSelectorButton to include id.

* feat: enhance AI interaction in workspace context menu with local trigger support

* feat: add tool approval and timeout settings

- Introduced ToolApprovalConfig and related types for managing tool execution approvals.
- Implemented WebFetch and ZxScript tools for fetching web content and executing scripts, respectively.
- Added token estimation utilities for context window management.
- Enhanced ModelInfo interface with context window size and max output tokens.
- Created API Retry Utility for handling transient failures with exponential backoff.
- Updated AIAgent preferences section to include Tool Approval & Timeout Settings dialog.
- Developed ToolApprovalSettingsDialog for configuring tool-specific approval rules and retry settings.
- Modified vitest configuration to support aliasing for easier imports and stubbing.

* Refactor agent instance tools and services for improved modularity and maintainability

- Extracted type definitions and tool registry from defineTool.ts into separate files (defineToolTypes.ts, toolRegistry.ts) to reduce file size and enhance importability.
- Implemented a retry mechanism in ExternalAPIService for stream creation to handle transient failures.
- Updated ToolApprovalSettingsDialog to persist settings using localStorage instead of a preference service.
- Created agentMessagePersistence.ts and agentRepository.ts to manage agent message and instance CRUD operations, reducing the size of AgentInstanceService.
- Added a progress tracker document (AgentTODO.md) for the ongoing enhancement plan of the TidGi Agent.

* feat: add AgentSwitcher component for agent definition switching

- Implemented AgentSwitcher component with dropdown functionality for selecting agent definitions.
- Integrated loading of agent definitions on dropdown open.
- Added visual feedback for current selection and disabled state.

feat: create ToolResultRenderer for generic tool result messages

- Developed ToolResultRenderer to handle rendering of <functions_result> messages.
- Included collapsible parameters and result display with error handling.
- Added truncation for long results in collapsed view.

test: add comprehensive tests for MessageRenderer components

- Implemented tests for AskQuestionRenderer, ToolResultRenderer, ToolApprovalRenderer, and BaseMessageRenderer.
- Ensured proper rendering and functionality for various message types and states.
- Included pattern routing tests for MessageRenderer.

feat: introduce TurnActionBar for action management in agent turns

- Created TurnActionBar component for managing actions like rollback, retry, delete, and copy.
- Integrated visual feedback for file changes and rollback status.
- Added functionality for copying agent responses and full conversation to clipboard.

feat: implement askQuestionPending for managing user responses

- Developed infrastructure for handling pending ask-question requests.
- Implemented promise-based blocking until user responds to agent questions.
- Added timeout handling for ask-question requests.

* feat: Implement background task management for agent instances

- Added functionality to restore heartbeat timers and alarms for active agents upon service initialization.
- Introduced methods to retrieve active background tasks and cancel them via the UI.
- Enhanced alarm clock tool to persist alarm data in the database, ensuring alarms survive app restarts.
- Updated agent instance schema to include scheduled alarm data.
- Modified prompt concatenation logic to support context window size for message history.
- Removed system prompt parameter from model parameters schema and related components.
- Improved UI to display and manage background tasks, including heartbeat and alarm details.

* feat: Implement Scheduled Tasks Management and Background Task Settings

- Add feature for managing scheduled tasks for agents, including viewing, adding, and editing tasks.
- Create tests for agent repository and background task settings APIs.
- Introduce ScheduledTaskManager for unified scheduling of tasks with interval, at, and cron schedules.
- Implement edit-agent-definition tool for modifying agent configurations, including heartbeat and prompt settings.
- Ensure tasks persist across app restarts and respect active hours filtering.

* Update wiki

* fix(security): harden htmlToText against XSS via encoded tags

- Use tolerant script/style regex that handles </script > with spaces
- Stop decoding &lt;/&gt; entities to prevent reintroducing HTML tags
- Decode &amp; last to avoid double-unescaping (&amp;lt;  &lt;  <)
- Fixes all 4 CodeQL findings (bad filtering, incomplete sanitization,
  double escaping, incomplete multi-character sanitization)

* fix: lint and format errors (eslint naming, dprint formatting, stub classes)

* fix: exclude tidgi.config.json from template copy and fix log marker pattern

- Skip tidgi.config.json when copying wiki template to prevent overriding workspace name
- Change waitForLogMarker default pattern from 'wiki-' to '*' to match actual log filenames
- Filter tidgi.config.json in e2e step too (fs.copy in wiki creation step)

* perf(e2e): merge 5 scheduledTask scenarios into 2 to reduce app restarts

* perf(e2e): merge crossWindowSync and streamingStatus scenarios to reduce CI time

* ci: increase test timeout to 20min for larger e2e scenario count

* perf(e2e): merge agent scenarios and enable parallel on CI

- Merge agent.feature wiki-search + wiki-operation into one scenario
- Merge agent.feature create-agent-from-newtab + create-agent-from-fallback into one
- Enable cucumber parallel: 2 on CI (7GB RAM, dynamic ports for mock servers)
- Total scenarios: 66 -> 61

* fix: cleanup MCP client processes when deleting or closing agent

* ci: disable parallel (CPU contention), increase timeout to 30min for 61 scenarios

* perf(e2e): merge 3 preference background-task scenarios into 1, increase timeout to 45min

- Preference alarm/heartbeat CRUD merged into single scenario (saves 2 app restarts)
- Total scenarios: 59 (was 66)
- CI timeout 45min for the expanded e2e suite

* fix: restructure e2e scenarios, fix subscription leak and debounce cleanup

- Restructure agent/talkWithAI/streamingStatus feature files for reliability
- Fix talkWithAI scenarios missing mock server startup and app launch
- Remove duplicate subscription in handleSwitchAgent (useEffect already handles it)
- Clean up debounced update functions when agent is deleted/closed
- Use agentId:messageId key for debounced functions to enable per-agent cleanup

* fix(e2e): remove :last-child selectors broken by TurnActionBar, fix tab/dialog selectors, increase CI timeout to 25min

* fix: use const for non-reassigned variable (lint)

* fix(e2e): fix close-all-tabs opacity issue, scheduledTask undefined steps, MUI multiline textarea targeting

* fix(e2e): use tab-list-dropdown to close all tabs, fix selector for actual TabListDropdown component

* fix(e2e): add timing waits for BrowserView repositioning and git log UI refresh

* fix(e2e): make 'should not see' step wait for element to disappear instead of instant check

* fix(e2e): increase executeInBrowserView default timeout from 500ms to 2000ms
2026-03-09 04:07:39 +08:00
lin onetwo
fa9751e5ea
Feat/Native AI Agent (#640)
* refactor: only use message id

* feat: stream update, but react don't react on it dny

* feat: start stop

* feat: basic resoponse handlers

* feat: load handler config schema

* chore: upgrade to "moduleResolution": "bundler"

* fix: prompt concat

* feat: rjfs with mui

* fix: mui v7 upgrade

* fix: field editor tabs

* feat: Description field is i18n key, use i18nAlly extension to see it on VSCode. And use react-i18next to translate it on frontend.

* refactor: extract some shared components

* refactor: remove @mui/lab

* feat: faster editor

* feat: beautify editor

* refactor: better style

* fix: fullscreen style

* fix: array sort

* fix: editor not saved

* fix: broken array

* chore: upgrade mui deps

* Update type.d.ts

* feat: upgrade and install react dev tools

* refactor: simplify the code

* refactor: simplify the code

* refactor: simplify ai generated garbage code

* fix: translated label

* feat: translate enum and conditional show field based on enum

* feat: click to open source

* fix: ai generated garbage code to solve id and index problem

* refactor: simplify

* refactor: shorten

* test: add jest

* chore: node-linker=hoisted as electron forge suggested

* test: e2e

* fix: test failed on ci

* test: faster by disable some typecheck

* fix: ci

* fix: ci

* refactor: remove unused

* fix: use macos and take screenshot in ci

* docs:

(cherry picked from commit b1a9706264)

* fix: ci crash due to no dugite binary, due to NODE_ENV=test not set

* Update test.yml

* fix: ci

* Update release.yml

* docs: test

* refactor: move folders and lint

* refactor: organize pages to reduce level

* refactor: merge page service and workspace service to allow drag & drop of pages

* Update ipc-syncadaptor.ts

* Update browserViewMetaData.ts

* fix: view.webContents.loadURL won't reload on new electron version

* fix: try to disable annoying useless disabling pasting "feature"

https://github.com/electron/electron/issues/40995

* fix: initial page

* feat: allow sort add icon

* test: use vitest instead

* refactor: use emotion instead

* fix: all ts error after migrate to vitest and emotion

* fix: Component selectors can only be used in conjunction with @emotion/babel-plugin, the swc Emotion plugin, or another Emotion-aware compiler transform.

fix by not using this usage

* fix: too many open files

* test: add basic main page test

* refactor: split workspace type to make it more specific

* test: support mock react lazy import component by re-export them

* test: sidebar

* refactor: move mock to global

* test: testing library fix

* test: new wiki form

* docs: test with vitest

* lint: fix

* docs: pronounication & remove toc as gh build in

* feat: tools and rag

* feat: prompt for build-in tools

* fix: i18n

* fix: tool using

* test: fix

* refactor: Auto-create default wiki workspace if none exists (handled in backend)

* fix: create wiki workspace so it is on first one

* refactor: remove some useless feature

* refactor: use plugin instead of handler

* chore: make concatPrompt async iterator

* feat: show progress on frontend

* fix: errors

* fix: ConfigError: Config (unnamed): Key "overrides": This appears to be in eslintrc format rather than flat config format.

* Update package.json

* feat: allow windows to hide titlebar

* fix: logger error when ctrl+c on mac

* lint

* refactor: use plugin everywhere

* refactor: move more logic to plugin

* refactor: run tool in plugin, simplify abstraction

* refactor: remove ai generated duplicate

* refactor

* refactor: less plugins

* test: simplify wiki search test

* test: remove any

* fix: not streaming, tool order wrong

* test: plugin system and streaming

* refactor: remove useless auto reply plugin

* fix: hide duration expired tool calling message, so long tool result only show to ai once

* fix: $ props should lower cased

* test: support run as electron so can use sqlite3 compiled bin for electron

* docs: better electron as node run and doc

* test: restore to use threads instead of fock. Seems this also works for inmemory database

* test: fix frontend ui test

* lint: ai content

* test: fix coverage

* test: Refactor test mocks to dedicated __mocks__ directory

Moved common test mocks from setup-vitest.ts into separate files under src/__tests__/__mocks__ for better organization and maintainability. Updated documentation to reflect the new structure. Removed fileMock.js and updated setup-vitest.ts to import and use the new centralized mocks.

* Update ErrorDuringStart.md

* Update messageManagementPlugin.test.ts

* test: Fix Electron test process cleanup and update test config

Update test:unit script to use cross-env for ELECTRON_RUN_AS_NODE, ensuring child processes inherit the variable and preventing resource leaks. Remove manual process.env setting from vitest.config.ts and add documentation on handling related errors in Testing.md. Also, add 'hanging-process' reporter to Vitest config for improved diagnostics.

* fix: warning in test

* Create AgentInstanceWorkflow.md

* fix: duration bug

* fix: ai not response for tool result

* test: Add agent workflow feature and step definitions

Introduces a new Cucumber feature for agent workflow, including multi-round conversation and tool usage. Adds agent-specific step definitions for message input and chat history validation. Refactors application step definitions for improved selector handling and element interaction. Updates test scripts in package.json to include a preparation step for e2e tests.

* Update application.ts

* test: Add mock OpenAI server and tests

Introduces a MockOpenAIServer for simulating OpenAI chat completions, including tool call and tool result responses. Adds corresponding tests and updates vitest config to include tests in the features directory.

* test: simplify steps

* test: Add separate test userData and wiki folders

Introduces 'userData-test' and 'wiki-test' folders for test environments, updating appPaths, fileNames, and paths constants to distinguish between development and test modes. This helps prevent conflicts when running test and development instances simultaneously.

* Update eslint.config.mjs

@typescript-eslint/no-unnecessary-condition': 'off'

* test: Add data-testid attributes for test automation

Added data-testid attributes to form inputs and buttons in ExternalAPI components to improve test automation reliability. Updated feature files and step definitions to use these selectors, refined window switching logic, and improved timing for UI interactions. Also exposed isElectronDevelopment and added isMainWindowPage utility for window identification.

* test: fix wront page type by ai written garbage code

* Update application.ts

* Update Testing.md

* fix: no log during e2e test, and error creating wiki blocks other init steps

* test: click agent workspace button, and refactor mock server

* test: mock streamable openai api

* rename

* chore: try esbuild loader, renderer build too slow

* chore: organize webpack

* chore: ignore service code from hot reload

* Update Testing.md

* test: use full agentinstance in test

* chore: webpack error

* Update Testing.md

* chore: remove useless spectron

* test: EsbuildPlugin's `define` doesn't work, it won't set env properly.

* test: e2e mock openai

* lint: disable @typescript-eslint/require-await

* test: Add quick access to create default agent tab

Introduces a 'Create Default Agent' quick access button in the Agent New Tab page, with localization support. Adds utility to close all tabs and create a default agent tab for fallback scenarios, improves test selectors for tab and close actions, and refactors agent chat tab creation logic for consistency and testability.

* feat: remove unuse favorite

* feat: Add wiki operation and workspaces list plugins

Introduces wikiOperationPlugin and workspacesListPlugin for agent instance prompt and response handling. Updates plugin registry, test coverage, and default agent configuration to support wiki workspace listing and wiki note operations (create, update, delete) via tool calls. Refactors wikiSearchPlugin to delegate workspace list injection to workspacesListPlugin.

* Refactor plugin schema system for dynamic registration

Introduces a dynamic plugin schema registry, allowing plugins to register their parameter schemas and metadata at runtime. Refactors prompt concat schema generation to use dynamically registered plugin schemas, removes static plugin schema definitions, and updates all plugin files to export their parameter schemas. Adds new modelContextProtocolPlugin and schemaRegistry modules, and updates plugin initialization to register schemas and metadata. This enables extensibility and type safety for plugin configuration and validation.

* refactor: move PromptConfigForm to inside PromptPreviewDialog

* test: frontent render tool usage info

* test: split file

* test: fix error

* test: wiki operation

* test: remove log and clean up test deps

* Update i18next-electron-fs-backend.ts

* fix: wikiOperationInServer not called due to no message

* test: fix

* test: Refactor agent feature setup and improve mock server URL handling

Moved AI provider and model configuration to a shared setup scenario in agent.feature to avoid redundant steps in each test. Enhanced application.ts to use a fallback localhost URL for MOCK_SERVER_URL when the mock server is not available, improving test reliability.

* Remove retry logic from basicPromptConcatHandler

Eliminated retryCount and maxRetries from basicPromptConcatHandler, simplifying the control flow and removing the retry limit for LLM calls. Logging and yield logic were updated to reflect the removal of retries.

* Update agent.feature

* test: agent and default wiki

* test: refactor wiki cleanup

* Update agent.feature

* Refactor AI settings setup and add preference feature

Moved AI provider and model configuration steps from agent.feature to a new preference.feature file for better separation of concerns. Updated step definitions in agent.ts to improve robustness when reading and writing settings files, including type usage and directory checks.

* test: try debug can't stop bug

* Update Testing.md

* fix: cancel agent not update cancel button

* refactor: update Frontend use `void window.service.native.log` to log to file.

* test: log from renderer test

* feat: add default embedding model config and victor search service and search preference panel

* test: default embedding form and

* test: default agent

* refator: unused tool listing methods

* Refactor test database setup for integration tests

Centralizes in-memory SQLite test database initialization and cleanup in shared utilities for all integration tests. Updates agentDefinition and messageManagementPlugin tests to use the shared test database, improving reliability and reducing code duplication.

* fix: app path wrong in unit test

* feat: externalAPIDebug

* test: embedding service and let db use real in memory one

* test: provide at least one tab for close tab test

* fix: victor db not loaded in new connection

* test: disable hot reload

* Update DeveloperTools.tsx

* feat: tool message & wiki tool schema

* feat: pref to open db

* chore: skip ExternalsPlugin on dev

* fix: APIs doesn't accept 'tool' role, and it won't return anything when API calls

* fix: docs and remove ai fake fix

* refactor: get agent list don't need to have message

* Update basicPromptConcatHandler.failure.test.ts

* Update basicPromptConcatHandler.test.ts

* fix: role wrong cause e2e failed

* test: allow e2e create .db file to check

* feat: create new agent

* feat: getAgentDefinitionTemplatesFromWikis

* fix: Prevent update non-active (hiding) wiki workspace, so it won't pop up to cover other active agent workspace

* fix: Ensure the config change is fully persisted before proceeding

* test: Don't bring up window when running e2e test, otherwise it will annoy the developer who is doing other things.

* feat: Edit existing agent definition workflow

* Update StyledArrayContainer.tsx

* test: prevent mock server hang

* Refactor UI step definitions into separate file

Moved UI-related Cucumber step definitions from application.ts to a new ui.ts file for better separation of concerns and maintainability. application.ts now only contains application-specific logic.

* lint: ai auto fix

* Clean up feature files and improve test coverage

Removed unnecessary blank lines and improved formatting in feature files for better readability. Updated tsconfig to use 'bundler' module resolution. Enhanced EditAgentDefinitionContent test to mock and verify console.error output. Added type annotation for IAgentDefinitionService in basicPromptConcatHandler.failure.test.ts for improved type safety.

* test: simplify message text match

* feat: transcription and image generation model config

* fix: style props error

* chore: remove unused file

* chore: try to imporove dev start speed but no sig improvment

Replaces 'pnpm start' with 'pnpm start:init' for initial setup and documents slow startup in development. Adds a debug Webpack script, disables polling in renderer file watching, and only enables CircularDependencyPlugin in production/CI for faster dev builds. WebpackBar now only shows when DEBUG includes 'electron-forge:*'. ForkTsCheckerWebpackPlugin is now configured for async checks with memory limits and test file exclusion. Updates documentation to reflect these changes.

* docs: why not vite

* refactor: basic vite usage, but wiki worker is not running and view is not showing

* refactor: remove lazy inject so vite works and wiki worker works, wiki in browser view can loads

* Replace electron-squirrel-startup with inline implementation

Added a custom Squirrel event handler in src/helpers/squirrelStartup.ts to handle Windows install/update/uninstall events, replacing the electron-squirrel-startup package. This avoids ESM/CommonJS compatibility issues and simplifies event handling in src/main.ts.

* refactor: vite build and test

* fix: e2e still use dev wiki folder

* fix: provide env

* chore: "tiddlywiki": "5.3.7"

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: missing i18n

* test:  Module did not self-register: '/home/runner/work/TidGi-Desktop/TidGi-Desktop/node_modules/better-sqlite3/build/Release/better_sqlite3.node'.

* feat: i18n

* feat: zh-Hant i18n

* Update test.yml

* feat: zh-Hans in test

* test: i18n

* refactor: ts forge config

* lint: fix

* chore: update wiki

* Update pnpm-lock.yaml

* chore: update github action versions

* Update wiki

* fix: pnpm then node

* fix: Multiple versions of pnpm specified

* Update test.yml

* fix: Failed to take screenshot: page.screenshot: Target page, context or browser has been closed

* chore: CodeQL Action major versions v1 and v2 have been deprecated.

* chore: parallel codeql

* Update test.yml

* fix: i18n test not passing

* test: step screenshot in each folder

* fix: can't unzip, may due to file path

* test: increase timeout in CI

* docs: more log about wiki creation, and add log to criticial path

* Refactor: logging for structured and consistent output

Replaces string-based logger messages with structured logging throughout the codebase, providing function names, error messages, and relevant context as objects. This improves log readability, enables better filtering and searching, and standardizes error and debug reporting across services.

* chore: debug wiki copy

* fix: wiki submodule not cloned

* Revert "test: increase timeout in CI"

This reverts commit eff8583a01.

* test: reduce wait time, because most check already will wait for a while

* test: batch some e2e steps to reduce screenshot count

* Update index.ts

* chore: remove webpack files, use vite plugins

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-10 17:16:56 +08:00