From e8c706d686ea435016d0d63f4538511f1cea95db Mon Sep 17 00:00:00 2001 From: linonetwo Date: Wed, 3 Jan 2024 22:45:47 +0800 Subject: [PATCH] fix: view not properly hide, width: 0 can't hide it, need x: -contentSize[0], --- src/services/view/index.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/services/view/index.ts b/src/services/view/index.ts index 5a243bd7..a8210342 100644 --- a/src/services/view/index.ts +++ b/src/services/view/index.ts @@ -588,8 +588,18 @@ export class View implements IViewService { public async hideView(browserWindow: BrowserWindow): Promise { const view = browserWindow.getBrowserView(); if (view !== null) { - // const contentSize = browserWindow.getContentSize(); - view?.setBounds(await getViewBounds([0, 0], { findInPage: false }, 0, 0)); // hide browserView to show error message or other pages + const contentSize = browserWindow.getContentSize(); + // disable view features + view?.setAutoResize({ horizontal: false, vertical: false }); + view.webContents.stopFindInPage('clearSelection'); + view.webContents.send(WindowChannel.closeFindInPage); + // make view small, hide browserView to show error message or other pages + view?.setBounds({ + x: -contentSize[0], + y: -contentSize[1], + width: 0, + height: 0, + }); } } }