From cf87bf7beffed4348d5dc8f43d1c0abd21bbec1f Mon Sep 17 00:00:00 2001
From: linonetwo <linonetwo012@gmail.com>
Date: Fri, 29 Dec 2023 21:54:22 +0800
Subject: [PATCH] feat: open developer tool detach to prevent overlap

---
 src/services/menu/contextMenu/contextMenuBuilder.ts | 2 +-
 src/services/view/index.ts                          | 2 --
 src/services/workspacesView/index.ts                | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/services/menu/contextMenu/contextMenuBuilder.ts b/src/services/menu/contextMenu/contextMenuBuilder.ts
index b1de5e8a..1a089e68 100644
--- a/src/services/menu/contextMenu/contextMenuBuilder.ts
+++ b/src/services/menu/contextMenu/contextMenuBuilder.ts
@@ -365,7 +365,7 @@ export default class ContextMenuBuilder {
     const inspect = new MenuItem({
       label: this.stringTable.developerTools(),
       click: () => {
-        this.webContents.openDevTools();
+        this.webContents.openDevTools({ mode: 'detach' });
       },
     });
     menu.append(inspect);
diff --git a/src/services/view/index.ts b/src/services/view/index.ts
index 75aedca5..445edd35 100644
--- a/src/services/view/index.ts
+++ b/src/services/view/index.ts
@@ -349,8 +349,6 @@ export class View implements IViewService {
         didFailLoadErrorMessage: null,
         isLoading: true,
       });
-      // DEBUG devTool
-      // view.webContents.openDevTools({ mode: 'detach' });
       await view.webContents.loadURL(urlToLoad);
       logger.debug('loadUrlForView() await loadURL() done');
       const unregisterContextMenu = await this.menuService.initContextMenuForWindowWebContents(view.webContents);
diff --git a/src/services/workspacesView/index.ts b/src/services/workspacesView/index.ts
index f35c40f2..cc3274bf 100644
--- a/src/services/workspacesView/index.ts
+++ b/src/services/workspacesView/index.ts
@@ -258,7 +258,7 @@ export class WorkspaceView implements IWorkspaceViewService {
       {
         label: () => i18n.t('Menu.DeveloperToolsActiveWorkspace'),
         accelerator: 'CmdOrCtrl+Option+I',
-        click: async () => (await this.viewService.getActiveBrowserView())?.webContents?.openDevTools(),
+        click: async () => (await this.viewService.getActiveBrowserView())?.webContents?.openDevTools?.({ mode: 'detach' }),
         enabled: hasWorkspaces,
       },
     ]);