refactor: move some private method out

2025-12-06 02:30:47 -08:00 · 2023-12-30 18:48:15 +08:00 · 2023-12-30 18:48:15 +08:00 · 32485a1bee
commit 32485a1bee
parent 9b6d9a83d7
10 changed files with 658 additions and 554 deletions
--- a/src/services/windows/handleAttachToMenuBar.ts
+++ b/src/services/windows/handleAttachToMenuBar.ts
@ -0,0 +1,147 @@
+import { MENUBAR_ICON_PATH } from '@/constants/paths';
+import { isMac } from '@/helpers/system';
+import { container } from '@services/container';
+import { i18n } from '@services/libs/i18n';
+import { logger } from '@services/libs/log';
+import { IMenuService } from '@services/menu/interface';
+import serviceIdentifier from '@services/serviceIdentifier';
+import { BrowserWindow, BrowserWindowConstructorOptions, Menu, nativeImage, Tray } from 'electron';
+import windowStateKeeper from 'electron-window-state';
+import { debounce, merge as mergeDeep } from 'lodash';
+import { Menubar, menubar } from 'menubar';
+import { IWindowService } from './interface';
+import { WindowNames } from './WindowProperties';
+
+export async function handleAttachToMenuBar(windowConfig: BrowserWindowConstructorOptions, windowWithBrowserViewState: windowStateKeeper.State | undefined): Promise<Menubar> {
+  const menuService = container.get<IMenuService>(serviceIdentifier.MenuService);
+  const windowService = container.get<IWindowService>(serviceIdentifier.Window);
+
+  // setImage after Tray instance is created to avoid
+  // "Segmentation fault (core dumped)" bug on Linux
+  // https://github.com/electron/electron/issues/22137#issuecomment-586105622
+  // https://github.com/atomery/translatium/issues/164
+  const tray = new Tray(nativeImage.createEmpty());
+  // icon template is not supported on Windows & Linux
+  tray.setImage(MENUBAR_ICON_PATH);
+
+  const menuBar = menubar({
+    index: MAIN_WINDOW_WEBPACK_ENTRY,
+    tray,
+    activateWithApp: false,
+    preloadWindow: true,
+    tooltip: i18n.t('Menu.TidGiMenuBar'),
+    browserWindow: mergeDeep(windowConfig, {
+      show: false,
+      minHeight: 100,
+      minWidth: 250,
+    }),
+  });
+
+  menuBar.on('after-create-window', () => {
+    if (menuBar.window !== undefined) {
+      menuBar.window.on('focus', () => {
+        logger.debug('restore window position');
+        if (windowWithBrowserViewState === undefined) {
+          logger.debug('windowWithBrowserViewState is undefined for menuBar');
+        } else {
+          if (menuBar.window === undefined) {
+            logger.debug('menuBar.window is undefined');
+          } else {
+            menuBar.window.setPosition(windowWithBrowserViewState.x, windowWithBrowserViewState.y, false);
+            menuBar.window.setSize(windowWithBrowserViewState.width, windowWithBrowserViewState.height, false);
+          }
+        }
+        const view = menuBar.window?.getBrowserView();
+        if (view?.webContents !== undefined) {
+          view.webContents.focus();
+        }
+      });
+      menuBar.window.removeAllListeners('close');
+      menuBar.window.on('close', (event) => {
+        event.preventDefault();
+        menuBar.hideWindow();
+      });
+    }
+  });
+  // https://github.com/maxogden/menubar/issues/120
+  menuBar.on('after-hide', () => {
+    if (isMac) {
+      menuBar.app.hide();
+    }
+  });
+
+  // manually save window state https://github.com/mawie81/electron-window-state/issues/64
+  const debouncedSaveWindowState = debounce(
+    (event: { sender: BrowserWindow }) => {
+      windowWithBrowserViewState?.saveState(event.sender);
+    },
+    500,
+  );
+  // menubar is hide, not close, so not managed by windowStateKeeper, need to save manually
+  menuBar.window?.on('resize', debouncedSaveWindowState);
+  menuBar.window?.on('move', debouncedSaveWindowState);
+
+  return await new Promise<Menubar>((resolve) => {
+    menuBar.on('ready', async () => {
+      // right on tray icon
+      menuBar.tray.on('right-click', () => {
+        // TODO: restore updater options here
+        const contextMenu = Menu.buildFromTemplate([
+          {
+            label: i18n.t('ContextMenu.OpenTidGi'),
+            click: async () => {
+              await windowService.open(WindowNames.main);
+            },
+          },
+          {
+            label: i18n.t('ContextMenu.OpenTidGiMenuBar'),
+            click: async () => {
+              await menuBar.showWindow();
+            },
+          },
+          {
+            type: 'separator',
+          },
+          {
+            label: i18n.t('ContextMenu.About'),
+            click: async () => {
+              await windowService.open(WindowNames.about);
+            },
+          },
+          { type: 'separator' },
+          {
+            label: i18n.t('ContextMenu.Preferences'),
+            click: async () => {
+              await windowService.open(WindowNames.preferences);
+            },
+          },
+          {
+            label: i18n.t('ContextMenu.Notifications'),
+            click: async () => {
+              await windowService.open(WindowNames.notifications);
+            },
+          },
+          { type: 'separator' },
+          {
+            label: i18n.t('ContextMenu.Quit'),
+            click: () => {
+              menuBar.app.quit();
+            },
+          },
+        ]);
+
+        menuBar.tray.popUpContextMenu(contextMenu);
+      });
+
+      // right click on window content
+      if (menuBar.window?.webContents !== undefined) {
+        const unregisterContextMenu = await menuService.initContextMenuForWindowWebContents(menuBar.window.webContents);
+        menuBar.on('after-close', () => {
+          unregisterContextMenu();
+        });
+      }
+
+      resolve(menuBar);
+    });
+  });
+}