From f44fd46ca7922ba13a77bcf7d7f4e013cd521dbc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 8 Dec 2022 23:31:56 +0000 Subject: [PATCH 01/13] Build(deps): Bump decode-uri-component from 0.2.0 to 0.2.2 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index 4bab050..e72fd37 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1014,9 +1014,9 @@ debug@^4.1.0, debug@^4.1.1: ms "2.1.2" decode-uri-component@^0.2.0: - version "0.2.0" - resolved "https://registry.yarnpkg.com/decode-uri-component/-/decode-uri-component-0.2.0.tgz#eb3913333458775cb84cd1a1fae062106bb87545" - integrity sha512-hjf+xovcEn31w/EUYdTXQh/8smFL/dzYjohQGEIgjyNavaJfBY2p5F527Bo1VPATxv0VYTUC2bOcXvqFwk78Og== + version "0.2.2" + resolved "https://registry.yarnpkg.com/decode-uri-component/-/decode-uri-component-0.2.2.tgz#e69dbe25d37941171dd540e024c444cd5188e1e9" + integrity sha512-FqUYQ+8o158GyGTrMFJms9qh3CqTKvAqgqsTnkLI8sKu0028orqBhxNMFkFen0zGyg6epACD32pjVk58ngIErQ== dedent@^0.7.0: version "0.7.0" From 7d68f232c65e2ec8d11f84254e732a04d55f15fa Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 10 Dec 2022 23:05:29 +0900 Subject: [PATCH 02/13] Doc: Issue - Install bug report #528 --- .github/ISSUE_TEMPLATE/install_bug_report.yml | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/install_bug_report.yml diff --git a/.github/ISSUE_TEMPLATE/install_bug_report.yml b/.github/ISSUE_TEMPLATE/install_bug_report.yml new file mode 100644 index 0000000..54055e6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/install_bug_report.yml @@ -0,0 +1,95 @@ +name: Bug report - Install +description: Create a report for install +labels: ["Issue::Bug", "install"] + +body: +# == Bug Infos ================================================================= + - type: markdown + id: bug-infos + attributes: + value: "## Bug Infos" + - type: textarea + id: describe-the-bug + attributes: + label: Describe the bug + description: A clear and concise description of what the bug is. + placeholder: Tell us what you see! + validations: + required: true + + - type: textarea + id: expected-behavior + attributes: + label: Expected behavior + description: A clear and concise description of what you expected to happen. + placeholder: Tell us what you want! + validations: + required: false + + - type: textarea + id: screenshots + attributes: + label: Screenshots + description: If is helpful to attach screenshots or video similar to the desired features. + placeholder: Drag or paste images or videos to upload + validations: + required: false + +# == Environments =============================================================== + - type: markdown + id: environments + attributes: + value: "## Environments" + + - type: dropdown + id: os + attributes: + label: OS + options: + - Linux + - Mac OS + - Windows 11 + - Windows 10 + - Windows 8 + - Windows 7 + - Others + multiple: true + validations: + required: true + - type: input + id: os-others + attributes: + label: OS - Others + description: Enter only if you choose `Others` from the OS + placeholder: e.g. FreeBSD + validations: + required: false + + - type: input + id: firefox-version + attributes: + label: Firefox Version + description: Write from `about:support` - `version` + placeholder: e.g. v101.1b3 + validations: + required: true + + - type: checkboxes + id: distribution + attributes: + label: Distribution + options: + - label: "[Original Lepton](https://github.com/black7375/Firefox-UI-Fix)" + - label: "[Lepton's photon style](https://github.com/black7375/Firefox-UI-Fix/tree/photon-style)" + - label: "[Lepton's proton style](https://github.com/black7375/Firefox-UI-Fix/tree/proton-style)" + validations: + required: true + + - type: textarea + id: additional-context + attributes: + label: Additional context + description: Add any other context about the problem here. + placeholder: Anything to write down or refer to is fine + validations: + required: false From 02654054d981c630935b003177a9464b7a36ae13 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 10 Dec 2022 23:15:00 +0900 Subject: [PATCH 03/13] Doc: Issue - contact link --- .github/ISSUE_TEMPLATE/config.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000..c9647f7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,6 @@ +# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser + +contact_links: + - name: GitHub Community Support + url: https://github.com/black7375/Firefox-UI-Fix/discussions + about: Please ask and answer questions/inquiries here. From 53213ead345fb9a025a5dc3b578c73d8fec22173 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 10 Dec 2022 23:26:36 +0900 Subject: [PATCH 04/13] Doc: Issue - Change order --- .../{install_bug_report.yml => bug_report_install.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/ISSUE_TEMPLATE/{install_bug_report.yml => bug_report_install.yml} (100%) diff --git a/.github/ISSUE_TEMPLATE/install_bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report_install.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/install_bug_report.yml rename to .github/ISSUE_TEMPLATE/bug_report_install.yml From 618729162d94f4db133831f39ed3f10f9f23d1cf Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Thu, 15 Dec 2022 17:56:53 +0900 Subject: [PATCH 05/13] Fix: Compatibility - Remove firefox view border at static separator #531 --- css/leptonChrome.css | 7 +++++++ src/compatibility/_theme.scss | 19 +++++++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 48042c2..6ef0447 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -177,6 +177,13 @@ padding-inline-start: var(--tab-overflow-pinned-tabs-width) !important; margin-inline-start: 0 !important; } + @supports -moz-bool-pref("userChrome.tab.static_separator") { + #tabbrowser-tabs { + border-inline-start: none !important; + padding-inline-start: var(--tab-overflow-pinned-tabs-width) !important; + margin-inline-start: 0 !important; + } + } } /*= OS - Compatibility =======================================================*/ @supports -moz-bool-pref("userChrome.compatibility.os") { diff --git a/src/compatibility/_theme.scss b/src/compatibility/_theme.scss index 4353cf7..235c123 100644 --- a/src/compatibility/_theme.scss +++ b/src/compatibility/_theme.scss @@ -172,8 +172,19 @@ vbox[part="drop-indicator-bar"] > image[part="drop-indicator"] { } /*= Firefox View Border #498 =================================================*/ -:root:not([privatebrowsingmode=temporary])[firefoxviewhidden] #firefox-view-button + #tabbrowser-tabs { - border-inline-start: none !important; - padding-inline-start: var(--tab-overflow-pinned-tabs-width) !important; - margin-inline-start: 0 !important; +@mixin _firefox_view_border_remove() { + #tabbrowser-tabs { + border-inline-start: none !important; + padding-inline-start: var(--tab-overflow-pinned-tabs-width) !important; + margin-inline-start: 0 !important; + } +} + +:root:not([privatebrowsingmode=temporary])[firefoxviewhidden] #firefox-view-button + { + @include _firefox_view_border_remove; +} + +@include Option("userChrome.tab.static_separator") { + // #531 + @include _firefox_view_border_remove; } From cf15b69281647508cc387705410945b61d9825ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=83=AA=E3=82=A7=E3=83=B3=E3=83=BC=E3=82=86=E3=81=8F?= Date: Sun, 18 Dec 2022 00:12:19 +0700 Subject: [PATCH 06/13] Fix: Activity Stream - Enable Hover Highlights on the New Fake Searchbar (#537) * Fix: Activity Stream - Enable Hover Highlights on the New Fake Searchbar * Fix: Activity Stream - `button` -> `.search-handoff-button` * Fix: Activity Stream - Searchbar animation Co-authored-by: alstjr7375 --- css/leptonContent.css | 16 +++++++++---- src/contents/_activity_stream.scss | 38 ++++++++++++++++++++---------- 2 files changed, 38 insertions(+), 16 deletions(-) diff --git a/css/leptonContent.css b/css/leptonContent.css index 2716402..b789715 100644 --- a/css/leptonContent.css +++ b/css/leptonContent.css @@ -333,16 +333,24 @@ transition: background 0.5s var(--animation-easing-function); } /* Search Bar */ - .search-inner-wrapper input { + .search-wrapper .search-inner-wrapper > input, + .search-wrapper .search-inner-wrapper > .search-handoff-button { transition: 1s var(--animation-easing-function); transition-property: border-color, box-shadow; } - .search-wrapper .search-inner-wrapper:active input, - .search-wrapper input:focus { + .search-wrapper + .search-inner-wrapper:active + > input + .search-wrapper + .search-inner-wrapper:active + > .search-handoff-button, + .search-wrapper .search-inner-wrapper > input:focus, + .search-wrapper .search-inner-wrapper > .search-handoff-button:focus { transition: border-color 0.5s var(--animation-easing-function), box-shadow 1s var(--animation-easing-function); } @supports -moz-bool-pref("userContent.page.field_border") { - .search-wrapper .search-inner-wrapper:hover input { + .search-wrapper .search-inner-wrapper:hover > input, + .search-wrapper .search-inner-wrapper:hover > .search-handoff-button { border-color: var(--newtab-primary-action-background) !important; transition: border-color 0.5s var(--animation-easing-function); } diff --git a/src/contents/_activity_stream.scss b/src/contents/_activity_stream.scss index 14f2983..97d1896 100644 --- a/src/contents/_activity_stream.scss +++ b/src/contents/_activity_stream.scss @@ -64,18 +64,32 @@ } /* Search Bar */ - .search-inner-wrapper input { - transition: 1s var(--animation-easing-function); - transition-property: border-color, box-shadow; - } - .search-wrapper .search-inner-wrapper:active input, - .search-wrapper input:focus { - transition: border-color 0.5s var(--animation-easing-function), box-shadow 1s var(--animation-easing-function); - } - @include Option("userContent.page.field_border") { - .search-wrapper .search-inner-wrapper:hover input { - border-color: var(--newtab-primary-action-background) !important; - transition: border-color 0.5s var(--animation-easing-function); + .search-wrapper .search-inner-wrapper { + // When `browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar` + // input(#newtab-search-text): false + // .search-handoff-button: true + $_activityStreamSearchbar: "> input, > .search-handoff-button"; + $_activeSearchbar: selector.nest(":active", $_activityStreamSearchbar); + $_activeSearchbarResult: (); + @each $searchbarSelctor in $_activeSearchbar { + $_activeSearchbarResult: append($_activeSearchbarResult, "&" + $searchbarSelctor); + } + + #{$_activityStreamSearchbar} { + transition: 1s var(--animation-easing-function); + transition-property: border-color, box-shadow; + } + #{$_activeSearchbarResult}, + #{selector.append($_activityStreamSearchbar, ":focus")} { + transition: border-color 0.5s var(--animation-easing-function), box-shadow 1s var(--animation-easing-function); + } + @include Option("userContent.page.field_border") { + &:hover { + #{$_activityStreamSearchbar} { + border-color: var(--newtab-primary-action-background) !important; + transition: border-color 0.5s var(--animation-easing-function); + } + } } } } From 2aca079d9462b22f9a31f5047b2e663a1ba1b2dd Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sun, 18 Dec 2022 18:32:38 +0900 Subject: [PATCH 07/13] Fix: Activity Stream - Missing comma #537 --- css/leptonContent.css | 8 ++------ src/contents/_activity_stream.scss | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/css/leptonContent.css b/css/leptonContent.css index b789715..ae5a71e 100644 --- a/css/leptonContent.css +++ b/css/leptonContent.css @@ -338,12 +338,8 @@ transition: 1s var(--animation-easing-function); transition-property: border-color, box-shadow; } - .search-wrapper - .search-inner-wrapper:active - > input - .search-wrapper - .search-inner-wrapper:active - > .search-handoff-button, + .search-wrapper .search-inner-wrapper:active > input, + .search-wrapper .search-inner-wrapper:active > .search-handoff-button, .search-wrapper .search-inner-wrapper > input:focus, .search-wrapper .search-inner-wrapper > .search-handoff-button:focus { transition: border-color 0.5s var(--animation-easing-function), box-shadow 1s var(--animation-easing-function); diff --git a/src/contents/_activity_stream.scss b/src/contents/_activity_stream.scss index 97d1896..094af08 100644 --- a/src/contents/_activity_stream.scss +++ b/src/contents/_activity_stream.scss @@ -72,7 +72,7 @@ $_activeSearchbar: selector.nest(":active", $_activityStreamSearchbar); $_activeSearchbarResult: (); @each $searchbarSelctor in $_activeSearchbar { - $_activeSearchbarResult: append($_activeSearchbarResult, "&" + $searchbarSelctor); + $_activeSearchbarResult: append($_activeSearchbarResult, "&" + $searchbarSelctor, $separator: comma); } #{$_activityStreamSearchbar} { From b2e5da2288af3867a7664ba87ac528563c435145 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 19 Dec 2022 01:12:26 +0900 Subject: [PATCH 08/13] Fix: Panel - Full width padding's margin --- css/leptonChrome.css | 1 + src/panel/_full_width_padding.scss | 1 + 2 files changed, 2 insertions(+) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 6ef0447..fad17bb 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -6843,6 +6843,7 @@ :root, :root:is([uidensity="compact"], [uidensity="touch"]) { --arrowpanel-menuitem-margin: 0 !important; + --arrowpanel-menuitem-margin-inline: 0 !important; --arrowpanel-menuitem-padding-inline: calc(var(--arrowpanel-menuitem-padding-block) + 8px) !important; } } diff --git a/src/panel/_full_width_padding.scss b/src/panel/_full_width_padding.scss index 70a6019..e5d020a 100644 --- a/src/panel/_full_width_padding.scss +++ b/src/panel/_full_width_padding.scss @@ -8,5 +8,6 @@ :root, :root:is([uidensity="compact"], [uidensity="touch"]) { --arrowpanel-menuitem-margin: 0 !important; + --arrowpanel-menuitem-margin-inline: 0 !important; --arrowpanel-menuitem-padding-inline: calc(var(--arrowpanel-menuitem-padding-block) + 8px) !important; } From edf06317653e9294983144b485701658c79d88c9 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 19 Dec 2022 02:02:39 +0900 Subject: [PATCH 09/13] Add: Icons - Status Bar(Waterfox), Sorted Tabs(TMP) --- css/leptonChrome.css | 9 ++++++++- icons/pulse-square.svg | 3 +++ src/icons/_panel.scss | 5 +++++ src/icons/_waterfox.scss | 4 ++++ src/icons/layout/_panel.scss | 2 +- 5 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 icons/pulse-square.svg diff --git a/css/leptonChrome.css b/css/leptonChrome.css index fad17bb..7e6d31e 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -8069,7 +8069,7 @@ #appMenu-fullscreen-button2 { --arrowpanel-menuitem-padding-block: 0px; } - .subviewbutton[type="checkbox"]:not([checked="true"]) > .toolbarbutton-text { + .subviewbutton[type="checkbox"]:not([checked="true"], #allTabsMenu_sortTabsButton) > .toolbarbutton-text { margin-left: 16px !important; } /* Icons Color */ @@ -8529,6 +8529,10 @@ #unified-extensions-manage-extensions { list-style-image: url("chrome://mozapps/skin/extensions/extension.svg"); } + /*= Tab Mix Plus =============================================================*/ + #allTabsMenu_sortTabsButton { + list-style-image: url("../icons/text-sort-ascending.svg"); + } } /** Menu - Icons Layout *******************************************************/ @supports -moz-bool-pref("userChrome.icon.menu") { @@ -10073,6 +10077,9 @@ #menu_FileRestartItem { --menuitem-image: url("../icons/refresh-cw.svg"); } + #toggle_status-dummybar { + --menuitem-image: url("../icons/pulse-square.svg"); + } menuitem.privatetab-icon { --menuitem-image: url("../icons/private-favicon.svg"); } diff --git a/icons/pulse-square.svg b/icons/pulse-square.svg new file mode 100644 index 0000000..2d65f1c --- /dev/null +++ b/icons/pulse-square.svg @@ -0,0 +1,3 @@ + + + diff --git a/src/icons/_panel.scss b/src/icons/_panel.scss index 96974ae..f4b059e 100644 --- a/src/icons/_panel.scss +++ b/src/icons/_panel.scss @@ -480,3 +480,8 @@ panelMenuBookmarkThisPage[starred] { #unified-extensions-manage-extensions { list-style-image: url("chrome://mozapps/skin/extensions/extension.svg"); } + +/*= Tab Mix Plus =============================================================*/ +#allTabsMenu_sortTabsButton { + list-style-image: url("../icons/text-sort-ascending.svg"); +} diff --git a/src/icons/_waterfox.scss b/src/icons/_waterfox.scss index f1bbee1..95164e0 100644 --- a/src/icons/_waterfox.scss +++ b/src/icons/_waterfox.scss @@ -8,6 +8,10 @@ --menuitem-image: url("../icons/refresh-cw.svg"); } + #toggle_status-dummybar { + --menuitem-image: url("../icons/pulse-square.svg"); + } + menuitem.privatetab-icon { --menuitem-image: url("../icons/private-favicon.svg"); } diff --git a/src/icons/layout/_panel.scss b/src/icons/layout/_panel.scss index b003c25..5d61c48 100644 --- a/src/icons/layout/_panel.scss +++ b/src/icons/layout/_panel.scss @@ -71,7 +71,7 @@ --arrowpanel-menuitem-padding-block: 0px; } -.subviewbutton[type="checkbox"]:not([checked="true"]) > .toolbarbutton-text { +.subviewbutton[type="checkbox"]:not([checked="true"], #allTabsMenu_sortTabsButton) > .toolbarbutton-text { margin-left: 16px !important; } From 40ecb8efa70f3675a8ca0e0f4829c0563e92077e Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 20 Dec 2022 03:56:55 +0900 Subject: [PATCH 10/13] Doc: Issue - Blank issue disabled Recently, bug reports are often done without inserting information. #528 #532 #539 #541 In this case, it is too difficult to reproduce. Even if it's inconvenient, I think we need some restrictions. --- .github/ISSUE_TEMPLATE/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index c9647f7..96c9384 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,5 +1,6 @@ # https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser +blank_issues_enabled: false contact_links: - name: GitHub Community Support url: https://github.com/black7375/Firefox-UI-Fix/discussions From 04a1024b6a3ef2700e1c09faea736e134da86a27 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 20 Dec 2022 04:59:55 +0900 Subject: [PATCH 11/13] Doc: Developer - Update to the latest information --- docs/Project_Structure.md | 8 +++++--- docs/README.md | 1 + docs/Rules.md | 10 ++++++---- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/Project_Structure.md b/docs/Project_Structure.md index 480d383..3ef1f04 100644 --- a/docs/Project_Structure.md +++ b/docs/Project_Structure.md @@ -18,7 +18,7 @@ The overall structure of this project. root |- __tests__/: Mixin spec test |- icons/: Icons, illustrations -|- css/: Build result of SCSS Files +|- css/: Build result of SCSS Files (Don't modify directly!!) |- docs/: Development Documents |- src/: Source files |- src/leptonChrome.scss: Entry of SCSS for Browser UI @@ -32,11 +32,13 @@ root |- package.json: Build setup, package dependency |- LEPTON: Meta infos (branch, version) |- user.js: about:config settings -|- userChrome.css: Entry of css for Browser UI (Don't modify directly!!) -|- userContent.css: Entry of css for Web pages (Don't modify directly!!) +|- userChrome.css: Entry of css for Browser UI (Modify only when customizing!!) +|- userContent.css: Entry of css for Web pages (Modify only when customizing!!) |- yarn.lock: Auto generated dependency (Don't modify directly!!) ``` +If you first come, it's a good idea to see the [`/src/leptonChrome.scss`](/src/leptonChrome.scss) and [`leptonContent.scss`](/src/leptonContent.scss) files to understand the flow. + ## Icon files Most of them are made in SVG. diff --git a/docs/README.md b/docs/README.md index 6f00496..3174acb 100644 --- a/docs/README.md +++ b/docs/README.md @@ -103,6 +103,7 @@ Start Guide: CSS, SASS Documents: - [MDN: CSS](https://developer.mozilla.org/en-US/docs/Web/CSS) - [MDN: Introducing the CSS Cascade](https://developer.mozilla.org/en-US/docs/Web/CSS/Cascade) +- [MDN: Introducing the CSS Specific](https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity) - [SASS(SCSS)](https://sass-lang.com/documentation) - [SASS Live Compile](https://www.sassmeister.com/) diff --git a/docs/Rules.md b/docs/Rules.md index dbb4ce8..12f226c 100644 --- a/docs/Rules.md +++ b/docs/Rules.md @@ -45,13 +45,15 @@ It comes from [#109](https://github.com/black7375/Firefox-UI-Fix/issues/109#issu Stable: Only bugfix, Documentation. - `master`: Common bugfix, documentation. -- `photon-style`: Bugfix, documentation specified in `photon-style`. -- `proton-style`: Bugfix, documentation specified in `proton-style`. +- `photon-style`: Config, documentation specified in `photon-style`. +- `proton-style`: Config, documentation specified in `proton-style`. Development: New Features. - `dev`: Common new features. -- `photon-style-dev`: New features specified in `photon-style`. -- `proton-style-dev`: New features specified in `proton-style`. +- `photon-style-dev`: New config specified in `photon-style`. +- `proton-style-dev`: New config specified in `proton-style`. + +After version [`v5.0.0`](https://github.com/black7375/Firefox-UI-Fix/releases/tag/v5.0.0), the distribution is just a [setting difference](https://github.com/black7375/Firefox-UI-Fix/wiki/Options#distribution-settings). ## Edit ### Modify only source file From 742075c1372aeaabb7c25828cff57ca7da13979c Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Wed, 21 Dec 2022 05:34:29 +0900 Subject: [PATCH 12/13] Fix: Icons - Windows10 Native Menu #541 --- __tests__/native_menu.test.scss | 6 +++++ css/leptonChrome.css | 37 +++++++++++++++++++++++------- css/leptonContent.css | 6 +++++ src/compatibility/_os.scss | 20 ++++++++++++++-- src/icons/layout/_menu_common.scss | 5 ++++ src/utils/_native_menu.scss | 6 +++++ 6 files changed, 70 insertions(+), 10 deletions(-) diff --git a/__tests__/native_menu.test.scss b/__tests__/native_menu.test.scss index 05e6f44..7b6d005 100644 --- a/__tests__/native_menu.test.scss +++ b/__tests__/native_menu.test.scss @@ -9,11 +9,17 @@ @include native_menu.NativeMenu { @include example; } + @include native_menu.Win10_NativeMenu { + @include example; + } } @include expect { @supports -moz-bool-pref("widget.macos.native-context-menus") or -moz-bool-pref("widget.gtk.native-context-menus") { @include example; } + @media not (-moz-windows-non-native-menus) { + @include example; + } } } } diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 7e6d31e..c5cf296 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -271,13 +271,13 @@ } } @media (-moz-os-version: windows-win7), (-moz-platform: windows-win7) { - menu[_moz-menuactive="true"], - menuitem[_moz-menuactive="true"] { + menupopup:not(#BMB_bookmarksPopup) menu[_moz-menuactive="true"], + menupopup:not(#BMB_bookmarksPopup) menuitem[_moz-menuactive="true"] { background-color: color-mix(in srgb, -moz-menuhover 5%, transparent) !important; border-color: color-mix(in srgb, -moz-menuhover 60%, transparent) !important; } - menu[_moz-menuactive="true"][disabled="true"], - menuitem[_moz-menuactive="true"][disabled="true"] { + menupopup:not(#BMB_bookmarksPopup) menu[_moz-menuactive="true"][disabled="true"], + menupopup:not(#BMB_bookmarksPopup) menuitem[_moz-menuactive="true"][disabled="true"] { background-color: color-mix(in srgb, currentColor 5%, transparent) !important; border-color: color-mix(in srgb, currentColor 60%, transparent) !important; } @@ -293,17 +293,32 @@ } } @media (-moz-os-version: windows-win8), (-moz-platform: windows-win8) { - menu[_moz-menuactive="true"], - menuitem[_moz-menuactive="true"] { + menupopup:not(#BMB_bookmarksPopup) menu[_moz-menuactive="true"], + menupopup:not(#BMB_bookmarksPopup) menuitem[_moz-menuactive="true"] { background-color: color-mix(in srgb, -moz-menuhover 17%, transparent) !important; border-color: color-mix(in srgb, -moz-menuhover 80%, transparent) !important; } - menu[_moz-menuactive="true"][disabled="true"], - menuitem[_moz-menuactive="true"][disabled="true"] { + menupopup:not(#BMB_bookmarksPopup) menu[_moz-menuactive="true"][disabled="true"], + menupopup:not(#BMB_bookmarksPopup) menuitem[_moz-menuactive="true"][disabled="true"] { background-color: color-mix(in srgb, currentColor 17%, transparent) !important; border-color: color-mix(in srgb, currentColor 80%, transparent) !important; } } + /*= Windows 10 - Native Menu Active Color =====================================*/ + @media (-moz-os-version: windows-win10), (-moz-platform: windows-win10) { + @media not (-moz-windows-non-native-menus) { + menu[_moz-menuactive="true"], + menuitem[_moz-menuactive="true"] { + background-color: #91c9f7 !important; + border-color: transparent !important; + } + menu[_moz-menuactive="true"][disabled="true"], + menuitem[_moz-menuactive="true"][disabled="true"] { + background-color: color-mix(in srgb, currentColor 9%, transparent) !important; + border-color: transparent !important; + } + } + } @media (-moz-gtk-csd-available) { /*= Linux - Global Menubar Active Color ====================================*/ #main-menubar > menu[open="true"], @@ -8681,6 +8696,12 @@ var(--context-menu-background-padding) + var(--context-menu-text-padding) ); } + @media not (-moz-windows-non-native-menus) { + :root { + --context-menu-background-padding: 3px; + --menu-background-padding-default: 0px; + } + } :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem:not(.menuitem-iconic, .bookmark-item, .in-menulist, [checked="true"]), diff --git a/css/leptonContent.css b/css/leptonContent.css index ae5a71e..906ddea 100644 --- a/css/leptonContent.css +++ b/css/leptonContent.css @@ -2833,6 +2833,12 @@ var(--context-menu-background-padding) + var(--context-menu-text-padding) ); } + @media not (-moz-windows-non-native-menus) { + :root { + --context-menu-background-padding: 3px; + --menu-background-padding-default: 0px; + } + } menupopup:is(#placesContext, #placesColumnsContext, #downloadsContextMenu) menuitem:not(.menuitem-iconic, .bookmark-item, .in-menulist, [checked="true"]), menupopup:is(#placesContext, #placesColumnsContext, #downloadsContextMenu) diff --git a/src/compatibility/_os.scss b/src/compatibility/_os.scss index 30072d8..c78975b 100644 --- a/src/compatibility/_os.scss +++ b/src/compatibility/_os.scss @@ -89,8 +89,8 @@ //-- Mixin --------------------------------------------------------------------- @mixin _os_menuEmulate($bgRate, $bdRate) { - menu[_moz-menuactive="true"], - menuitem[_moz-menuactive="true"] { + menupopup:not(#BMB_bookmarksPopup) menu[_moz-menuactive="true"], + menupopup:not(#BMB_bookmarksPopup) menuitem[_moz-menuactive="true"] { background-color: color-mix(in srgb, -moz-menuhover $bgRate, transparent) !important; border-color: color-mix(in srgb, -moz-menuhover $bdRate, transparent) !important; @@ -122,6 +122,22 @@ @include _os_menuEmulate(17%, 80%); } +/*= Windows 10 - Native Menu Active Color =====================================*/ +@include OS($win10) { + @include Win10_NativeMenu() { + menu[_moz-menuactive="true"], + menuitem[_moz-menuactive="true"] { + background-color: #91c9f7 !important; // color-mix(in srgb, -moz-menuhover 40%, transparent) + border-color: transparent !important; + + &[disabled="true"] { + background-color: color-mix(in srgb, currentColor 9%, transparent) !important; + border-color: transparent !important; + } + } + } +} + @include OS($linux) { /*= Linux - Global Menubar Active Color ====================================*/ #main-menubar > menu[open="true"], diff --git a/src/icons/layout/_menu_common.scss b/src/icons/layout/_menu_common.scss index 079960a..62a3f35 100644 --- a/src/icons/layout/_menu_common.scss +++ b/src/icons/layout/_menu_common.scss @@ -97,6 +97,11 @@ $_initialMenus: selector.append( --context-menu-background-padding: 1em; --context-menu-text-padding: 24px; /* 16px + 8px */ --menu-background-padding-default: calc(var(--context-menu-background-padding) + var(--context-menu-text-padding)); + + @include Win10_NativeMenu() { + --context-menu-background-padding: 3px; + --menu-background-padding-default: 0px; + } } } @mixin _layout_init_win10() { diff --git a/src/utils/_native_menu.scss b/src/utils/_native_menu.scss index 5e8ee16..aeb7969 100644 --- a/src/utils/_native_menu.scss +++ b/src/utils/_native_menu.scss @@ -5,3 +5,9 @@ @content; } } + +@mixin Win10_NativeMenu() { + @media not (-moz-windows-non-native-menus) { + @content; + } +} From 4853948a5e3f0b181588ffe36c7d3ba6367250ba Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Thu, 22 Dec 2022 05:30:27 +0900 Subject: [PATCH 13/13] Fix: Icons - Panel's overflow unified extension menu layout #544 --- css/leptonChrome.css | 4 +++- src/icons/layout/_panel.scss | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index c5cf296..fb40810 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -8045,7 +8045,9 @@ .subviewbutton > .toolbarbutton-text { padding-inline-start: var(--arrowpanel-menuicon-padding) !important; } - .toolbaritem-combined-buttons > .subviewbutton:not(.subviewbutton-iconic) > .toolbarbutton-text { + .toolbaritem-combined-buttons:not(.unified-extensions-item) + > .subviewbutton:not(.subviewbutton-iconic) + > .toolbarbutton-text { padding-inline-start: 0 !important; } #panelMenu_bookmarksMenu .subviewbutton[disabled="true"] .toolbarbutton-text, diff --git a/src/icons/layout/_panel.scss b/src/icons/layout/_panel.scss index 5d61c48..538c27c 100644 --- a/src/icons/layout/_panel.scss +++ b/src/icons/layout/_panel.scss @@ -30,7 +30,7 @@ .subviewbutton > .toolbarbutton-text { padding-inline-start: var(--arrowpanel-menuicon-padding) !important; } -.toolbaritem-combined-buttons > .subviewbutton:not(.subviewbutton-iconic) > .toolbarbutton-text { +.toolbaritem-combined-buttons:not(.unified-extensions-item) > .subviewbutton:not(.subviewbutton-iconic) > .toolbarbutton-text { padding-inline-start: 0 !important; } #panelMenu_bookmarksMenu .subviewbutton[disabled="true"] .toolbarbutton-text,