From 4122a599101290c8846cd1f74178fd2364246ba0 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 22 Nov 2022 06:37:34 +0900 Subject: [PATCH 01/18] Doc: Restrictions - About `-moz-box-layout` --- docs/Restrictions.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/Restrictions.md b/docs/Restrictions.md index f01d3ae..3a678f2 100644 --- a/docs/Restrictions.md +++ b/docs/Restrictions.md @@ -75,7 +75,11 @@ The following code will cause extension panels fail to open and trying to open t ``` Info: `#nav-bar` is [`toolbar`](https://udn.realityripple.com/docs/Archive/Mozilla/XUL/toolbar). -Another `display: flex`'s side effect examples. [#368](https://github.com/black7375/Firefox-UI-Fix/issues/368) [#372](https://github.com/black7375/Firefox-UI-Fix/issues/372) +Another `display: flex`'s side effect examples. [#368](https://github.com/black7375/Firefox-UI-Fix/issues/368) [#372](https://github.com/black7375/Firefox-UI-Fix/issues/372) +After FF `v107`, breakage due to `-moz-box` may occur. + +- [Bug 1783934 - Add a way to incrementally migrate -moz-box layout to modern flexbox](https://bugzilla.mozilla.org/show_bug.cgi?id=1783934) +- [Bug 1790616 - Use modern flexbox in the browser toolbox.](https://bugzilla.mozilla.org/show_bug.cgi?id=1790616) ### RTL From e7d2d36591e37c2ba03afb1b96455463a663ee8e Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 22 Nov 2022 11:26:16 +0900 Subject: [PATCH 02/18] Doc: README - Sponsors --- CREDITS | 3 +++ README.org | 14 +++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/CREDITS b/CREDITS index 2c3fa83..a192c71 100644 --- a/CREDITS +++ b/CREDITS @@ -30,6 +30,9 @@ N: nikkehtine E: nikkehtine@int.pl W: https://github.com/nikkehtine +N: OSS.kr +W: https://www.oss.kr/ + ---------- Contributors diff --git a/README.org b/README.org index c4547c1..660bbdc 100644 --- a/README.org +++ b/README.org @@ -12,7 +12,7 @@ - [[#why-proton][WHY Proton?]] - [[#why-not-proton][WHY Not Proton?]] - [[#padding-comparisons][Padding Comparisons]] - - [[#contributors][Contributors]] + - [[#sponsors--contributors][Sponsors & Contributors]] - [[#faq][FAQ]] :END: @@ -185,9 +185,17 @@ Windows users: Run with powershell ([[https://github.com/black7375/Firefox-UI-Fi - Lepton -** Contributors +** Sponsors & Contributors -Thanks to all contributors to this project for providing help and developing features! +Thanks to all sponsors & contributors to this project for providing help and developing features! + +*Sponsors* + +[[https://user-images.githubusercontent.com/25581533/203210367-9f2eed69-666a-4218-acde-128892aa09d8.png]] +[[https://github.com/ojaha065][@@html:@@]] +[[https://github.com/nikkehtine][@@html:@@]] + +*Contributors* [[https://github.com/black7375/Firefox-UI-Fix/graphs/contributors][@@html:@@]] From 229d08f5a3be52f2445abd1aa88a20d4999aa6bf Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Thu, 24 Nov 2022 09:16:18 +0900 Subject: [PATCH 03/18] Fix: Tab bar - connected pinned tab at nightly #513 --- css/leptonChrome.css | 4 ++++ src/tab/_connect_to_window.scss | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 376d2a3..89055bd 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -5665,6 +5665,10 @@ #tabbrowser-tabs[positionpinnedtabs] > #tabbrowser-arrowscrollbox > .tabbrowser-tab[pinned] { z-index: 0 !important; } + #tabbrowser-tabs[positionpinnedtabs] > #tabbrowser-arrowscrollbox > .tabbrowser-tab[pinned] .tab-stack { + /* Temporary solution for compatibility #513 */ + overflow-y: clip; + } } /*= Selected Tab =============================================================*/ /*= Selected Tab - Color like toolbar ========================================*/ diff --git a/src/tab/_connect_to_window.scss b/src/tab/_connect_to_window.scss index 11ffa74..4ffcfd1 100644 --- a/src/tab/_connect_to_window.scss +++ b/src/tab/_connect_to_window.scss @@ -23,4 +23,9 @@ /* Pinned Tab - tabbrowser-arrowscrollbox overflowing */ #tabbrowser-tabs[positionpinnedtabs] > #tabbrowser-arrowscrollbox > .tabbrowser-tab[pinned] { z-index: 0 !important; + + .tab-stack { + /* Temporary solution for compatibility #513 */ + overflow-y: clip; + } } From 278f74f41ecbfa9a280f6b9c701ead543d42b3ff Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Fri, 25 Nov 2022 17:34:04 +0900 Subject: [PATCH 04/18] Doc: CREDITS - Update sponsors --- CREDITS | 3 +++ README.org | 1 + 2 files changed, 4 insertions(+) diff --git a/CREDITS b/CREDITS index a192c71..99f685f 100644 --- a/CREDITS +++ b/CREDITS @@ -26,6 +26,9 @@ N: Jani Haiko E: haiko.jani@gmail.com W: https://github.com/ojaha065 +N: kanlukasz +W: https://github.com/kanlukasz + N: nikkehtine E: nikkehtine@int.pl W: https://github.com/nikkehtine diff --git a/README.org b/README.org index 660bbdc..0cc7177 100644 --- a/README.org +++ b/README.org @@ -193,6 +193,7 @@ Thanks to all sponsors & contributors to this project for providing help and dev [[https://user-images.githubusercontent.com/25581533/203210367-9f2eed69-666a-4218-acde-128892aa09d8.png]] [[https://github.com/ojaha065][@@html:@@]] +[[https://github.com/kanlukasz][@@html:@@]] [[https://github.com/nikkehtine][@@html:@@]] *Contributors* From 6187d01df7c3e1247db7e30d32c0c3b289f06985 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 26 Nov 2022 22:20:48 +0900 Subject: [PATCH 05/18] Doc: README - Bug or questions #515 --- README.org | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.org b/README.org index 0cc7177..42fcdb5 100644 --- a/README.org +++ b/README.org @@ -13,6 +13,7 @@ - [[#why-not-proton][WHY Not Proton?]] - [[#padding-comparisons][Padding Comparisons]] - [[#sponsors--contributors][Sponsors & Contributors]] + - [[#bug--questions][Bug / Questions?]] - [[#faq][FAQ]] :END: @@ -191,7 +192,7 @@ Thanks to all sponsors & contributors to this project for providing help and dev *Sponsors* -[[https://user-images.githubusercontent.com/25581533/203210367-9f2eed69-666a-4218-acde-128892aa09d8.png]] +[[https://www.oss.kr/][https://user-images.githubusercontent.com/25581533/203210367-9f2eed69-666a-4218-acde-128892aa09d8.png]] [[https://github.com/ojaha065][@@html:@@]] [[https://github.com/kanlukasz][@@html:@@]] [[https://github.com/nikkehtine][@@html:@@]] @@ -202,6 +203,11 @@ Thanks to all sponsors & contributors to this project for providing help and dev A list of all contributors can be found in [[./CREDITS][CREDITS]]. +** Bug / Questions? + +If you found a bug, please contact [[https://github.com/black7375/Firefox-UI-Fix/issues][issue]]. \\ +If you have any questions or inquiries, please contact [[https://github.com/black7375/Firefox-UI-Fix/discussions][discussions]]. + ** FAQ - *Black pixels around the selected tab bottom corners* \\ From 9204e1c2f1e923628a858d705f5202183cc330e7 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sun, 27 Nov 2022 00:24:26 +0900 Subject: [PATCH 06/18] Fix: Theme - Fully color's separator #516 --- css/leptonChrome.css | 2 +- src/theme/_fully_color.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 89055bd..3050f29 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -1294,7 +1294,7 @@ --panel-border-color: var(--menu-border-color) !important; } html#main-window menupopup:not(.in-menulist) menuseparator { - border-top: 1px solid var(--menu-border-color); + border-top: 1px solid var(--menu-border-color) !important; } html#main-window menupopup:not(.in-menulist) menu[disabled="true"], html#main-window menupopup:not(.in-menulist) menu[_moz-menuactive="true"][disabled="true"], diff --git a/src/theme/_fully_color.scss b/src/theme/_fully_color.scss index 192df25..30af148 100644 --- a/src/theme/_fully_color.scss +++ b/src/theme/_fully_color.scss @@ -30,7 +30,7 @@ html#main-window menupopup:not(.in-menulist) { --panel-border-color: var(--menu-border-color) !important; menuseparator { - border-top: 1px solid var(--menu-border-color); + border-top: 1px solid var(--menu-border-color) !important; } menu, From 87d7b47ccb4d4c14c27b4c8c8cfaa0aff9d54794 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sun, 27 Nov 2022 22:50:59 +0900 Subject: [PATCH 07/18] Clean: Tab - Static separator use `--toolbarseparator-color` as dynamic --- css/leptonChrome.css | 11 ++++++----- src/tab/unselected_tab/_static_separator.scss | 12 +++++++----- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 3050f29..2fe570c 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -6120,6 +6120,9 @@ } /*= Unselected Tab - Static Separator ========================================*/ @supports -moz-bool-pref("userChrome.tab.static_separator") { + #TabsToolbar { + --toolbarseparator-color: color-mix(in srgb, currentColor 30%, transparent); + } .tabbrowser-tab[first-visible-tab="true"] .tab-background::before, .tab-background::after { content: ""; @@ -6131,13 +6134,12 @@ position: absolute; /* Position */ top: 50%; - transform: translateY(-50%) !important; + transform: translateY(-50%); /* Bar shape */ width: 0px; height: 100%; /* Bar Color */ - opacity: 0.3; - border-right: 1px solid var(--lwt-background-tab-separator-color, currentColor) !important; + border-right: 1px solid var(--toolbarseparator-color); } .tab-background::after { right: 0; @@ -6146,8 +6148,7 @@ .tabbrowser-tab[visuallyselected] .tab-background::before, .tabbrowser-tab[visuallyselected] .tab-background::after, .tabbrowser-tab[beforeselected-visible] .tab-background::after { - --lwt-background-tab-separator-color: var(--tab-line-color, var(--lwt-tab-line-color, rgb(10, 132, 255))); - opacity: 1; + --toolbarseparator-color: var(--tab-line-color, var(--lwt-tab-line-color, rgb(10, 132, 255))); } } @supports not -moz-bool-pref("userChrome.tab.static_separator.selected_accent") { diff --git a/src/tab/unselected_tab/_static_separator.scss b/src/tab/unselected_tab/_static_separator.scss index 2e7e625..9de91a7 100644 --- a/src/tab/unselected_tab/_static_separator.scss +++ b/src/tab/unselected_tab/_static_separator.scss @@ -1,3 +1,7 @@ +#TabsToolbar { + --toolbarseparator-color: color-mix(in srgb, currentColor 30%, transparent); +} + .tabbrowser-tab[first-visible-tab="true"] .tab-background::before, .tab-background::after { content: ""; @@ -11,15 +15,14 @@ /* Position */ top: 50%; - transform: translateY(-50%) !important; + transform: translateY(-50%); /* Bar shape */ width: 0px; height: 100%; /* Bar Color */ - opacity: 0.3; - border-right: 1px solid var(--lwt-background-tab-separator-color, currentColor) !important; + border-right: 1px solid var(--toolbarseparator-color); } .tab-background::after { right: 0; @@ -29,8 +32,7 @@ .tabbrowser-tab[visuallyselected] .tab-background::after, .tabbrowser-tab[beforeselected-visible] .tab-background::after { @include Option("userChrome.tab.static_separator.selected_accent") { - --lwt-background-tab-separator-color: var(--tab-line-color, var(--lwt-tab-line-color, rgb(10, 132, 255))); - opacity: 1; + --toolbarseparator-color: var(--tab-line-color, var(--lwt-tab-line-color, rgb(10, 132, 255))); } @include NotOption("userChrome.tab.static_separator.selected_accent") { opacity: 0; From 3fda00e12cdead3b039cd06e154dca8bd16040d8 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 28 Nov 2022 08:51:24 +0900 Subject: [PATCH 08/18] Fix: Fully Color - At placespopup separator #516 --- css/leptonChrome.css | 3 ++- src/theme/_fully_color.scss | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 2fe570c..a32c205 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -1293,7 +1293,8 @@ --panel-background: var(--menu-background-color) !important; --panel-border-color: var(--menu-border-color) !important; } - html#main-window menupopup:not(.in-menulist) menuseparator { + html#main-window menupopup:not(.in-menulist):not([placespopup]) menuseparator, + html#main-window menupopup:not(.in-menulist)[placespopup] menuseparator::before { border-top: 1px solid var(--menu-border-color) !important; } html#main-window menupopup:not(.in-menulist) menu[disabled="true"], diff --git a/src/theme/_fully_color.scss b/src/theme/_fully_color.scss index 30af148..ccbae21 100644 --- a/src/theme/_fully_color.scss +++ b/src/theme/_fully_color.scss @@ -29,7 +29,9 @@ html#main-window menupopup:not(.in-menulist) { --panel-background: var(--menu-background-color) !important; --panel-border-color: var(--menu-border-color) !important; - menuseparator { + &:not([placespopup]) menuseparator, + &[placespopup] menuseparator::before { + // toolbarbutton menupopup[placespopup] menuseparator::before border-top: 1px solid var(--menu-border-color) !important; } From a0c218754e59f68636888f95ea349525bdab8c56 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Thu, 1 Dec 2022 22:09:11 +0900 Subject: [PATCH 09/18] Fix: Sidebar - Shadow --- css/leptonChrome.css | 32 +++++++++++++++++++++----- src/autohide/sidebar/_overlap.scss | 37 +++++++++++++++++++++--------- src/autohide/sidebar/_static.scss | 3 ++- src/sidebar/_overlap.scss | 11 ++++++--- 4 files changed, 62 insertions(+), 21 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index a32c205..3862cfe 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -6852,16 +6852,20 @@ --uc-sidebar-activate-width: 18em; --uc-sidebar-activate-width-reverse: calc(-1 * var(--uc-sidebar-activate-width)); --uc-sidebar-fullscreen-width: 4px; + --uc-sidebar-shadow-size: 1px; + --uc-sidebar-shadow-width: 0px; + --uc-sidebar-shadow-position: var(--uc-sidebar-shadow-position-default); + --uc-sidebar-shadow-position-default: calc(var(--uc-sidebar-shadow-size) + var(--uc-sidebar-shadow-width)); --uc-sidebar-shadow-color: #28282f; --uc-autohide-sidebar-speed: 750ms; --uc-autohide-fullscreen-sidebar-speed: 1s; --uc-autohide-sidebar-delay: 600ms; /* Wait 0.6s before hiding sidebar */ z-index: 1 !important; position: relative !important; - box-shadow: 1px 0px 15px -10px var(--uc-sidebar-shadow-color); + box-shadow: var(--uc-sidebar-shadow-position) 0px 15px -10px var(--uc-sidebar-shadow-color); } #sidebar-box[positionend="true"] { - box-shadow: -1px 0px 15px -10px var(--uc-sidebar-shadow-color); + --uc-sidebar-shadow-position: calc(-1 * var(--uc-sidebar-shadow-position-default)); } #sidebar { display: block; @@ -6896,6 +6900,7 @@ #sidebar-box { margin-inline-start: var(--uc-sidebar-activate-width-reverse) !important; will-change: padding-inline; + --uc-sidebar-shadow-width: var(--uc-sidebar-activate-width); } #sidebar-box:not([hidden="true"]) { padding-inline-start: var(--uc-sidebar-activate-width) !important; @@ -6903,7 +6908,7 @@ @media (prefers-reduced-motion: no-preference) { #sidebar-box { transition: padding-inline-start 0.25s var(--animation-easing-function), opacity 0.25s ease-in-out, - visibility 0s linear !important; + box-shadow 0s linear, visibility 0s linear !important; } } } @@ -7571,17 +7576,22 @@ max-width: var(--uc-sidebar-width) !important; will-change: min-width, max-width; } + #sidebar-box:is(:hover, :focus-within) { + --uc-sidebar-shadow-width: calc(var(--uc-sidebar-activate-width) - var(--uc-sidebar-width)); + } #sidebar-box:is(:hover, :focus-within) > #sidebar-header, #sidebar-box:is(:hover, :focus-within) > #sidebar { min-width: var(--uc-sidebar-activate-width) !important; max-width: var(--uc-sidebar-activate-width) !important; } :root[inFullscreen="true"] #sidebar-box { + --uc-sidebar-shadow-width: var(--uc-sidebar-fullscreen-width); margin-inline-start: var(--uc-sidebar-activate-width-reverse) !important; padding-inline-start: var(--uc-sidebar-fullscreen-width); - will-change: padding-inline-start; + will-change: padding-inline-start, opacity, box-shadow, visibility; } :root[inFullscreen="true"] #sidebar-box:is(:hover, :focus-within) { + --uc-sidebar-shadow-width: var(--uc-sidebar-activate-width); padding-inline-start: var(--uc-sidebar-activate-width); } :root[inFullscreen="true"] #sidebar-box #sidebar-header, @@ -7596,13 +7606,22 @@ transition: min-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; } + #sidebar-box:is(:hover, :focus-within) { + transition: margin-inline-start var(--uc-autohide-sidebar-speed) var(--animation-easing-function), + opacity var(--uc-autohide-sidebar-speed) ease-in-out, + box-shadow var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-speed), + visibility 0s linear !important; + } #sidebar-box:is(:hover, :focus-within) > #sidebar-header, #sidebar-box:is(:hover, :focus-within) > #sidebar { transition-delay: 0ms !important; } :root[inFullscreen="true"] #sidebar-box { transition: padding-inline-start var(--uc-autohide-fullscreen-sidebar-speed) var(--animation-easing-function) - var(--uc-autohide-sidebar-delay) !important; + var(--uc-autohide-sidebar-delay), + opacity var(--uc-autohide-fullscreen-sidebar-speed) ease-in-out, + box-shadow calc(var(--uc-autohide-fullscreen-sidebar-speed) + 0.05s) var(--animation-easing-function), + visibility 0s linear !important; } :root[inFullscreen="true"] #sidebar-box:is(:hover, :focus-within) { transition-delay: 0ms !important; @@ -7638,7 +7657,8 @@ @media (prefers-reduced-motion: no-preference) { #sidebar-box { transition: min-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) - var(--uc-autohide-sidebar-delay) !important; + var(--uc-autohide-sidebar-delay), + max-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; } #sidebar-box:is(:hover, :focus-within) { transition-delay: 0ms !important; diff --git a/src/autohide/sidebar/_overlap.scss b/src/autohide/sidebar/_overlap.scss index 4a20e52..4ad310a 100644 --- a/src/autohide/sidebar/_overlap.scss +++ b/src/autohide/sidebar/_overlap.scss @@ -6,20 +6,28 @@ will-change: min-width, max-width; } -#sidebar-box:is(:hover, :focus-within) > { - #sidebar-header, - #sidebar { - min-width: var(--uc-sidebar-activate-width) !important; - max-width: var(--uc-sidebar-activate-width) !important; +#sidebar-box:is(:hover, :focus-within) { + --uc-sidebar-shadow-width: calc(var(--uc-sidebar-activate-width) - var(--uc-sidebar-width)); + + > { + #sidebar-header, + #sidebar { + min-width: var(--uc-sidebar-activate-width) !important; + max-width: var(--uc-sidebar-activate-width) !important; + } } } :root[inFullscreen="true"] #sidebar-box { + --uc-sidebar-shadow-width: var(--uc-sidebar-fullscreen-width); + margin-inline-start: var(--uc-sidebar-activate-width-reverse) !important; padding-inline-start: var(--uc-sidebar-fullscreen-width); - will-change: padding-inline-start; + will-change: padding-inline-start, opacity, box-shadow, visibility; &:is(:hover, :focus-within) { + --uc-sidebar-shadow-width: var(--uc-sidebar-activate-width); + padding-inline-start: var(--uc-sidebar-activate-width); } @@ -38,15 +46,22 @@ transition: min-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; } - #sidebar-box:is(:hover, :focus-within) > { - #sidebar-header, - #sidebar { - transition-delay: 0ms !important; + #sidebar-box:is(:hover, :focus-within) { + transition: margin-inline-start var(--uc-autohide-sidebar-speed) var(--animation-easing-function), opacity var(--uc-autohide-sidebar-speed) ease-in-out, + box-shadow var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-speed), visibility 0s linear !important; + > { + #sidebar-header, + #sidebar { + transition-delay: 0ms !important; + } } } :root[inFullscreen="true"] #sidebar-box { - transition: padding-inline-start var(--uc-autohide-fullscreen-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; + transition: padding-inline-start var(--uc-autohide-fullscreen-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay), + opacity var(--uc-autohide-fullscreen-sidebar-speed) ease-in-out, + box-shadow calc(var(--uc-autohide-fullscreen-sidebar-speed) + 0.05s) var(--animation-easing-function), + visibility 0s linear !important; &:is(:hover, :focus-within) { transition-delay: 0ms !important; diff --git a/src/autohide/sidebar/_static.scss b/src/autohide/sidebar/_static.scss index 41ff435..60f848a 100644 --- a/src/autohide/sidebar/_static.scss +++ b/src/autohide/sidebar/_static.scss @@ -32,7 +32,8 @@ @include Animate { #sidebar-box { - transition: min-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; + transition: min-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay), + max-width var(--uc-autohide-sidebar-speed) var(--animation-easing-function) var(--uc-autohide-sidebar-delay) !important; &:is(:hover, :focus-within) { transition-delay: 0ms !important; diff --git a/src/sidebar/_overlap.scss b/src/sidebar/_overlap.scss index 953cb48..4fdcc19 100644 --- a/src/sidebar/_overlap.scss +++ b/src/sidebar/_overlap.scss @@ -10,6 +10,10 @@ --uc-sidebar-activate-width: 18em; --uc-sidebar-activate-width-reverse: calc(-1 * var(--uc-sidebar-activate-width)); --uc-sidebar-fullscreen-width: 4px; + --uc-sidebar-shadow-size: 1px; + --uc-sidebar-shadow-width: 0px; + --uc-sidebar-shadow-position: var(--uc-sidebar-shadow-position-default); + --uc-sidebar-shadow-position-default: calc(var(--uc-sidebar-shadow-size) + var(--uc-sidebar-shadow-width)); --uc-sidebar-shadow-color: #28282F; --uc-autohide-sidebar-speed: 750ms; @@ -19,9 +23,9 @@ z-index: 1 !important; position: relative !important; - box-shadow: 1px 0px 15px -10px var(--uc-sidebar-shadow-color); + box-shadow: var(--uc-sidebar-shadow-position) 0px 15px -10px var(--uc-sidebar-shadow-color); &[positionend="true"] { - box-shadow: -1px 0px 15px -10px var(--uc-sidebar-shadow-color); + --uc-sidebar-shadow-position: calc(-1 * var(--uc-sidebar-shadow-position-default)); } } @@ -66,13 +70,14 @@ margin-inline-start: var(--uc-sidebar-activate-width-reverse) !important; will-change: padding-inline; + --uc-sidebar-shadow-width: var(--uc-sidebar-activate-width); &:not([hidden="true"]) { padding-inline-start: var(--uc-sidebar-activate-width) !important; } @include Animate { transition: padding-inline-start 0.25s var(--animation-easing-function), opacity 0.25s ease-in-out, - visibility 0s linear !important; + box-shadow 0s linear, visibility 0s linear !important; } } } From 6b7abd21db7a972d25950cc38e3f008abfce27be Mon Sep 17 00:00:00 2001 From: ryenyuku Date: Sun, 4 Dec 2022 17:45:49 +0700 Subject: [PATCH 10/18] Add: FFHome - Add the ability to hide Firefox's logo --- css/leptonContent.css | 9 +++++++++ user.js | 2 ++ 2 files changed, 11 insertions(+) diff --git a/css/leptonContent.css b/css/leptonContent.css index 18ebc63..073d6ea 100644 --- a/css/leptonContent.css +++ b/css/leptonContent.css @@ -442,6 +442,15 @@ fill: var(--newtab-icon-secondary-color) !important; } } + /** Activity Stream - Hide Firefox's logo ***********************************/ + @supports -moz-bool-pref("userContent.newTab.hide_logo") { + .logo-and-wordmark { + display: none !important; + } + .outer-wrapper:not(.fixed-search) .search-wrapper { + padding-top: 0 !important; + } + } } /** Error Page - Restore illustrations ****************************************/ @supports -moz-bool-pref("userContent.page.illustration") { diff --git a/user.js b/user.js index 1237c1e..a3c9303 100644 --- a/user.js +++ b/user.js @@ -158,6 +158,8 @@ user_pref("userChrome.rounding.square_tab", false); // -- User Content ------------------------------------------------------------- // user_pref("userContent.player.ui.twoline", true); +// user_pref("userContent.newTab.hide_logo", true); + // user_pref("userContent.page.proton_color.dark_blue_accent", true); // user_pref("userContent.page.proton_color.system_accent", true); // user_pref("userContent.page.monospace", true); From bb69ddcf3b5489dab4c11495bbb440e797452184 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 5 Dec 2022 03:35:31 +0900 Subject: [PATCH 11/18] Fix: Activity Stream - `userContent.newTab.hide_logo` -> `userContent.newTab.hidden_logo` --- css/leptonContent.css | 2 +- src/contents/_activity_stream.scss | 10 ++++++++++ user.js | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/css/leptonContent.css b/css/leptonContent.css index 073d6ea..2716402 100644 --- a/css/leptonContent.css +++ b/css/leptonContent.css @@ -443,7 +443,7 @@ } } /** Activity Stream - Hide Firefox's logo ***********************************/ - @supports -moz-bool-pref("userContent.newTab.hide_logo") { + @supports -moz-bool-pref("userContent.newTab.hidden_logo") { .logo-and-wordmark { display: none !important; } diff --git a/src/contents/_activity_stream.scss b/src/contents/_activity_stream.scss index 9fe952b..14f2983 100644 --- a/src/contents/_activity_stream.scss +++ b/src/contents/_activity_stream.scss @@ -193,4 +193,14 @@ } } } + + /** Activity Stream - Hide Firefox's logo ***********************************/ + @include Option("userContent.newTab.hidden_logo") { + .logo-and-wordmark { + display: none !important; + } + .outer-wrapper:not(.fixed-search) .search-wrapper { + padding-top: 0 !important; + } + } } diff --git a/user.js b/user.js index a3c9303..9ef5620 100644 --- a/user.js +++ b/user.js @@ -158,7 +158,7 @@ user_pref("userChrome.rounding.square_tab", false); // -- User Content ------------------------------------------------------------- // user_pref("userContent.player.ui.twoline", true); -// user_pref("userContent.newTab.hide_logo", true); +// user_pref("userContent.newTab.hidden_logo", true); // user_pref("userContent.page.proton_color.dark_blue_accent", true); // user_pref("userContent.page.proton_color.system_accent", true); From 15145d3734de63b67d83e17c48aaaefc92642374 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 5 Dec 2022 03:38:52 +0900 Subject: [PATCH 12/18] Doc: CREDITS - Update #524 --- CREDITS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CREDITS b/CREDITS index 99f685f..31a0104 100644 --- a/CREDITS +++ b/CREDITS @@ -115,6 +115,10 @@ W: https://github.com/Nyubis N: roland-rollo W: https://github.com/roland-rollo +N: ryenyuku +E: teamworks1732@gmail.com +W: https://github.com/ryenyuku + N: SanderTheDragon E: sanderthedragon@zoho.com W: https://gitlab.com/SanderTheDragon From 41c071b26e597f78f58126e74466741cfbb86e55 Mon Sep 17 00:00:00 2001 From: MS_Y Date: Tue, 6 Dec 2022 01:53:38 +0900 Subject: [PATCH 13/18] Doc: Preference - EBNF highlight fix --- docs/Preference.md | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/docs/Preference.md b/docs/Preference.md index 116cb0e..5c94d1e 100644 --- a/docs/Preference.md +++ b/docs/Preference.md @@ -50,25 +50,26 @@ The following is a method of operating the configuration file parser. See [EBNF (Extended Backus-Naur form)](https://en.wikipedia.org/wiki/Extended_Backus%E2%80%93Naur_form) if you want to know about syntax. ```ebnf - = * - = "(" "," ")" ";" - = "user_pref" | "pref" | "sticky_pref" // in default pref files - = "user_pref" // in user pref files - = - = | "true" | "false" | - = ? - = "+" | "-" - = [0-9]+ (and cannot be followed by [A-Za-z_]) - = + = *; + = "(" "," ")" ";"; + = "user_pref" | "pref" | "sticky_pref"; (* in default pref files *) + = "user_pref"; (* in user pref files *) + = ; + = | "true" | "false" | ; + = ? ; + = "+" | "-"; + = [0-9]+ (and cannot be followed by [A-Za-z_]); + = ? A single or double-quoted string, with the following escape sequences - allowed: \", \', \\, \n, \r, \xNN, \uNNNN, where \xNN gives a raw byte - value that is copied directly into an 8-bit string value, and \uNNNN + allowed: "\"", "\'" "\\", "\n", "\r", "\xNN", "\uNNNN", where "\xNN" gives a raw byte + value that is copied directly into an 8-bit string value, and "\uNNNN" gives a UTF-16 code unit that is converted to UTF-8 before being copied - into an 8-bit string value. \x00 and \u0000 are disallowed because they + into an 8-bit string value. "\x00" and "\u0000" are disallowed because they would cause C++ code handling such strings to misbehave. - = ("," )* // in default pref files - = // in user pref files - = "sticky" | "locked" // default pref files only +?; + = ("," )* (* in default pref files *) + = ; (* in user pref files *) + = "sticky" | "locked"; (* default pref files only *) ``` ## Default Config From 143790b3593beaacd99945b328be6ecd234f05a1 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 6 Dec 2022 02:35:54 +0900 Subject: [PATCH 14/18] Fix: Contents - Unify `newTab.field_border` -> `page.field_border` --- user.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user.js b/user.js index 9ef5620..a9e843f 100644 --- a/user.js +++ b/user.js @@ -222,12 +222,12 @@ user_pref("userContent.player.size", true); user_pref("userContent.player.click_to_play", true); user_pref("userContent.player.animate", true); -user_pref("userContent.newTab.field_border", true); user_pref("userContent.newTab.full_icon", true); user_pref("userContent.newTab.animate", true); user_pref("userContent.newTab.pocket_to_last", true); user_pref("userContent.newTab.searchbar", true); +user_pref("userContent.page.field_border", true); user_pref("userContent.page.illustration", true); user_pref("userContent.page.proton_color", true); user_pref("userContent.page.dark_mode", true); // Need proton_color From 30e3219e007b43c49fb14f4f655b6c0287ca15d9 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 6 Dec 2022 02:50:03 +0900 Subject: [PATCH 15/18] Fix: Separator - Remove first tab separator --- css/leptonChrome.css | 1 - src/tab/unselected_tab/_dynamic_separator.scss | 1 - 2 files changed, 2 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 3862cfe..2fc97f5 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -6048,7 +6048,6 @@ } } @supports not -moz-bool-pref("userChrome.tab.newtab_button_like_tab") { - #tabbrowser-arrowscrollbox:not([overflowing]) .tabbrowser-tab[first-visible-unpinned-tab] .tab-background::before, #tabbrowser-arrowscrollbox:not([overflowing]) .tabbrowser-tab:not([visuallyselected], [multiselected], :hover)[last-visible-tab] .tab-background::after { diff --git a/src/tab/unselected_tab/_dynamic_separator.scss b/src/tab/unselected_tab/_dynamic_separator.scss index ba59667..071ceae 100644 --- a/src/tab/unselected_tab/_dynamic_separator.scss +++ b/src/tab/unselected_tab/_dynamic_separator.scss @@ -85,7 +85,6 @@ } } @include NotOption("userChrome.tab.newtab_button_like_tab") { - #tabbrowser-arrowscrollbox:not([overflowing]) .tabbrowser-tab[first-visible-unpinned-tab] .tab-background::before, #tabbrowser-arrowscrollbox:not([overflowing]) .tabbrowser-tab:not([visuallyselected], [multiselected], :hover)[last-visible-tab] .tab-background::after { From cb83f1b45213985dd57a73df3dbc7c57d689032c Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Tue, 6 Dec 2022 03:14:18 +0900 Subject: [PATCH 16/18] Fix: Centered Label - Prevent overflow and unwinding #508 This is next commit's follow-up. https://github.com/black7375/Firefox-UI-Fix/commit/8ffcd5469786ab1e6806e190a9b1a732a8aba0fc --- css/leptonChrome.css | 2 +- src/centered/tab/_label.scss | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/css/leptonChrome.css b/css/leptonChrome.css index 2fc97f5..48042c2 100644 --- a/css/leptonChrome.css +++ b/css/leptonChrome.css @@ -6971,7 +6971,7 @@ } .tab-label, .tab-secondary-label { - overflow: hidden; + overflow: clip; } .tabbrowser-tab[selected]:not(:hover) .tab-label-container:not([textoverflow]), .tabbrowser-tab:not(:hover, [pinned]) .tab-label-container:not([textoverflow]) { diff --git a/src/centered/tab/_label.scss b/src/centered/tab/_label.scss index b5b25d0..1cdb5dc 100644 --- a/src/centered/tab/_label.scss +++ b/src/centered/tab/_label.scss @@ -6,10 +6,10 @@ } .tab-label, .tab-secondary-label { - overflow: hidden; + overflow: clip; } .tabbrowser-tab[selected]:not(:hover) .tab-label-container:not([textoverflow]), .tabbrowser-tab:not(:hover,[pinned]) .tab-label-container:not([textoverflow]) { - margin-inline-end: 5px; + margin-inline-end: 5px; // userChrome.tab.close_button_at_hover 6px - 1px } From 752eb05d7b7eab472dfa7915e34cb423dac282fa Mon Sep 17 00:00:00 2001 From: MS_Y Date: Wed, 7 Dec 2022 05:49:48 +0900 Subject: [PATCH 17/18] Doc: README - Image size --- README.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.org b/README.org index 42fcdb5..5940485 100644 --- a/README.org +++ b/README.org @@ -194,7 +194,7 @@ Thanks to all sponsors & contributors to this project for providing help and dev [[https://www.oss.kr/][https://user-images.githubusercontent.com/25581533/203210367-9f2eed69-666a-4218-acde-128892aa09d8.png]] [[https://github.com/ojaha065][@@html:@@]] -[[https://github.com/kanlukasz][@@html:@@]] +[[https://github.com/kanlukasz][@@html:@@]] [[https://github.com/nikkehtine][@@html:@@]] *Contributors* From 4aed52213553c09cf492276e62e585a4170a4a0a Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Wed, 7 Dec 2022 11:47:23 +0900 Subject: [PATCH 18/18] Doc: Templates - Convert to Issue form, PR template update `Github Form` does not yet support `Pull request` and `Discussions`. --- .github/ISSUE_TEMPLATE/bug_report.md | 49 ------- .github/ISSUE_TEMPLATE/bug_report.yml | 143 +++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 23 ---- .github/ISSUE_TEMPLATE/feature_request.yml | 49 +++++++ .github/pull_request_template.md | 21 ++- 5 files changed, 200 insertions(+), 85 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml delete mode 100644 .github/ISSUE_TEMPLATE/feature_request.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md deleted file mode 100644 index 1c0f338..0000000 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ /dev/null @@ -1,49 +0,0 @@ ---- -name: Bug report -about: Create a report to help us improve -title: '' -labels: Issue::Bug -assignees: '' - ---- - -**Describe the bug** - - -**Expected behavior** - - -**Screenshots** - - -**Environment:** - - - Distribution - - [ ] [Original Lepton](https://github.com/black7375/Firefox-UI-Fix) - - [ ] [Lepton's photon style](https://github.com/black7375/Firefox-UI-Fix/tree/photon-style) - - [ ] [Lepton's proton style](https://github.com/black7375/Firefox-UI-Fix/tree/proton-style) - - Firefox Version: - - OS: - - [ ] Linux - - [ ] Windows - - [ ] Mac - - [ ] Other: - - Theme: - - [ ] Light - - [ ] Dark - - [ ] Alpenglow (System: Light) - - [ ] Alpenglow (System: Dark) - - [ ] System Default - - GTK Theme Name (Linux only): - - [ ] Other: (e.g. [Photon Colors](https://addons.mozilla.org/en-US/firefox/addon/photon-colors/), [Google Chrome Dark](https://addons.mozilla.org/en-US/firefox/addon/google-chrome-dark/), [Fairytale Of Nature](https://addons.mozilla.org/en-US/firefox/addon/fairytale-of-nature/)) - -
user.js setup
- - -```javascript -// Your settings -``` -
- -**Additional context** - diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 0000000..ec78dfa --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,143 @@ +name: Bug report +description: Create a report to help us improve +labels: ["Issue::Bug"] + +body: +# == Bug Infos ================================================================= + - type: markdown + id: bug-infos + attributes: + value: "## Bug Infos" + - type: textarea + id: describe-the-bug + attributes: + label: Describe the bug + description: A clear and concise description of what the bug is. + placeholder: Tell us what you see! + validations: + required: true + + - type: textarea + id: expected-behavior + attributes: + label: Expected behavior + description: A clear and concise description of what you expected to happen. + placeholder: Tell us what you want! + validations: + required: false + + - type: textarea + id: screenshots + attributes: + label: Screenshots + description: If is helpful to attach screenshots or video similar to the desired features. + placeholder: Drag or paste images or videos to upload + validations: + required: false + +# == Environments =============================================================== + - type: markdown + id: environments + attributes: + value: "## Environments" + + - type: dropdown + id: os + attributes: + label: OS + options: + - Linux + - Mac OS + - Windows 11 + - Windows 10 + - Windows 8 + - Windows 7 + - Others + multiple: true + validations: + required: true + - type: input + id: os-others + attributes: + label: OS - Others + description: Enter only if you choose `Others` from the OS + placeholder: e.g. FreeBSD + validations: + required: false + + - type: input + id: firefox-version + attributes: + label: Firefox Version + description: Write from `about:support` - `version` + placeholder: e.g. v101.1b3 + validations: + required: true + + - type: checkboxes + id: distribution + attributes: + label: Distribution + options: + - label: "[Original Lepton](https://github.com/black7375/Firefox-UI-Fix)" + - label: "[Lepton's photon style](https://github.com/black7375/Firefox-UI-Fix/tree/photon-style)" + - label: "[Lepton's proton style](https://github.com/black7375/Firefox-UI-Fix/tree/proton-style)" + validations: + required: true + + - type: checkboxes + id: theme + attributes: + label: Theme + options: + - label: "Light" + - label: "Dark" + - label: "Alpenglow (System: Light)" + - label: "Alpenglow (System: Dark)" + - label: "System Default" + - label: "Others: (e.g. [Photon Colors](https://addons.mozilla.org/en-US/firefox/addon/photon-colors/), [Google Chrome Dark](https://addons.mozilla.org/en-US/firefox/addon/google-chrome-dark/), [Fairytale Of Nature](https://addons.mozilla.org/en-US/firefox/addon/fairytale-of-nature/))" + validations: + required: true + - type: textarea + id: theme-more-info + attributes: + label: Theme - More Info + description: | + Enter only for the following cases: + + - Choose `System Default` with linux users + Tip: Run `gsettings get org.gnome.desktop.interface gtk-theme` to output this + - Choose `Others` + placeholder: | + Example for each case + + - Adwaita, Adwaita-Dark, Breath, Breath-Dark + - Your theme links like https://addons.mozilla.org/en-US/firefox/addon/photon-colors/ + validations: + required: false + + - type: textarea + id: user-js-setup + attributes: + label: "`user.js` setup" + description: | + Your `user.js` or `about:config` settings + placeholder: Please tell me your settings + value: | +
user.js setup
+ + ```javascript + // Your settings + ``` +
+ validations: + required: true + + - type: textarea + id: additional-context + attributes: + label: Additional context + description: Add any other context about the problem here. + placeholder: Anything to write down or refer to is fine + validations: + required: false diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md deleted file mode 100644 index 9b544b9..0000000 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: Feature request -about: Suggest an idea for this project -title: '' -labels: 'Issue::Enhancement' -assignees: '' - ---- - -**Is your feature request related to a problem?** - - -**The solution I'd like** - - -**Screenshots or video** - - -**Alternatives I've considered** - - -**Additional context** - diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml new file mode 100644 index 0000000..39e42a0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -0,0 +1,49 @@ +name: Feature request +description: Suggest an idea for this project +labels: ["Issue::Enhancement"] + +body: + - type: textarea + id: problem + attributes: + label: Is your feature request related to a problem? + description: A clear and concise description of what the problem is. + placeholder: Ex. I don't like this design that [...] + validations: + required: true + + - type: textarea + id: solution + attributes: + label: The solution I'd like + description: A clear and concise description of what you want to happen. + placeholder: Tell us what you want! + validations: + required: true + + - type: textarea + id: screenshots + attributes: + label: Screenshots or video + description: It is helpful to attach screenshots or video similar to the desired features. + placeholder: You can drag & drop to attach files + validations: + required: false + + - type: textarea + id: alternatives + attributes: + label: Alternatives I've considered + description: A clear and concise description of any alternative solutions or features you've considered. + placeholder: It would be great if you have a relevant image or link + validations: + required: false + + - type: textarea + id: additional-context + attributes: + label: Additional context + description: Add any other context or screenshots about the feature request here. + placeholder: Anything to write down or refer to is fine + validations: + required: false diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d1da789..c570874 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,24 +1,19 @@ **Describe the PR** +**PR Type** + + +- [ ] `Add:` Add feature or enhanced. +- [ ] `Fix:` Bug fix or change default values. +- [ ] `Clean:` Refactoring. +- [ ] `Doc:` Update docs. + **Related Issue** **Screenshots** -**Environment (please complete the following information):** - - - - PR Type - - [ ] `Add:` Add feature or enhanced. - - [ ] `Fix:` Bug fix or change default values. - - [ ] `Clean:` Refactoring. - - [ ] `Doc:` Update docs. - - Distribution - - [ ] [Original Lepton](https://github.com/black7375/Firefox-UI-Fix) - - [ ] [Lepton's photon style](https://github.com/black7375/Firefox-UI-Fix/tree/photon-style) - - [ ] [Lepton's proton style](https://github.com/black7375/Firefox-UI-Fix/tree/proton-style) - **Additional context**