From 9349c8e6f1a0243e099354653e32c696f9f251ce Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 14:55:40 +0900 Subject: [PATCH 01/12] Add: Tab Height - compact reduce padding --- userChrome.css | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/userChrome.css b/userChrome.css index e3c3f84..8152db9 100644 --- a/userChrome.css +++ b/userChrome.css @@ -61,9 +61,12 @@ --toolbarbutton-inner-padding: 9px; /* Original: calc((var(--tab-min-height) - 16px) / 2) = 10px */ } - :root .toolbar-items, .tabbrowser-tab { + .toolbar-items, .tabbrowser-tab { max-height: 38px; } + :root[uidensity=compact] .toolbar-items, .tabbrowser-tab { + max-height: 36px; + } :root[uidensity=touch] .toolbar-items, .tabbrowser-tab { max-height: unset; } From 88029c7fd748e691ff4e4f6e71a4a37ba27d1395 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 15:10:07 +0900 Subject: [PATCH 02/12] Doc: bug report issue template --- .github/ISSUE_TEMPLATE/bug_report.md | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..73ee265 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,34 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Environment (please complete the following information):** + - OS: + - [ ] Linux + - [ ] Windows + - [ ] Mac + - [ ] Others: + - Theme: + - [ ] Light + - [ ] Dark + - [ ] Alpenglow(System: Light) + - [ ] Alpenglow(System: Dark) + - [ ] System Default + - GTK Theme Name(Only Linux User): ex) Adwaita, Adwaita-Dark, Breath, Breath-Dark + +**Additional context** +Add any other context about the problem here. From 28ee89681f3d3187a3f83ec8300721c48472c1da Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 15:13:04 +0900 Subject: [PATCH 03/12] Doc: fix bug issue format --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 73ee265..d6d54f8 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -28,7 +28,7 @@ If applicable, add screenshots to help explain your problem. - [ ] Alpenglow(System: Light) - [ ] Alpenglow(System: Dark) - [ ] System Default - - GTK Theme Name(Only Linux User): ex) Adwaita, Adwaita-Dark, Breath, Breath-Dark + - GTK Theme Name(Only Linux User): [sample] Adwaita, Adwaita-Dark, Breath, Breath-Dark **Additional context** Add any other context about the problem here. From e407f5d965abb362b90fe51d1eb061b3027131be Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 16:25:06 +0900 Subject: [PATCH 04/12] Add: Usercontent - Darkmode case --- userContent.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/userContent.css b/userContent.css index 3fe8bd4..a155e81 100644 --- a/userContent.css +++ b/userContent.css @@ -2,7 +2,8 @@ @-moz-document url("about:home"), url("about:newtab") { /** Activity Stream - Search Focus Border: like URL ***********************/ /* At DarkMode, Color */ - body[style*="--newtab-background-color:rgba(28, 27, 34, 1);"] { + body[style*="--newtab-background-color:rgba(28, 27, 34, 1);"], + body[style*="--newtab-background-color:rgba(42, 42, 46, 1);"] { /* inner */ --newtab-focus-border: rgba(0, 221, 255, 0.5) !important; /* Original: #B5D3FF, Better color-mix(in srgb, #B5D3FF 70%, transparent) */ --newtab-focus-border-selected: rgba(0, 221, 255, 0.5) !important; /* Original: #B5D3FF */ From 5851de926ba7e52766311b73433634e59e7b67dc Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 16:25:45 +0900 Subject: [PATCH 05/12] Fix: Tab Bar - Scrollbutton Size Up --- userChrome.css | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/userChrome.css b/userChrome.css index 8152db9..6df6b1c 100644 --- a/userChrome.css +++ b/userChrome.css @@ -71,6 +71,13 @@ max-height: unset; } + :root:not([uidensity=touch]) #tabbrowser-arrowscrollbox::part(scrollbutton-up), + :root:not([uidensity=touch]) #tabbrowser-arrowscrollbox::part(scrollbutton-down) { + /* Original: var(--toolbarbutton-inner-padding) calc(var(--toolbarbutton-inner-padding) - 6px) = 9px */ + padding-top: 3px !important; + padding-bottom: 3px !important; + } + /* Tab - Max Size */ :root:not([uidensity=touch]) .tabbrowser-tab[fadein]:not([pinned]):not([style*="max-width"]) { max-width: 240px !important; From 560725b24c7f67c25fe80c03cb2c2cd8a9beb710 Mon Sep 17 00:00:00 2001 From: MS_Y Date: Sat, 8 May 2021 07:39:28 +0000 Subject: [PATCH 06/12] Doc: screenshot update --- README.org | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.org b/README.org index d67af16..930c9a1 100644 --- a/README.org +++ b/README.org @@ -4,7 +4,7 @@ [[https://github.com/black7375/Firefox-UI-Fix/wiki/Compatibility-Issues-Solution][Wiki:Compatibility Issues Solution]] - [[https://user-images.githubusercontent.com/25581533/116832632-4295d000-aba5-11eb-9f4e-33e5291f95ef.png]] + [[https://user-images.githubusercontent.com/25581533/117531080-49bb4480-afd0-11eb-8b6a-f04559ed2ab7.png]] (Fixed proton design) @@ -59,7 +59,7 @@ ** WHY Not Proton? However, there are also many flaws. - [[https://user-images.githubusercontent.com/25581533/116832636-46295700-aba5-11eb-87d6-d837c2b20318.png]] + [[https://user-images.githubusercontent.com/25581533/117529680-69e70580-afc8-11eb-8ecb-bd1e0cfc1e97.png]] (proton before design) From 33a66aa1f03f16a9721c5fab959dd652935da88f Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Sat, 8 May 2021 19:06:55 +0900 Subject: [PATCH 07/12] Add: Bookmark Bar - Reduce height at compact mode --- userChrome.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/userChrome.css b/userChrome.css index 6df6b1c..cbac8b2 100644 --- a/userChrome.css +++ b/userChrome.css @@ -204,6 +204,11 @@ padding-block: 2px; /* [Compact, General]: 4px, Touch 11px */ } + /** BookMark Bar - Reduce Height ********************************************/ + :root[uidensity=compact] #PersonalToolbar toolbarbutton { + margin-top: 0px; /* Original: 2px */ + } + /** Menu - Reduce Padding ***************************************************/ :root:not([uidensity=touch]) menupopup > menuitem, menupopup > menu { padding-block: 0.35em !important; /* Original: 0.5em */ From bb9ff6a73ddc7be9f2384c22ff30f376568a1879 Mon Sep 17 00:00:00 2001 From: MS_Y Date: Sat, 8 May 2021 10:30:28 +0000 Subject: [PATCH 08/12] Doc: update wiki link --- README.org | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.org b/README.org index 930c9a1..22890de 100644 --- a/README.org +++ b/README.org @@ -2,7 +2,8 @@ [[https://wiki.mozilla.org/Firefox/Proton][proton]] is firefox's new design. \\ I want to fix some flaws. - [[https://github.com/black7375/Firefox-UI-Fix/wiki/Compatibility-Issues-Solution][Wiki:Compatibility Issues Solution]] + | *Wiki* | | + | [[https://github.com/black7375/Firefox-UI-Fix/wiki/Screenshots][Screenshots]] | [[https://github.com/black7375/Firefox-UI-Fix/wiki/Compatibility-Issues-Solution][Compatibility Issues Solution]] | [[https://user-images.githubusercontent.com/25581533/117531080-49bb4480-afd0-11eb-8b6a-f04559ed2ab7.png]] From da0d540dddd62a1a56ce6627b2b5d8b3fc83b27a Mon Sep 17 00:00:00 2001 From: BlaCk_Void Date: Sun, 9 May 2021 15:51:31 +0900 Subject: [PATCH 09/12] Clean: code style --- userChrome.css | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/userChrome.css b/userChrome.css index 634aac6..d2502a2 100644 --- a/userChrome.css +++ b/userChrome.css @@ -4,14 +4,14 @@ --toolbar-bgcolor: rgba(43, 42, 51, 5) !important; } - :root{ + :root { /* Tab Bar */ --proton-tab-block-margin: 2px !important; /* Original: 4px */ --inline-tab-padding: 6px !important; /* Original: 8px */ /* Panel */ --arrowpanel-menuitem-margin: 0 8px !important; /* Original: 0 8px */ - --arrowpanel-menuitem-padding: 4px !important; /* Original: 8px */ + --arrowpanel-menuitem-padding: 4px !important; /* Original: 8px */ --arrowpanel-padding: 0.8em !important; /* Original: 16px or .cui-widget-panel, .cui-widget-panel::part(arrowcontent) => 4px 0 */ } @@ -23,9 +23,10 @@ width: 20px; /* Original: 40px */ } - #tabbrowser-arrowscrollbox::part(scrollbutton-up), #tabbrowser-arrowscrollbox::part(scrollbutton-down) { + #tabbrowser-arrowscrollbox::part(scrollbutton-up ), + #tabbrowser-arrowscrollbox::part(scrollbutton-down) { /* Original: 4px */ - padding-left: 1px; + padding-left: 1px; padding-right: 1px; } @@ -43,8 +44,7 @@ } /* Tab - Max Size */ - .tabbrowser-tab[fadein]:not([pinned]):not([style*="max-width"]) - { + .tabbrowser-tab[fadein]:not([pinned]):not([style*="max-width"]) { max-width: 240px !important; } @@ -59,7 +59,7 @@ } .tab-stack { - margin-top: 0px !important; + margin-top: 0px !important; margin-bottom: 0px !important; } @@ -68,8 +68,7 @@ padding-inline: 1px !important; } - .tabbrowser-tab:not([last-visible-tab]) - { + .tabbrowser-tab:not([last-visible-tab]) { margin-inline-end: -.5px !important; } @@ -83,7 +82,8 @@ } /* Selected Tab - Box Shadow */ - #TabsToolbar[brighttext] #tabbrowser-tabs:not([noshadowfortests]) .tabbrowser-tab:is([visuallyselected="true"], [multiselected]) > .tab-stack > .tab-background:-moz-lwtheme { + #TabsToolbar[brighttext] #tabbrowser-tabs:not([noshadowfortests]) .tabbrowser-tab:is([visuallyselected="true"], + [multiselected]) > .tab-stack > .tab-background:-moz-lwtheme { box-shadow: 0 0 1px var(--toolbar-color) !important; } @@ -104,7 +104,6 @@ .tab-content::before { left: 0 !important; } - .tab-content::after { right: 0 !important; } @@ -119,13 +118,11 @@ } /* Clipped tabs - Letters cleary */ - #tabbrowser-tabs[closebuttons=activetab] .tab-content:not([pinned]) - { + #tabbrowser-tabs[closebuttons=activetab] .tab-content:not([pinned]) { padding-inline-start: 8px !important; } - #tabbrowser-tabs[closebuttons=activetab] .tabbrowser-tab:not([visuallyselected]) .tab-close-button - { + #tabbrowser-tabs[closebuttons=activetab] .tabbrowser-tab:not([visuallyselected]) .tab-close-button { visibility: collapse !important; } @@ -143,7 +140,9 @@ /* Sound Tab - Show with Favicons */ /* Makes the favicons always visible (also on hover) */ - #tabbrowser-tabs[secondarytext-unsupported] .tab-icon-stack:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]) > :not(.tab-icon-overlay), #toolbar-menubar:not(:hover) + #TabsToolbar:not(:hover) #tabbrowser-tabs:not([secondarytext-unsupported]) .tab-icon-image[src] ~ .tab-icon-overlay:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]), :is(#toolbar-menubar:hover + #TabsToolbar, #TabsToolbar:hover) .tab-icon-stack:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]) > :not(.tab-icon-overlay) { + #tabbrowser-tabs[secondarytext-unsupported] .tab-icon-stack:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]) > :not(.tab-icon-overlay), #toolbar-menubar:not(:hover) + #TabsToolbar:not(:hover) #tabbrowser-tabs:not([secondarytext-unsupported]) .tab-icon-image[src] ~ .tab-icon-overlay:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]), + :is(#toolbar-menubar:hover + #TabsToolbar, #TabsToolbar:hover) .tab-icon-stack:not([pinned], [sharing], [crashed]):is([soundplaying], [muted], [activemedia-blocked]) > :not(.tab-icon-overlay) + { opacity: 1 !important; } From c89587a170f14b231b54232dc1bb8e7a4bccdf38 Mon Sep 17 00:00:00 2001 From: BlaCk_Void Date: Sun, 9 May 2021 15:58:12 +0900 Subject: [PATCH 10/12] Fix: titlebar spacer width --- userChrome.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/userChrome.css b/userChrome.css index a8b9a32..8cea7ae 100644 --- a/userChrome.css +++ b/userChrome.css @@ -35,10 +35,10 @@ /** Tab Bar - Reduce Width, Show more tabs **********************************/ .titlebar-spacer[type="pre-tabs"] { - width: 35px; /* Original: 40px */ + width: 30px; /* Original: 40px */ } .titlebar-spacer[type="post-tabs"] { - width: 20px; /* Original: 40px */ + width: 25px; /* Original: 40px */ } :root[uidensity=compact] #tabbrowser-tabs[haspinnedtabs]:not([positionpinnedtabs]) > #tabbrowser-arrowscrollbox > .tabbrowser-tab[first-visible-unpinned-tab] { From b8c9fd9c3356a67f2255c0ffd6d79a8ebfc0c59b Mon Sep 17 00:00:00 2001 From: BlaCk_Void Date: Sun, 9 May 2021 16:02:29 +0900 Subject: [PATCH 11/12] Add: New Tab Button, All Tab Button - reduce padding --- userChrome.css | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/userChrome.css b/userChrome.css index 8cea7ae..a999701 100644 --- a/userChrome.css +++ b/userChrome.css @@ -41,6 +41,21 @@ width: 25px; /* Original: 40px */ } + :root { + --newtab-button-minus-width-padding: 2px; + --newtab-button-width-padding: calc(var(--toolbarbutton-inner-padding) - var(--newtab-button-minus-width-padding)); + } + #tabs-newtab-button > .toolbarbutton-icon, + #new-tab-button > .toolbarbutton-icon, + #alltabs-button > .toolbarbutton-badge-stack { + /* Original: calc(2 * var(--toolbarbutton-inner-padding) + 16px) */ + width: calc(2 * var(--newtab-button-width-padding) + 16px); + + /* Original: --toolbarbutton-inner-padding */ + padding-left: var(--newtab-button-width-padding); + padding-right: var(--newtab-button-width-padding); + } + :root[uidensity=compact] #tabbrowser-tabs[haspinnedtabs]:not([positionpinnedtabs]) > #tabbrowser-arrowscrollbox > .tabbrowser-tab[first-visible-unpinned-tab] { margin-inline-start: 0 !important; } From db318dfc303ede603e33c68befb15d0f2bc8f2b3 Mon Sep 17 00:00:00 2001 From: alstjr7375 Date: Mon, 10 May 2021 09:33:59 +0900 Subject: [PATCH 12/12] Fix: typo --- userChrome.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/userChrome.css b/userChrome.css index a999701..241c044 100644 --- a/userChrome.css +++ b/userChrome.css @@ -18,7 +18,7 @@ :root[uidensity=compact] { /* Tool Bar */ - --toolbarbutton-outter-padding: 2px !important; /* Original: 3px, General is 2px */ + --toolbarbutton-outer-padding: 2px !important; /* Original: 3px, General is 2px */ /* Panel */ --arrowpanel-menuitem-padding: 2px !important; /* Original: 8px */