Merge branch 'master' into empty-numerical-ingredient-error

.editorconfig

@@ -12,3 +12,7 @@ indent_size = 4
 [{package.json,.travis.yml,nightwatch.json}]
 indent_style = space
 indent_size = 2
+
+[.github/**.yml]
+indent_style = space
+indent_size = 2

.github/workflows/codeql.yml

@@ -1,40 +0,0 @@
-name: "CodeQL Analysis"
-
-on:
-  workflow_dispatch:
-  push:
-    branches: [ master ]
-  pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [ master ]
-    types: [synchronize, opened, reopened]
-  schedule:
-    - cron: '22 17 * * 5'
-
-jobs:
-  analyze:
-    name: Analyze
-    runs-on: ubuntu-latest
-    permissions:
-      actions: read
-      contents: read
-      security-events: write
-
-    strategy:
-      fail-fast: false
-      matrix:
-        language: [ 'javascript' ]
-
-    steps:
-    - name: Checkout repository
-      uses: actions/checkout@v3
-
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
-      with:
-        languages: ${{ matrix.language }}
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
-      with:
-        category: "/language:${{matrix.language}}"

.github/workflows/master.yml

@@ -1,58 +1,64 @@
 name: "Master Build, Test & Deploy"
 
+permissions:
+  contents: read
+
 on:
   workflow_dispatch:
   push:
     branches:
-    - master
+      - master
 
 jobs:
   main:
+    permissions:
+      contents: write
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
-    - name: Set node version
-      uses: actions/setup-node@v3
-      with:
-        node-version: '18.x'
+      - name: Set node version
+        uses: actions/setup-node@v6
+        with:
+          node-version: 18
+          registry-url: "https://registry.npmjs.org"
 
-    - name: Install
-      run: |
-        export DETECT_CHROMEDRIVER_VERSION=true
-        npm install
-        npm run setheapsize
+      - name: Install
+        run: |
+          export DETECT_CHROMEDRIVER_VERSION=true
+          npm install
+          npm run setheapsize
 
-    - name: Lint
-      run: npx grunt lint
+      - name: Lint
+        run: npx grunt lint
 
-    - name: Unit Tests
-      run: |
-        npm test
-        npm run testnodeconsumer
+      - name: Unit Tests
+        run: |
+          npm test
+          npm run testnodeconsumer
 
-    - name: Production Build
-      if: success()
-      run: npx grunt prod --msg=""
+      - name: Production Build
+        if: success()
+        run: npx grunt prod --msg=""
 
-    - name: Generate sitemap
-      run: npx grunt exec:sitemap
+      - name: Generate sitemap
+        run: npx grunt exec:sitemap
 
-    - name: UI Tests
-      if: success()
-      run: |
-        sudo apt-get install xvfb
-        xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
+      - name: UI Tests
+        if: success()
+        run: |
+          sudo apt-get install xvfb
+          xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
 
-    - name: Prepare for GitHub Pages
-      if: success()
-      run: npx grunt copy:ghPages
+      - name: Prepare for GitHub Pages
+        if: success()
+        run: npx grunt copy:ghPages
 
-    - name: Deploy to GitHub Pages
-      if: success() && github.ref == 'refs/heads/master'
-      uses: crazy-max/ghaction-github-pages@v3
-      with:
-        target_branch: gh-pages
-        build_dir: ./build/prod
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Deploy to GitHub Pages
+        if: success() && github.ref == 'refs/heads/master'
+        uses: crazy-max/ghaction-github-pages@v3
+        with:
+          target_branch: gh-pages
+          build_dir: ./build/prod
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pull_requests.yml

@@ -1,5 +1,8 @@
 name: "Pull Requests"
 
+permissions:
+  contents: read
+
 on:
   workflow_dispatch:
   pull_request:
@@ -9,47 +12,46 @@ jobs:
   main:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
-    - name: Set node version
-      uses: actions/setup-node@v3
-      with:
-        node-version: '18.x'
+      - name: Set node version
+        uses: actions/setup-node@v6
+        with:
+          node-version: 18
+          registry-url: "https://registry.npmjs.org"
 
-    - name: Install
-      run: |
-        export DETECT_CHROMEDRIVER_VERSION=true
-        npm install
-        npm run setheapsize
+      - name: Install
+        run: |
+          export DETECT_CHROMEDRIVER_VERSION=true
+          npm install
+          npm run setheapsize
 
-    - name: Lint
-      run: npx grunt lint
+      - name: Lint
+        run: npx grunt lint
 
-    - name: Unit Tests
-      run: |
-        npm test
-        npm run testnodeconsumer
+      - name: Unit Tests
+        run: |
+          npm test
+          npm run testnodeconsumer
 
-    - name: Production Build
-      if: success()
-      run: npx grunt prod
+      - name: Production Build
+        if: success()
+        run: npx grunt prod
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
 
-    - name: Set up QEMU
-      uses: docker/setup-qemu-action@v3
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
 
-    - name: Production Image Build
-      if: success()
-      id: build-image
-      uses: docker/build-push-action@v6
-      with:
-        # Not being uploaded to any registry, use a simple name to allow Buildah to build correctly.
-        image: cyberchef
-        platforms: linux/amd64,linux/arm64
-    - name: UI Tests
-      if: success()
-      run: |
-        sudo apt-get install xvfb
-        xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
+      - name: Production Image Build
+        if: success()
+        id: build-image
+        uses: docker/build-push-action@v6
+        with:
+          platforms: linux/amd64,linux/arm64
+      - name: UI Tests
+        if: success()
+        run: |
+          sudo apt-get install xvfb
+          xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui

.github/workflows/releases.yml

@@ -4,7 +4,11 @@ on:
   workflow_dispatch:
   push:
     tags:
-    - 'v*'
+      - "v*"
+
+permissions:
+  id-token: write
+  contents: read
 
 env:
   REGISTRY: ghcr.io
@@ -16,79 +20,78 @@ jobs:
   main:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
-    - name: Set node version
-      uses: actions/setup-node@v3
-      with:
-        node-version: '18.x'
+      - name: Set node version
+        uses: actions/setup-node@v6
+        with:
+          node-version: 18
+          registry-url: "https://registry.npmjs.org"
 
-    - name: Install
-      run: |
-        export DETECT_CHROMEDRIVER_VERSION=true
-        npm ci
-        npm run setheapsize
+      - name: Install
+        run: |
+          export DETECT_CHROMEDRIVER_VERSION=true
+          npm ci
+          npm run setheapsize
 
-    - name: Lint
-      run: npx grunt lint
+      - name: Lint
+        run: npx grunt lint
 
-    - name: Unit Tests
-      run: |
-        npm test
-        npm run testnodeconsumer
+      - name: Unit Tests
+        run: |
+          npm test
+          npm run testnodeconsumer
 
-    - name: Production Build
-      run: npx grunt prod
+      - name: Production Build
+        run: npx grunt prod
 
-    - name: UI Tests
-      run: |
-        sudo apt-get install xvfb
-        xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
+      - name: UI Tests
+        run: |
+          sudo apt-get install xvfb
+          xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
 
-    - name: Set up QEMU
-      uses: docker/setup-qemu-action@v3
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
 
-    - name: Image Metadata
-      id: image-metadata
-      uses: docker/metadata-action@v4
-      with:
-        images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
-        tags: |
-          type=semver,pattern={{major}}
-          type=semver,pattern={{major}}.{{minor}}
-          type=semver,pattern={{version}}
+      - name: Image Metadata
+        id: image-metadata
+        uses: docker/metadata-action@v4
+        with:
+          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+          tags: |
+            type=semver,pattern={{major}}
+            type=semver,pattern={{major}}.{{minor}}
+            type=semver,pattern={{version}}
 
-    - name: Log in to GHCR
-      uses: docker/login-action@v3
-      with:
-        registry: ${{ env.REGISTRY }}
-        username: ${{ env.REGISTRY_USER }}
-        password: ${{ env.REGISTRY_PASSWORD }}
+      - name: Log in to GHCR
+        uses: docker/login-action@v3
+        with:
+          registry: ${{ env.REGISTRY }}
+          username: ${{ env.REGISTRY_USER }}
+          password: ${{ env.REGISTRY_PASSWORD }}
 
-    - name: Publish to GHCR
-      uses: docker/build-push-action@v6
-      with:
-        context: .
-        push: true
-        tags: ${{ steps.image-metadata.outputs.tags }}
-        labels: ${{ steps.image-metadata.outputs.labels }}
-        platforms: linux/amd64,linux/arm64
+      - name: Publish to GHCR
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          push: true
+          tags: ${{ steps.image-metadata.outputs.tags }}
+          labels: ${{ steps.image-metadata.outputs.labels }}
+          platforms: linux/amd64,linux/arm64
 
-    - name: Upload Release Assets
-      id: upload-release-assets
-      uses: svenstaro/upload-release-action@v2
-      with:
-        repo_token: ${{ secrets.GITHUB_TOKEN }}
-        file: build/prod/*.zip
-        tag: ${{ github.ref }}
-        overwrite: true
-        file_glob: true
-        body: "See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details."
+      - name: Upload Release Assets
+        id: upload-release-assets
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: build/prod/*.zip
+          tag: ${{ github.ref }}
+          overwrite: true
+          file_glob: true
+          body: "See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details."
 
-    - name: Publish to NPM
-      uses: JS-DevTools/npm-publish@v1
-      with:
-        token: ${{ secrets.NPM_TOKEN }}
+      - name: Publish to NPM
+        run: npm publish

src/node/apiUtils.mjs

@@ -66,7 +66,7 @@ export function removeSubheadingsFromArray(array) {
  * @param str
  */
 export function sanitise(str) {
-    return str.replace(/ /g, "").toLowerCase();
+    return str.replace(/[/\s.-]/g, "").toLowerCase();
 }
 
 

tests/node/tests/nodeApi.mjs

@@ -345,6 +345,42 @@ TestRegister.addApiTests([
         assert.strictEqual(result.toString(), "begin_something_aaaaaaaaaaaaaa_end_something");
     }),
 
+    it("chef.bake: should accept operation names from Chef Website which contain forward slash", () => {
+        const result = chef.bake("I'll have the test salmon", [
+            { "op": "Find / Replace",
+                "args": [{ "option": "Regex", "string": "test" }, "good", true, false, true, false]}
+        ]);
+        assert.strictEqual(result.toString(), "I'll have the good salmon");
+    }),
+
+    it("chef.bake: should accept operation names from Chef Website which contain a hyphen", () => {
+        const result = chef.bake("I'll have the test salmon", [
+            { "op": "Adler-32 Checksum",
+                "args": [] }
+        ]);
+        assert.strictEqual(result.toString(), "6e4208f8");
+    }),
+
+    it("chef.bake: should accept operation names from Chef Website which contain a period", () => {
+        const result = chef.bake("30 13 02 01 05 16 0e 41 6e 79 62 6f 64 79 20 74 68 65 72 65 3f", [
+            { "op": "Parse ASN.1 hex string",
+                "args": [0, 32] }
+        ]);
+        assert.strictEqual(result.toString(), `SEQUENCE
+  INTEGER 05
+  IA5String 'Anybody there?'
+`);
+    }),
+
+    it("Excluded operations: throw a sensible error when you try and call one", () => {
+        try {
+            chef.fork();
+        } catch (e) {
+            assert.strictEqual(e.type, "ExcludedOperationError");
+            assert.strictEqual(e.message, "Sorry, the Fork operation is not available in the Node.js version of CyberChef.");
+        }
+    }),
+
     it("chef.bake: cannot accept flowControl operations in recipe", () => {
         assert.throws(() => chef.bake("some input", "magic"), {
             name: "TypeError",